Skip to contentSkip to conversation

i2c: mt7621: Use dev_err_probe() for clock acquisition failures

PATCH New [email protected] 1 participant 1 message Jun 30

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 i2c: mt7621: Use dev_err_probe() for clock acquisition failures

From: bui duc phuc <[email protected]>

Use dev_err_probe() when devm_clk_get_enabled() fails. This correctly handles -EPROBE_DEFER while simplifying the error handling.

No functional change intended.

---

update in v2 :
Add the missing return after dev_err_probe().

 drivers/i2c/busses/i2c-mt7621.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/i2c/busses/i2c-mt7621.c +3 -4
index 0a288c998419..8ab7a304a02c 100644
@@ -280,10 +280,9 @@ static int mtk_i2c_probe(struct platform_device *pdev)
 		return PTR_ERR(i2c->base);
 
 	i2c->clk = devm_clk_get_enabled(&pdev->dev, NULL);
-	if (IS_ERR(i2c->clk)) {
-		dev_err(&pdev->dev, "Failed to enable clock\n");
-		return PTR_ERR(i2c->clk);
-	}
+	if (IS_ERR(i2c->clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
+				     "Failed to enable clock\n");
 
 	i2c->dev = &pdev->dev;
 
Signature · 1 line
2.43.0