powerpc: fsl_rio: Use snprintf() in fsl_rio_setup()
PATCH 1/1 powerpc: fsl_rio: Use snprintf() in fsl_rio_setup()
While the current code works correctly, replace the unbounded sprintf() with the safer snprintf() in fsl_rio_setup() to follow secure coding best practices.
--- arch/powerpc/sysdev/fsl_rio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/sysdev/fsl_rio.c +1 -1
@@ -612,7 +612,7 @@ static int fsl_rio_setup(struct platform_device *dev)kfree (port);continue ; } -sprintf (port->name,"RIO mport %d" , i); +snprintf (port->name,sizeof (port->name),"RIO mport %d" , i); priv->dev = &dev->dev; port->dev.parent = &dev->dev;
Christophe Leroy (CS GROUP)
reviewerLe 30/06/2026 à 16:49, Thorsten Blum a écrit :
Quoted 14 lines
While the current code works correctly, replace the unbounded
sprintf()with the safersnprintf()infsl_rio_setup()to follow secure coding best practices.Signed-off-by Thorsten Blum <[email protected]>--- arch/powerpc/sysdev/fsl_rio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/sysdev/fsl_rio.c +0
-0
arch/powerpc/sysdev/fsl_rio.c static int fsl_rio_setup(struct platform_device *dev) · line 615
Quoted 5 lines
arch/powerpc/sysdev/fsl_rio.c +1
-1@@ -612,7 +612,7 @@ static int fsl_rio_setup(struct platform_device *dev)kfree (port);continue ; } -sprintf (port->name,"RIO mport %d" , i); +snprintf (port->name,sizeof (port->name),"RIO mport %d" , i);
Are you sure it is correct ?
Shouldn't it be sizeof(port->name) - 1 ?
Quoted 3 lines
arch/powerpc/sysdev/fsl_rio.c +0
-0priv->dev = &dev->dev; port->dev.parent = &dev->dev;
Quoted 23 lines · Christophe Leroy (CS GROUP)
Le 30/06/2026 à 16:49, Thorsten Blum a écrit :
Quoted 14 lines
While the current code works correctly, replace the unbounded
sprintf()with the safersnprintf()infsl_rio_setup()to follow secure coding best practices.Signed-off-by Thorsten Blum <[email protected]>--- arch/powerpc/sysdev/fsl_rio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/sysdev/fsl_rio.c +0
-0arch/powerpc/sysdev/fsl_rio.c static int fsl_rio_setup(struct platform_device *dev) · line 615
Quoted 5 lines
arch/powerpc/sysdev/fsl_rio.c +1
-1@@ -612,7 +612,7 @@ static int fsl_rio_setup(struct platform_device *dev)kfree (port);continue ; } -sprintf (port->name,"RIO mport %d" , i); +snprintf (port->name,sizeof (port->name),"RIO mport %d" , i);Are you sure it is correct ?
Quoted 1 line
Shouldn't it be
sizeof(port->name)- 1 ?
snprintf() takes the destination buffer size (including the NUL) as its second argument, so sizeof(port->name) should be correct.
Quoted 8 lines · Thorsten Blum
While the current code works correctly, replace the unbounded
sprintf()with the safersnprintf()infsl_rio_setup()to follow secure coding best practices.Signed-off-by Thorsten Blum <[email protected]>--- arch/powerpc/sysdev/fsl_rio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Gentle ping?
Quoted 13 lines
arch/powerpc/sysdev/fsl_rio.c +1
-1@@ -612,7 +612,7 @@ static int fsl_rio_setup(struct platform_device *dev)kfree (port);continue ; } -sprintf (port->name,"RIO mport %d" , i); +snprintf (port->name,sizeof (port->name),"RIO mport %d" , i); priv->dev = &dev->dev; port->dev.parent = &dev->dev;