Skip to contentSkip to conversation

dhcpcd: Add PACKAGECONFIG for seccomp

PATCH In review Alex Kiernan 2 participants 3 messages Jun 30

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dhcpcd: Add PACKAGECONFIG for seccomp

Pass --enable/disable-seccomp to the build based on DISTRO_FEATURES.

---
 meta/recipes-connectivity/dhcpcd/dhcpcd_10.3.2.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-connectivity/dhcpcd/dhcpcd_10.3.2.bb +2 -1
index 6ebfc195323d..58865e108d24 100644
@@ -24,10 +24,11 @@ inherit pkgconfig autotools-brokensep systemd useradd
 
 SYSTEMD_SERVICE:${PN} = "dhcpcd.service"
 
-PACKAGECONFIG ?= "udev ${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
+PACKAGECONFIG ?= "udev ${@bb.utils.filter('DISTRO_FEATURES', 'ipv6 seccomp', d)}"
 
 PACKAGECONFIG[udev] = "--with-udev,--without-udev,udev,udev"
 PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6"
+PACKAGECONFIG[seccomp] = "--enable-seccomp,--disable-seccomp"
 # ntp conflicts with chrony
 PACKAGECONFIG[ntp] = "--with-hook=ntp, , ,ntp"
 PACKAGECONFIG[chrony] = "--with-hook=ntp, , ,chrony"
#1 lore raw

Does this need libseccomp dependency too ?

Quoted 38 lines · Alex Kiernan via lists.openembedded.org

Pass --enable/disable-seccomp to the build based on DISTRO_FEATURES.

---
 meta/recipes-connectivity/dhcpcd/dhcpcd_10.3.2.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-connectivity/dhcpcd/dhcpcd_10.3.2.bb +1 -1
index 6ebfc195323d..58865e108d24 100644
@@ -24,10 +24,11 @@ inherit pkgconfig autotools-brokensep systemd useradd
 
 SYSTEMD_SERVICE:${PN} = "dhcpcd.service"
 
-PACKAGECONFIG ?= "udev ${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
+PACKAGECONFIG ?= "udev ${@bb.utils.filter('DISTRO_FEATURES', 'ipv6

seccomp', d)}"

PACKAGECONFIG[udev] = "--with-udev,--without-udev,udev,udev" PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6"
+PACKAGECONFIG[seccomp] = "--enable-seccomp,--disable-seccomp"

 # ntp conflicts with chrony
 PACKAGECONFIG[ntp] = "--with-hook=ntp, , ,ntp"
 PACKAGECONFIG[chrony] = "--with-hook=ntp, , ,chrony"

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#239905):
https://lists.openembedded.org/g/openembedded-core/message/239905
Mute This Topic: https://lists.openembedded.org/mt/120048679/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw

Oddly no... it's hand coded (and defaults on):

https://github.com/NetworkConfiguration/dhcpcd/blob/8b312918d8f1885d7fe8fcc03a7e06ae8a0314b4/src/privsep-linux.c#L127

Possibly even more oddly, I actually wanted this option because I'm stuck with a legacy vendor kernel which doesn't have seccomp and I was trying to deal with all the noise that a sensible userland generates! The next job is to get rid of the legacy kernel, but one thing at a time.

Quoted 38 lines · Khem Raj

Does this need libseccomp dependency too ?

Quoted 34 lines · Alex Kiernan via lists.openembedded.org

Pass --enable/disable-seccomp to the build based on DISTRO_FEATURES.

---
 meta/recipes-connectivity/dhcpcd/dhcpcd_10.3.2.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-connectivity/dhcpcd/dhcpcd_10.3.2.bb +2 -2
index 6ebfc195323d..58865e108d24 100644
@@ -24,10 +24,11 @@ inherit pkgconfig autotools-brokensep systemd useradd
 
 SYSTEMD_SERVICE:${PN} = "dhcpcd.service"
 
-PACKAGECONFIG ?= "udev ${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
+PACKAGECONFIG ?= "udev ${@bb.utils.filter('DISTRO_FEATURES', 'ipv6 seccomp', d)}"
 
 PACKAGECONFIG[udev] = "--with-udev,--without-udev,udev,udev"
 PACKAGECONFIG[ipv6] = "--enable-ipv6,--disable-ipv6"
+PACKAGECONFIG[seccomp] = "--enable-seccomp,--disable-seccomp"
 # ntp conflicts with chrony
 PACKAGECONFIG[ntp] = "--with-hook=ntp, , ,ntp"
 PACKAGECONFIG[chrony] = "--with-hook=ntp, , ,chrony"
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#239905): https://lists.openembedded.org/g/openembedded-core/message/239905
Mute This Topic: https://lists.openembedded.org/mt/120048679/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 1 line
Alex Kiernan