Skip to contentSkip to conversation

usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

PATCH Superseded Chaoyi Chen 3 participants 3 messages Jul 2 – Jul 3

Subsystems (3)
USB USB Type-C class USB Type-C bus for alternate modes

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Chaoyi Chen

author
#0 lore raw

PATCH 1/1 usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

From: Chaoyi Chen <[email protected]>

When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely also needed for embedded platforms. Select it when available.

Suggested-by Xu Yang <[email protected]>
Signed-off-by Chaoyi Chen <[email protected]>
---
 drivers/usb/typec/altmodes/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/typec/altmodes/Kconfig +1 -0
index 7867fa7c405d..b054c0b6a8d4 100644
@@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers"
 config TYPEC_DP_ALTMODE
 	tristate "DisplayPort Alternate Mode driver"
 	depends on DRM
+	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
 	help
 	  DisplayPort USB Type-C Alternate Mode allows DisplayPort
 	  displays and adapters to be attached to the USB Type-C
Signature · 1 line
2.54.0
#1 lore raw

Hi Chaovi,

drivers/usb/typec/altmodes/Kconfig menu "USB Type-C Alternate Mode drivers" · line 8

Quoted 4 lines · Chaoyi Chen

most likely
also needed

drivers/usb/typec/altmodes/Kconfig +1 -0
+	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF

Perhaps 'imply' would be more appropriate here instead of 'select'?

- Julian Braha

#2 lore raw

Hello Julian,

Quoted 10 lines · Julian Braha

Hi Chaovi,

drivers/usb/typec/altmodes/Kconfig menu "USB Type-C Alternate Mode drivers" · line 8

Quoted 4 lines · Chaoyi Chen

most likely
also needed

drivers/usb/typec/altmodes/Kconfig +1 -0
+	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF

Perhaps 'imply' would be more appropriate here instead of 'select'?

Will fix in v2. Thank you!

Signature · 2 lines
Best, 
Chaoyi