rcutorture: Use __set_current_state() set task state in rcu_nocb_toggle()
Subsystems (2)
Zqiang
reviewerPATCH 1/1 rcutorture: Use __set_current_state() set task state in rcu_nocb_toggle()
In the rcu_nocb_toggle(), the schedule_hrtimeout() is called after the state assignment with no condition check. the release-acquire pair from raw_spin_unlock/lock(&cpu_base->lock), guarantee that task->__state is visible to the hrtimer callback:
CPU0 CPU1__set_current_state(TASK_INTERRUPTIBLE)
->WRITE_ONCE(task->__state, TASK_INTERRUPTIBLE)schedule_hrtimeout
->hrtimer_sleeper_start_expires()
->raw_spin_lock_irqsave(&cpu_base->lock)
....
->raw_spin_unlock_irqrestore(&cpu_base->lock)
hard-irq: raw_spin_lock_irqsave(&cpu_base->lock) __hrtimer_run_queues ->__run_hrtimer ->raw_spin_unlock_irqrestore(&cpu_base->lock) ->fn(timer) ->hrtimer_wakeup ->wake_up_process ->try_to_wake_up ->READ task->__state
This commit therefore use the __set_current_state() to replace the set_current_state() in rcu_nocb_toggle().
--- kernel/rcu/rcutorture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/rcutorture.c +1 -1
@@ -2947,7 +2947,7 @@ static int rcu_nocb_toggle(void *arg)atomic_long_inc (&n_nocb_deoffload); } toggle_delay =torture_random (&rand) % toggle_fuzz + toggle_interval; -set_current_state (TASK_INTERRUPTIBLE ); +__set_current_state (TASK_INTERRUPTIBLE );schedule_hrtimeout (&toggle_delay,HRTIMER_MODE_REL );if (stutter_wait ("rcu_nocb_toggle" ))sched_set_normal (current, oldnice);
Signature · 1 line
2.17.1
Paul E. McKenney
maintainerQuoted 25 lines · Zqiang
In the
rcu_nocb_toggle(), theschedule_hrtimeout()is called after the state assignment with no condition check. the release-acquire pair from raw_spin_unlock/lock(&cpu_base->lock), guarantee thattask->__stateis visible to the hrtimer callback:CPU0 CPU1
__set_current_state(TASK_INTERRUPTIBLE)
->WRITE_ONCE(task->__state,TASK_INTERRUPTIBLE)schedule_hrtimeout
->hrtimer_sleeper_start_expires()
->raw_spin_lock_irqsave(&cpu_base->lock)....->raw_spin_unlock_irqrestore(&cpu_base->lock)
hard-irq: raw_spin_lock_irqsave(&cpu_base->lock) __hrtimer_run_queues ->__run_hrtimer ->raw_spin_unlock_irqrestore(&cpu_base->lock) ->fn(timer) ->hrtimer_wakeup ->wake_up_process ->try_to_wake_up ->READ task->__state
Quoted 4 lines
This commit therefore use the
__set_current_state()to replace theset_current_state()inrcu_nocb_toggle().Signed-off-by Zqiang <[email protected]>
This looks correct, and either drops an smp_mb() or converts an xchg() to a WRITE_ONCE(), which does decrease overhead. Except that rcu_nocb_toggle() is invoked very infrequently and has high overhead that I would expect to lose this overhead decrease in the noise. And it forces those reading the code to go figure out what is different between set_current_state() and __set_current_state().
So I am not convinced to take this patch. But am I missing something here?
Thanx, Paul
Quoted 20 lines
--- kernel/rcu/rcutorture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/rcu/rcutorture.c +1
-1@@ -2947,7 +2947,7 @@ static int rcu_nocb_toggle(void *arg)atomic_long_inc (&n_nocb_deoffload); } toggle_delay =torture_random (&rand) % toggle_fuzz + toggle_interval; -set_current_state (TASK_INTERRUPTIBLE ); +__set_current_state (TASK_INTERRUPTIBLE );schedule_hrtimeout (&toggle_delay,HRTIMER_MODE_REL );if (stutter_wait ("rcu_nocb_toggle" ))sched_set_normal (current, oldnice);Signature · 1 line
2.17.1
Zqiang
reviewerQuoted 34 lines · Zqiang
Quoted 27 lines
In the
rcu_nocb_toggle(), theschedule_hrtimeout()is called after the
state assignment with no condition check. the release-acquire pair from raw_spin_unlock/lock(&cpu_base->lock), guarantee thattask->__stateis visible to the hrtimer callback:CPU0 CPU1
__set_current_state(TASK_INTERRUPTIBLE)
->WRITE_ONCE(task->__state,TASK_INTERRUPTIBLE)
schedule_hrtimeout
->hrtimer_sleeper_start_expires()
->raw_spin_lock_irqsave(&cpu_base->lock)
....
->raw_spin_unlock_irqrestore(&cpu_base->lock)hard-irq:
raw_spin_lock_irqsave(&cpu_base->lock)
__hrtimer_run_queues
->__run_hrtimer
->raw_spin_unlock_irqrestore(&cpu_base->lock)
->fn(timer)
->hrtimer_wakeup
->wake_up_process
->try_to_wake_up
->READtask->__stateQuoted 5 lines
This commit therefore use the
__set_current_state()to replace theset_current_state()inrcu_nocb_toggle().Signed-off-by Zqiang <[email protected]>
Quoted 8 lines
This looks correct, and either drops an
smp_mb()or converts anxchg()to aWRITE_ONCE(), which does decrease overhead. Except thatrcu_nocb_toggle()is invoked very infrequently and has high overhead that I would expect to lose this overhead decrease in the noise. And it forces those reading the code to go figure out what is different betweenset_current_state()and__set_current_state().So I am not convinced to take this patch. But am I missing something here?
Nothing was missed, only from memory ordering perspective, using set_current_state() is unnecessary. furthermore, in RCU tasks, we used the following code:
__set_current_state(TASK_IDLE); // in this we use __set_current_state() schedule_hrtimeout_range(&exp, jiffies_to_nsecs(HZ / 2), HRTIMER_MODE_REL_HARD);
Or perhaps we could also add a comment something like this(kernel/time/sleep_timeout.c):
/*
* __set_current_state() can be used in schedule_timeout_*() functions, because
* schedule_timeout() calls schedule() unconditionally.
*/
Thanks
Zqiang
Quoted 25 lines
Thanx, Paul
Quoted 21 lines
--- kernel/rcu/rcutorture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git
a/kernel/rcu/rcutorture.cb/kernel/rcu/rcutorture.cindexb1bab59efde5..a0e6901e0f90100644
---a/kernel/rcu/rcutorture.c
+++b/kernel/rcu/rcutorture.c
@@ -2947,7 +2947,7 @@ static intrcu_nocb_toggle(void *arg)atomic_long_inc(&n_nocb_deoffload);
}
toggle_delay=torture_random(&rand)%toggle_fuzz+toggle_interval;
-set_current_state(TASK_INTERRUPTIBLE);
+__set_current_state(TASK_INTERRUPTIBLE);schedule_hrtimeout(&toggle_delay, HRTIMER_MODE_REL);
if (stutter_wait("rcu_nocb_toggle"))sched_set_normal(current, oldnice);
--
2.17.1
Quoted 30 lines · Paul E. McKenney
Quoted 28 lines · Zqiang
In the
rcu_nocb_toggle(), theschedule_hrtimeout()is called after the state assignment with no condition check. the release-acquire pair from raw_spin_unlock/lock(&cpu_base->lock), guarantee thattask->__stateis visible to the hrtimer callback:CPU0 CPU1
__set_current_state(TASK_INTERRUPTIBLE)
->WRITE_ONCE(task->__state,TASK_INTERRUPTIBLE)schedule_hrtimeout
->hrtimer_sleeper_start_expires()
->raw_spin_lock_irqsave(&cpu_base->lock)
....
->raw_spin_unlock_irqrestore(&cpu_base->lock)hard-irq:
raw_spin_lock_irqsave(&cpu_base->lock)__hrtimer_run_queues
->__run_hrtimer
->raw_spin_unlock_irqrestore(&cpu_base->lock)
->fn(timer)
->hrtimer_wakeup->wake_up_process->try_to_wake_up
->READtask->__stateThis commit therefore use the
__set_current_state()to replace theset_current_state()inrcu_nocb_toggle().
Quoted 7 lines
Quoted 1 line
Signed-off-by Zqiang <[email protected]>This looks correct, and either drops an
smp_mb()or converts anxchg()to aWRITE_ONCE(), which does decrease overhead. Except thatrcu_nocb_toggle()is invoked very infrequently and has high overhead that I would expect to lose this overhead decrease in the noise. And it forces those reading the code to go figure out what is different between
Agreed. I did end up reading the code.
Quoted 27 lines
set_current_state()and__set_current_state().So I am not convinced to take this patch. But am I missing something here?
Thanx, Paul
Quoted 20 lines
---
kernel/rcu/rcutorture.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)kernel/rcu/rcutorture.c +1
-1@@ -2947,7 +2947,7 @@ static int rcu_nocb_toggle(void *arg)atomic_long_inc (&n_nocb_deoffload); } toggle_delay =torture_random (&rand) % toggle_fuzz + toggle_interval; -set_current_state (TASK_INTERRUPTIBLE ); +__set_current_state (TASK_INTERRUPTIBLE );schedule_hrtimeout (&toggle_delay,HRTIMER_MODE_REL );if (stutter_wait ("rcu_nocb_toggle" ))sched_set_normal (current, oldnice);Signature · 1 line
2.17.1
Paul E. McKenney
maintainerQuoted 50 lines · Zqiang
Quoted 34 lines · Zqiang
Quoted 27 lines
In the
rcu_nocb_toggle(), theschedule_hrtimeout()is called after the
state assignment with no condition check. the release-acquire pair from raw_spin_unlock/lock(&cpu_base->lock), guarantee thattask->__stateis visible to the hrtimer callback:CPU0 CPU1
__set_current_state(TASK_INTERRUPTIBLE)
->WRITE_ONCE(task->__state,TASK_INTERRUPTIBLE)
schedule_hrtimeout
->hrtimer_sleeper_start_expires()
->raw_spin_lock_irqsave(&cpu_base->lock)
....
->raw_spin_unlock_irqrestore(&cpu_base->lock)hard-irq:
raw_spin_lock_irqsave(&cpu_base->lock)
__hrtimer_run_queues
->__run_hrtimer
->raw_spin_unlock_irqrestore(&cpu_base->lock)
->fn(timer)
->hrtimer_wakeup
->wake_up_process
->try_to_wake_up
->READtask->__stateQuoted 5 lines
This commit therefore use the
__set_current_state()to replace theset_current_state()inrcu_nocb_toggle().Signed-off-by Zqiang <[email protected]>Quoted 8 lines
This looks correct, and either drops an
smp_mb()or converts anxchg()to aWRITE_ONCE(), which does decrease overhead. Except thatrcu_nocb_toggle()is invoked very infrequently and has high overhead that I would expect to lose this overhead decrease in the noise. And it forces those reading the code to go figure out what is different betweenset_current_state()and__set_current_state().So I am not convinced to take this patch. But am I missing something here?
Nothing was missed, only from memory ordering perspective, using
set_current_state()is unnecessary. furthermore, in RCU tasks, we used the following code:
__set_current_state(TASK_IDLE); // in this we use__set_current_state()schedule_hrtimeout_range(&exp, jiffies_to_nsecs(HZ / 2), HRTIMER_MODE_REL_HARD);
Quoted 6 lines
Or perhaps we could also add a comment something like
this(kernel/time/sleep_timeout.c):/*
*__set_current_state()can be used in schedule_timeout_*() functions, because
*schedule_timeout()callsschedule()unconditionally.
*/
Would it make sense for a variant of schedule_hrtimeout_range() to take an TASK_* argument and then use __set_current_state() internally? That would get you the performance increase across all calls, but avoid bothering the typical user with the difference between __set_current_state() vs. set_current_state().
Thanx, Paul
Quoted 29 lines
Thanks
ZqiangQuoted 25 lines
Thanx, Paul
Quoted 21 lines
--- kernel/rcu/rcutorture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git
a/kernel/rcu/rcutorture.cb/kernel/rcu/rcutorture.cindexb1bab59efde5..a0e6901e0f90100644
---a/kernel/rcu/rcutorture.c
+++b/kernel/rcu/rcutorture.c
@@ -2947,7 +2947,7 @@ static intrcu_nocb_toggle(void *arg)atomic_long_inc(&n_nocb_deoffload);
}
toggle_delay=torture_random(&rand)%toggle_fuzz+toggle_interval;
-set_current_state(TASK_INTERRUPTIBLE);
+__set_current_state(TASK_INTERRUPTIBLE);schedule_hrtimeout(&toggle_delay, HRTIMER_MODE_REL);
if (stutter_wait("rcu_nocb_toggle"))sched_set_normal(current, oldnice);
--
2.17.1
Zqiang
reviewerQuoted 60 lines · Zqiang
Quoted 51 lines · Zqiang
Quoted 27 lines
In the
rcu_nocb_toggle(), theschedule_hrtimeout()is called after the state assignment with no condition check. the release-acquire pair from raw_spin_unlock/lock(&cpu_base->lock), guarantee thattask->__stateis visible to the hrtimer callback:CPU0 CPU1
__set_current_state(TASK_INTERRUPTIBLE)
->WRITE_ONCE(task->__state,TASK_INTERRUPTIBLE)schedule_hrtimeout
->hrtimer_sleeper_start_expires()
->raw_spin_lock_irqsave(&cpu_base->lock)
....
->raw_spin_unlock_irqrestore(&cpu_base->lock)hard-irq:
raw_spin_lock_irqsave(&cpu_base->lock)__hrtimer_run_queues
->__run_hrtimer
->raw_spin_unlock_irqrestore(&cpu_base->lock)
->fn(timer)
->hrtimer_wakeup
->wake_up_process
->try_to_wake_up
->READtask->__stateQuoted 5 lines
This commit therefore use the
__set_current_state()to replace theset_current_state()inrcu_nocb_toggle().Signed-off-by Zqiang <[email protected]>This looks correct, and either drops an
smp_mb()or converts anxchg()to aWRITE_ONCE(), which does decrease overhead. Except thatrcu_nocb_toggle()is invoked very infrequently and has high overhead that I would expect to lose this overhead decrease in the noise. And it forces those reading the code to go figure out what is different betweenset_current_state()and__set_current_state().So I am not convinced to take this patch. But am I missing something here?
Nothing was missed, only from memory ordering perspective, using
set_current_state()is unnecessary. furthermore, in RCU tasks, we used the following code:
__set_current_state(TASK_IDLE); // in this we use__set_current_state()schedule_hrtimeout_range(&exp, jiffies_to_nsecs(HZ / 2), HRTIMER_MODE_REL_HARD);Quoted 7 lines
Or perhaps we could also add a comment something like
this(kernel/time/sleep_timeout.c):/*
*__set_current_state()can be used in schedule_timeout_*() functions, because
*schedule_timeout()callsschedule()unconditionally.
*/
Quoted 5 lines
Would it make sense for a variant of
schedule_hrtimeout_range()to take an TASK_* argument and then use__set_current_state()internally? That would get you the performance increase across all calls, but avoid bothering the typical user with the difference between__set_current_state()vs.set_current_state().
This is a good idea.
Thanks
Zqiang
Quoted 34 lines
Thanx, Paul
Quoted 30 lines
Thanks
ZqiangThanx, Paul
Quoted 21 lines
---
kernel/rcu/rcutorture.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)kernel/rcu/rcutorture.c +1
-1@@ -2947,7 +2947,7 @@ static int rcu_nocb_toggle(void *arg)atomic_long_inc (&n_nocb_deoffload); } toggle_delay =torture_random (&rand) % toggle_fuzz + toggle_interval; -set_current_state (TASK_INTERRUPTIBLE ); +__set_current_state (TASK_INTERRUPTIBLE );schedule_hrtimeout (&toggle_delay,HRTIMER_MODE_REL );if (stutter_wait ("rcu_nocb_toggle" ))sched_set_normal (current, oldnice);Signature · 1 line
2.17.1