Skip to contentSkip to conversation

drm/xe: remove duplicate <kunit/test-bug.h> include

PATCH In review Anas Khan 3 participants 3 messages Jul 2 – Jul 3

Subsystems (2)
lore
Share & tools
lore

Anas Khan

author
#0 lore raw

PATCH 1/1 drm/xe: remove duplicate <kunit/test-bug.h> include

xe_pci.c includes <kunit/test-bug.h> twice, separated only by the <kunit/test.h> include. Drop the redundant second include; this is a non-functional cleanup flagged by scripts/checkincludes.pl.

Fixes 6cad22853cb8 ("drm/xe/kunit: Add stub to read_gmdid")
---
 drivers/gpu/drm/xe/tests/xe_pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/xe/tests/xe_pci.c +0 -1
index 9240aff779da..c2c686aed1cb 100644
@@ -9,7 +9,6 @@
 
 #include <kunit/test-bug.h>
 #include <kunit/test.h>
-#include <kunit/test-bug.h>
 #include <kunit/visibility.h>
 
 #define PLATFORM_CASE(platform__, graphics_step__)					\
Signature · 1 line
2.54.0
#1 lore raw

✗ LGCI.VerificationFailed: failure for drm/xe: remove duplicate <kunit/test-bug.h> include

== Series Details ==

== Series Details ==

Series: drm/xe: remove duplicate <kunit/test-bug.h> include
URL : https://patchwork.freedesktop.org/series/169699/
State : failure

== Summary ==

Series author address '[email protected]' is not on the allowlist, which prevents CI from being automatically triggered. If you want CI to run for this series, ask Patchwork project owners to click 'retest' on the series in Patchwork. Exception occurred during validation, bailing out!
Build URL: http://intel-gfx-ci-public.igk.intel.com:8080/job/xe_pw_trigger/1202768/ (on master)

maintainer
#2 lore raw
In reply to Anas Khan
Quoted 15 lines · Anas Khan

xe_pci.c includes <kunit/test-bug.h> twice, separated only by the <kunit/test.h> include. Drop the redundant second include; this is a non-functional cleanup flagged by scripts/checkincludes.pl.

Fixes 6cad22853cb8 ("drm/xe/kunit: Add stub to read_gmdid")
---
 drivers/gpu/drm/xe/tests/xe_pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/xe/tests/xe_pci.c +0 -0
index 9240aff779da..c2c686aed1cb 100644

drivers/gpu/drm/xe/tests/xe_pci.c line 12

Quoted 4 lines
drivers/gpu/drm/xe/tests/xe_pci.c +0 -1
@@ -9,7 +9,6 @@
 
 #include <kunit/test-bug.h>
 #include <kunit/test.h>
-#include <kunit/test-bug.h>

Thanks for the patch, pushed to drm-xe-next

Quoted 6 lines
drivers/gpu/drm/xe/tests/xe_pci.c +0 -0
 #include <kunit/visibility.h>
 
 #define PLATFORM_CASE(platform__, graphics_step__)					\
Signature · 1 line
2.54.0