Skip to contentSkip to conversation

common: log mkfs output in _test_streams

PATCH Superseded Christoph Hellwig 2 participants 2 messages Jul 3 – Jul 4

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 common: log mkfs output in _test_streams

Log the mkfs output to allow debugging the mkfs paramters, especially when mkfs and thus the test fails.

---

Changes since v1:
- append to $seqres.full instead of overwriting it

 common/filestreams | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/filestreams +1 -1
index 459de8c6b6a6..c40b33e4b0b8 100644
@@ -89,7 +89,7 @@ _test_streams() {
 	# Skip these tests on zoned file systems as filestreams don't work
 	# with the zoned allocator, and the operation below would force it into
 	# the tiny data section only used for metadata anyway.
-	_try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
+	_try_scratch_mkfs_xfs 2>$seqres.full 2>&1 || _fail "mkfs failed"
 	_scratch_mount
 	_require_xfs_scratch_non_zoned
 	_scratch_unmount 2>/dev/null
Signature · 1 line
2.53.0
#1 lore raw
Quoted 17 lines · Christoph Hellwig

Log the mkfs output to allow debugging the mkfs paramters, especially when mkfs and thus the test fails.

---

Changes since v1:
- append to $seqres.full instead of overwriting it

 common/filestreams | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/filestreams +0 -0
index 459de8c6b6a6..c40b33e4b0b8 100644

common/filestreams _test_streams() { · line 92

Quoted 5 lines
common/filestreams +1 -1
@@ -89,7 +89,7 @@ _test_streams() {
 	# Skip these tests on zoned file systems as filestreams don't work
 	# with the zoned allocator, and the operation below would force it into
 	# the tiny data section only used for metadata anyway.
-	_try_scratch_mkfs_xfs >/dev/null 2>&1 || _fail "mkfs failed"
+	_try_scratch_mkfs_xfs 2>$seqres.full 2>&1 || _fail "mkfs failed"

^^ this still truncates seqres.full

What you want here is: 2>>$seqres.full

--D

Quoted 6 lines
common/filestreams +0 -0
 	_scratch_mount
 	_require_xfs_scratch_non_zoned
 	_scratch_unmount 2>/dev/null
Signature · 1 line
2.53.0