Skip to contentSkip to conversation

netfs: release readahead folios on iterator preparation failure

PATCH New Yichong Chen 1 participant 1 message Jul 4

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netfs: release readahead folios on iterator preparation failure

netfs_prepare_read_iterator() batches readahead folios in put_batch so that the folio references can be dropped after the I/O iterator has been prepared.

If rolling_buffer_load_from_ra() fails after earlier folios have been batched, the function returns immediately and leaves those references held. Release the batch before returning the error.

---
 fs/netfs/buffered_read.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
fs/netfs/buffered_read.c +3 -1
index 76d0f6a29aba..68534cef37cd 100644
@@ -102,8 +102,10 @@ static ssize_t netfs_prepare_read_iterator(struct netfs_io_subrequest *subreq,
 
 			added = rolling_buffer_load_from_ra(&rreq->buffer, ractl,
 							    &put_batch);
-			if (added < 0)
+			if (added < 0) {
+				folio_batch_release(&put_batch);
 				return added;
+			}
 			rreq->submitted += added;
 		}
 		folio_batch_release(&put_batch);
Signature · 1 line
2.51.0