Skip to contentSkip to conversation

fstests: generic: add a basic cachestat test case

PATCH Superseded Qu Wenruo 3 participants 3 messages Jul 7 Btrfs file system

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

PATCH 1/1 fstests: generic: add a basic cachestat test case

The test case is inspired by LTP, where there is a regression on 64K page size systems with btrfs, that after a fsync, cachestat() still report dirty pages.

The test case itself is pretty simple, fill the file with a buffered write that is 1/2/4/8/16 page sized, call cachestat() to make sure the cached/dirtied number match the page number.

Then do a fsync(), and make sure the dirty page number reduced to 0 meanwhile cached is still the same.

---
 tests/generic/798     | 57 +++++++++++++++++++++++++++++++++++++++++++
 tests/generic/798.out |  2 ++
 2 files changed, 59 insertions(+)
 create mode 100755 tests/generic/798
 create mode 100644 tests/generic/798.out
tests/generic/798 new file +57 -0
new file mode 100755
index 00000000..4328475e
@@ -0,0 +1,57 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2026 SUSE S.A.  All Rights Reserved.
+#
+# FS QA Test 798
+#
+# Basic tests for cachestate()
+#
+. ./common/preamble
+_begin_fstest auto quick
+
+_require_xfs_io_command "cachestat"
+_require_scratch
+
+pagesize=$(_get_page_size)
+
+for num_page in 1 2 4 8 16; do
+	size=$(($pagesize * $num_page))
+
+	echo "=== Test with $num_page pages ===" >> $seqres.full
+	_scratch_mkfs > /dev/null
+	_scratch_mount
+
+	# Basic cached number reporting
+	$XFS_IO_PROG -f -c "pwrite -b $pagesize 0 $size" \
+		$SCRATCH_MNT/foobar >> $seqres.full
+	$XFS_IO_PROG -c "cachestat 0 $size" $SCRATCH_MNT/foobar > $tmp.output
+	cat $tmp.output >> $seqres.full
+	cached=$(cat $tmp.output | cut -f1 -d, | awk '{print $2}')
+	dirtied=$(cat $tmp.output | cut -f2 -d, | awk '{print $2}')
+
+	if [ "$cached" -ne "$num_page" ]; then
+		_fail "cached not matching the page number"
+	fi
+
+	if [ "$cached" -ne "$dirtied" ]; then
+		_fail "dirited not matching the page number"
+	fi
+	$XFS_IO_PROG -c "fsync" $SCRATCH_MNT/foobar >> $seqres.full
+
+	# Test dirty page number reporting after a fsync.
+	$XFS_IO_PROG -c "cachestat 0 $size" $SCRATCH_MNT/foobar > $tmp.output
+	cat $tmp.output >> $seqres.full
+	_scratch_unmount
+	cached=$(cat $tmp.output | cut -f1 -d, | awk '{print $2}')
+	dirtied=$(cat $tmp.output | cut -f2 -d, | awk '{print $2}')
+
+	if [ "$cached" -ne "$num_page" ]; then
+		_fail "cached not matching the page number"
+	fi
+	if [ "$dirtied" -ne 0 ]; then
+		_fail "dirtied pages not zero"
+	fi
+done
+
+echo "Silence is golden"
+_exit 0
tests/generic/798.out new file +2 -0
new file mode 100644
index 00000000..216d6e93
@@ -0,0 +1,2 @@
+QA output created by 798
+Silence is golden
Signature · 1 line
2.51.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 89 lines · Qu Wenruo

The test case is inspired by LTP, where there is a regression on 64K page size systems with btrfs, that after a fsync, cachestat() still report dirty pages.

The test case itself is pretty simple, fill the file with a buffered write that is 1/2/4/8/16 page sized, call cachestat() to make sure the cached/dirtied number match the page number.

Then do a fsync(), and make sure the dirty page number reduced to 0 meanwhile cached is still the same.

---
 tests/generic/798     | 57 +++++++++++++++++++++++++++++++++++++++++++
 tests/generic/798.out |  2 ++
 2 files changed, 59 insertions(+)
 create mode 100755 tests/generic/798
 create mode 100644 tests/generic/798.out
tests/generic/798 new file +57 -0
new file mode 100755
index 00000000..4328475e
@@ -0,0 +1,57 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2026 SUSE S.A.  All Rights Reserved.
+#
+# FS QA Test 798
+#
+# Basic tests for cachestate()
+#
+. ./common/preamble
+_begin_fstest auto quick
+
+_require_xfs_io_command "cachestat"
+_require_scratch
+
+pagesize=$(_get_page_size)
+
+for num_page in 1 2 4 8 16; do
+	size=$(($pagesize * $num_page))
+
+	echo "=== Test with $num_page pages ===" >> $seqres.full
+	_scratch_mkfs > /dev/null
+	_scratch_mount
+
+	# Basic cached number reporting
+	$XFS_IO_PROG -f -c "pwrite -b $pagesize 0 $size" \
+		$SCRATCH_MNT/foobar >> $seqres.full
+	$XFS_IO_PROG -c "cachestat 0 $size" $SCRATCH_MNT/foobar > $tmp.output
+	cat $tmp.output >> $seqres.full
+	cached=$(cat $tmp.output | cut -f1 -d, | awk '{print $2}')
+	dirtied=$(cat $tmp.output | cut -f2 -d, | awk '{print $2}')
+
+	if [ "$cached" -ne "$num_page" ]; then
+		_fail "cached not matching the page number"
+	fi
+
+	if [ "$cached" -ne "$dirtied" ]; then
+		_fail "dirited not matching the page number"
+	fi
+	$XFS_IO_PROG -c "fsync" $SCRATCH_MNT/foobar >> $seqres.full
+
+	# Test dirty page number reporting after a fsync.
+	$XFS_IO_PROG -c "cachestat 0 $size" $SCRATCH_MNT/foobar > $tmp.output
+	cat $tmp.output >> $seqres.full
+	_scratch_unmount
+	cached=$(cat $tmp.output | cut -f1 -d, | awk '{print $2}')
+	dirtied=$(cat $tmp.output | cut -f2 -d, | awk '{print $2}')
+
+	if [ "$cached" -ne "$num_page" ]; then
+		_fail "cached not matching the page number"
+	fi
+	if [ "$dirtied" -ne 0 ]; then
+		_fail "dirtied pages not zero"
+	fi
+done
+
+echo "Silence is golden"
+_exit 0
tests/generic/798.out new file +0 -0
new file mode 100644
index 00000000..216d6e93

tests/generic/798.out line 2

Quoted 2 lines
tests/generic/798.out new file +2 -0
@@ -0,0 +1,2 @@
+QA output created by 798
+Silence is golden

Nice.

Thanks

#2 lore raw
In reply to Qu Wenruo
Quoted 46 lines · Qu Wenruo

The test case is inspired by LTP, where there is a regression on 64K page size systems with btrfs, that after a fsync, cachestat() still report dirty pages.

The test case itself is pretty simple, fill the file with a buffered write that is 1/2/4/8/16 page sized, call cachestat() to make sure the cached/dirtied number match the page number.

Then do a fsync(), and make sure the dirty page number reduced to 0 meanwhile cached is still the same.

---
 tests/generic/798     | 57 +++++++++++++++++++++++++++++++++++++++++++
 tests/generic/798.out |  2 ++
 2 files changed, 59 insertions(+)
 create mode 100755 tests/generic/798
 create mode 100644 tests/generic/798.out
tests/generic/798 new file +19 -0
new file mode 100755
index 00000000..4328475e
@@ -0,0 +1,57 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2026 SUSE S.A.  All Rights Reserved.
+#
+# FS QA Test 798
+#
+# Basic tests for cachestate()
+#
+. ./common/preamble
+_begin_fstest auto quick
+
+_require_xfs_io_command "cachestat"
+_require_scratch
+
+pagesize=$(_get_page_size)
+
+for num_page in 1 2 4 8 16; do
+       size=$(($pagesize * $num_page))
+

tests/generic/798 line 29

Quoted 10 lines
tests/generic/798 new file +10 -0
+       echo "=== Test with $num_page pages ===" >> $seqres.full
+       _scratch_mkfs > /dev/null
+       _scratch_mount
+
+       # Basic cached number reporting
+       $XFS_IO_PROG -f -c "pwrite -b $pagesize 0 $size" \
+               $SCRATCH_MNT/foobar >> $seqres.full
+       $XFS_IO_PROG -c "cachestat 0 $size" $SCRATCH_MNT/foobar > $tmp.output
+       cat $tmp.output >> $seqres.full
+       cached=$(cat $tmp.output | cut -f1 -d, | awk '{print $2}')

Use $AWK_PROG everywhere.

tests/generic/798 line 39

Quoted 10 lines
tests/generic/798 new file +10 -0
+       dirtied=$(cat $tmp.output | cut -f2 -d, | awk '{print $2}')
+
+       if [ "$cached" -ne "$num_page" ]; then
+               _fail "cached not matching the page number"
+       fi
+
+       if [ "$cached" -ne "$dirtied" ]; then
+               _fail "dirited not matching the page number"
+       fi
+       $XFS_IO_PROG -c "fsync" $SCRATCH_MNT/foobar >> $seqres.full

The redirection isn't needed; on success the fsync command sends nothing to stdout.

Thanks.

Quoted 30 lines
tests/generic/798 new file +18 -0
+
+       # Test dirty page number reporting after a fsync.
+       $XFS_IO_PROG -c "cachestat 0 $size" $SCRATCH_MNT/foobar > $tmp.output
+       cat $tmp.output >> $seqres.full
+       _scratch_unmount
+       cached=$(cat $tmp.output | cut -f1 -d, | awk '{print $2}')
+       dirtied=$(cat $tmp.output | cut -f2 -d, | awk '{print $2}')
+
+       if [ "$cached" -ne "$num_page" ]; then
+               _fail "cached not matching the page number"
+       fi
+       if [ "$dirtied" -ne 0 ]; then
+               _fail "dirtied pages not zero"
+       fi
+done
+
+echo "Silence is golden"
+_exit 0
tests/generic/798.out new file +2 -1
new file mode 100644
index 00000000..216d6e93
@@ -0,0 +1,2 @@
+QA output created by 798
+Silence is golden
--

2.51.2