Skip to contentSkip to conversation

syscalls: Replace getppid02 with getpid02 implementation

PATCH In review Jinseok Kim 2 participants 2 messages Jul 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 syscalls: Replace getppid02 with getpid02 implementation

Remove the existing getppid02.c as its coverage is overlapped by getpid02.c. Then, replace it by renaming and adapting the broader checks from getpid02.c to serve as the new getppid02.c.

---
 runtest/syscalls                              |  1 -
 testcases/kernel/syscalls/getpid/.gitignore   |  1 -
 testcases/kernel/syscalls/getpid/getpid02.c   | 67 -------------------
 testcases/kernel/syscalls/getppid/getppid02.c | 49 +++++++++++---
 4 files changed, 40 insertions(+), 78 deletions(-)
 delete mode 100644 testcases/kernel/syscalls/getpid/getpid02.c
runtest/syscalls +0 -1
index a38743ded..62a33e3a6 100644
@@ -517,7 +517,6 @@ getpgid02 getpgid02
 getpgrp01 getpgrp01
 
 getpid01 getpid01
-getpid02 getpid02
 
 getppid01 getppid01
 getppid02 getppid02
testcases/kernel/syscalls/getpid/.gitignore +0 -1
index f44bc9eac..8e7ab0185 100644
@@ -1,2 +1 @@
 /getpid01
-/getpid02
testcases/kernel/syscalls/getpid/getpid02.c deleted +0 -67

67 lines not on this page · raw message

testcases/kernel/syscalls/getppid/getppid02.c +40 -9

72 lines not on this page · raw message

--
2.43.0

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi Jinseok,

Quoted 5 lines · Jinseok Kim

syscalls: Replace getppid02 with getpid02 implementation

Remove the existing getppid02.c as its coverage is overlapped by getpid02.c. Then, replace it by renaming and adapting the broader checks from getpid02.c to serve as the new getppid02.c.

The commit message says "Remove the existing getppid02.c" but the file that is actually deleted is getpid02.c. getppid02.c is replaced, not removed. The sentence reads as if getppid02.c disappears, which is the opposite of what happens.

Quoted 1 line

+static void verify_getpid(void)

This function is in getppid02.c but the name still says verify_getpid. The function tests both fork/getpid consistency and getppid correctness, but it was copied from getpid02.c without renaming. Could it be renamed to verify_getppid to match the file it now lives in?

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp