Skip to contentSkip to conversation

misc: amd-sbi: Add null check for devm_kasprintf()

PATCH New Griffin Kroah-Hartman 1 participant 1 message Jul 9 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 misc: amd-sbi: Add null check for devm_kasprintf()

Add two checks for devm_kasprintf() errors in create_misc_rmi_device(), returning -ENOMEM if the function failed.

Assisted-by gkh_clanker_t1000
CC Arnd Bergmann <[email protected]>
CC Greg Kroah-Hartman <[email protected]>
CC Naveen Krishna Chatradhi <[email protected]>
CC Akshay Gupta <[email protected]>
---
 drivers/misc/amd-sbi/rmi-core.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/misc/amd-sbi/rmi-core.c +4 -0
index d4238ebad3c6..95c9109101b5 100644
@@ -581,6 +581,8 @@ int create_misc_rmi_device(struct sbrmi_data *data,
 							 GFP_KERNEL,
 							 "sbrmi-%x",
 							 data->dev_static_addr);
+	if (!data->sbrmi_misc_dev.name)
+		return -ENOMEM;
 	data->sbrmi_misc_dev.minor	= MISC_DYNAMIC_MINOR;
 	data->sbrmi_misc_dev.fops	= &sbrmi_fops;
 	data->sbrmi_misc_dev.parent	= dev;
@@ -588,6 +590,8 @@ int create_misc_rmi_device(struct sbrmi_data *data,
 							 GFP_KERNEL,
 							 "sbrmi-%x",
 							 data->dev_static_addr);
+	if (!data->sbrmi_misc_dev.nodename)
+		return -ENOMEM;
 	data->sbrmi_misc_dev.mode	= 0600;
 
 	return misc_register(&data->sbrmi_misc_dev);
Signature · 1 line
2.55.0