Skip to contentSkip to conversation

ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx

PATCH Superseded Sven Jans 3 participants 5 messages Jul 9 – Jul 23

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Sven Jans

author
#0 lore raw

PATCH v2 1/1 ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx

The laptop has a malformed _DSD which causes the cirrus,dev-index property to fail to parse, so it needs to be supported using the configuration table.

---
Resubmission, discussion of the previous submission stalled. The values are equal to the values reported in the _DSD. You can find my ACPI dump to verify here:
https://bugzilla.kernel.org/attachment.cgi?id=310050
Link to v1:
https://lore.kernel.org/linux-sound/[email protected]/

 sound/hda/codecs/side-codecs/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +2 -0
index 416d7bf3e289..e14a87336478 100644
@@ -85,6 +85,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
 	{ "103C8CDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
 	{ "103C8CDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 3900, 24 },
+	{ "103C8E60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -511,6 +512,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "103C8C6A", hp_i2c_int_2amp_dual_spkid },
 	{ "CSC3551", "103C8CDD", generic_dsd_config },
 	{ "CSC3551", "103C8CDE", generic_dsd_config },
+	{ "CSC3551", "103C8E60", generic_dsd_config },
 	{ "CSC3551", "104312AF", generic_dsd_config },
 	{ "CSC3551", "10431433", generic_dsd_config },
 	{ "CSC3551", "10431463", generic_dsd_config },
Signature · 1 line
2.55.0
#1 lore raw
Quoted 5 lines · Sven Jans

The laptop has a malformed _DSD which causes the cirrus,dev-index property to fail to parse, so it needs to be supported using the configuration table.

Quoted 8 lines

---
Resubmission, discussion of the previous submission stalled. The values are equal to the values reported in the _DSD. You can find my ACPI dump to verify here:
https://bugzilla.kernel.org/attachment.cgi?id=310050
Link to v1:
https://lore.kernel.org/linux-sound/[email protected]/

Stefan, is this also one of models with odd firmware?

thanks,

Takashi

Quoted 27 lines
 sound/hda/codecs/side-codecs/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +2 -0
index 416d7bf3e289..e14a87336478 100644
@@ -85,6 +85,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
 	{ "103C8CDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
 	{ "103C8CDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 3900, 24 },
+	{ "103C8E60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -511,6 +512,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "103C8C6A", hp_i2c_int_2amp_dual_spkid },
 	{ "CSC3551", "103C8CDD", generic_dsd_config },
 	{ "CSC3551", "103C8CDE", generic_dsd_config },
+	{ "CSC3551", "103C8E60", generic_dsd_config },
 	{ "CSC3551", "104312AF", generic_dsd_config },
 	{ "CSC3551", "10431433", generic_dsd_config },
 	{ "CSC3551", "10431463", generic_dsd_config },
Signature · 1 line
2.55.0
author
#2 lore raw

For what it's worth Stefan has confirmed that there is an issue with this laptop here: https://bugzilla.kernel.org/show_bug.cgi?id=221185#c11
The mentioned bug report 221479 is mine (https://bugzilla.kernel.org/show_bug.cgi?id=221479).

Quoted 50 lines · Takashi Iwai
Quoted 5 lines · Sven Jans

The laptop has a malformed _DSD which causes the cirrus,dev-index property to fail to parse, so it needs to be supported using the configuration table.

Quoted 8 lines

---
Resubmission, discussion of the previous submission stalled. The values are equal to the values reported in the _DSD. You can find my ACPI dump to verify here:
https://bugzilla.kernel.org/attachment.cgi?id=310050
Link to v1:
https://lore.kernel.org/linux-sound/[email protected]/

Stefan, is this also one of models with odd firmware?

thanks,

Takashi

Quoted 27 lines
  sound/hda/codecs/side-codecs/cs35l41_hda_property.c | 2 ++
  1 file changed, 2 insertions(+)
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +2 -0
index 416d7bf3e289..e14a87336478 100644
@@ -85,6 +85,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
  	{ "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
  	{ "103C8CDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
  	{ "103C8CDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 3900, 24 },
+	{ "103C8E60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
  	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
  	{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
  	{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -511,6 +512,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
  	{ "CSC3551", "103C8C6A", hp_i2c_int_2amp_dual_spkid },
  	{ "CSC3551", "103C8CDD", generic_dsd_config },
  	{ "CSC3551", "103C8CDE", generic_dsd_config },
+	{ "CSC3551", "103C8E60", generic_dsd_config },
  	{ "CSC3551", "104312AF", generic_dsd_config },
  	{ "CSC3551", "10431433", generic_dsd_config },
  	{ "CSC3551", "10431463", generic_dsd_config },
Signature · 1 line
2.55.0
#3 lore raw
In reply to Takashi Iwai

Hi Takashi,

Yes, this is one of the laptops with malformed ACPI.

Thanks,
Stefan

Quoted 76 lines

-----Original Message-----
From: Takashi Iwai <[email protected]>
Sent: Wednesday, July 15, 2026 3:35 PM
To: Stefan Binding <[email protected]>
Cc: Sven Jans <[email protected]>; David Rhodes <[email protected]>; Richard Fitzgerald <[email protected]>; Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>; linux- [email protected]; [email protected]; linux- [email protected]
Subject: Re: [PATCH v2] ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx

Quoted 5 lines · Sven Jans

The laptop has a malformed _DSD which causes the cirrus,dev-index property to fail to parse, so it needs to be supported using the configuration table.

Quoted 8 lines

---
Resubmission, discussion of the previous submission stalled. The values are equal to the values reported in the _DSD. You can find my ACPI dump to verify here:
https://bugzilla.kernel.org/attachment.cgi?id=310050
Link to v1:
https://lore.kernel.org/linux-sound/20260506181807.22547-1-

skbotnl@dis

Quoted 1 line

root.org/

Stefan, is this also one of models with odd firmware?

thanks,

Takashi

sound/hda/codecs/side-codecs/cs35l41_hda_property.c static const struct cs35l41_config

Quoted 10 lines
 sound/hda/codecs/side-codecs/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +0 -0
index 416d7bf3e289..e14a87336478 100644
@@ -85,6 +85,7 @@ static const struct cs35l41_config

cs35l41_config_table[] = {

sound/hda/codecs/side-codecs/cs35l41_hda_property.c static const struct cs35l41_config · line 85

Quoted 1 line
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +0 -0
 	{ "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },

0, 1, -1, 1000, 4100, 24 },

sound/hda/codecs/side-codecs/cs35l41_hda_property.c static const struct cs35l41_config · line 86

Quoted 1 line
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +0 -0
 	{ "103C8CDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },

0, 1, -1, 1000, 4100, 24 },

sound/hda/codecs/side-codecs/cs35l41_hda_property.c static const struct cs35l41_config · line 87

Quoted 1 line
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +0 -0
 	{ "103C8CDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },

0,

sound/hda/codecs/side-codecs/cs35l41_hda_property.c static const struct cs35l41_config · line 89

Quoted 2 lines
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +1 -0
 1, -1, 1000, 3900, 24 },
+	{ "103C8E60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },

0,

sound/hda/codecs/side-codecs/cs35l41_hda_property.c static const struct cs35l41_config · line 91

Quoted 2 lines
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +1 -0
+1, -1, 1000, 4500, 24 },
 	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },

1, 2, 0, 1000, 4500, 24 },

Quoted 1 line

{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },

0, 1, -1, 1000, 4500, 24 },

Quoted 1 line

{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 },

0,

Quoted 1 line

1, -1, 1000, 4500, 24 }, @@ -511,6 +512,7 @@ static const struct

cs35l41_prop_model cs35l41_prop_model_table[] = {

Quoted 10 lines
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +1 -1
 	{ "CSC3551", "103C8C6A", hp_i2c_int_2amp_dual_spkid },
 	{ "CSC3551", "103C8CDD", generic_dsd_config },
 	{ "CSC3551", "103C8CDE", generic_dsd_config },
+	{ "CSC3551", "103C8E60", generic_dsd_config },
 	{ "CSC3551", "104312AF", generic_dsd_config },
 	{ "CSC3551", "10431433", generic_dsd_config },
 	{ "CSC3551", "10431463", generic_dsd_config },
--

2.55.0