Skip to contentSkip to conversation

staging: media: atomisp: fix indentation and remove dead return

PATCH In review erqeons 2 participants 2 messages Jul 11

Subsystems (4)
Media (V4L/DVB) Staging Intel MID (Mobile Internet Device) platform Staging - atomisp driver
lore
Share & tools
lore

erqeons

author
#0 lore raw

PATCH 1/1 staging: media: atomisp: fix indentation and remove dead return

Fix style issues reported by checkpatch.pl:
- Remove unnecessary return statement in void function.
- Convert spaces to tabs for function arguments indentation.

Signed-off-by erqeons <[email protected]>
---
 drivers/staging/media/atomisp/pci/atomisp_cmd.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)
drivers/staging/media/atomisp/pci/atomisp_cmd.c +7 -8
index 6cd500d9f..fb1ae146b 100644
@@ -1419,7 +1419,6 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
 
 err:
 	atomisp_css_free_stat_buffers(asd);
-	return;
 }
 
 static void atomisp_curr_user_grid_info(struct atomisp_sub_device *asd,

@@ -1885,8 +1884,8 @@ int atomisp_calculate_real_zoom_region(struct atomisp_sub_device *asd,
  * Function to check the zoom region whether is effective
  */
 static bool atomisp_check_zoom_region(
-    struct atomisp_sub_device *asd,
-    struct ia_css_dz_config *dz_config)
+	struct atomisp_sub_device *asd,
+	struct ia_css_dz_config *dz_config)
 {
 	struct atomisp_resolution  config;
 	bool flag = false;

@@ -1920,8 +1919,8 @@ static bool atomisp_check_zoom_region(
 }
 
 void atomisp_apply_css_parameters(
-    struct atomisp_sub_device *asd,
-    struct atomisp_css_params *css_param)
+	struct atomisp_sub_device *asd,
+	struct atomisp_css_params *css_param)
 {
 	if (css_param->update_flag.wb_config)
 		asd->params.config.wb_config = &css_param->wb_config;

@@ -3895,9 +3894,9 @@ enum mipi_port_id atomisp_port_to_mipi_port(struct atomisp_device *isp,
 }
 
 static inline int atomisp_set_sensor_mipi_to_isp(
-    struct atomisp_sub_device *asd,
-    enum atomisp_input_stream_id stream_id,
-    struct camera_mipi_info *mipi_info)
+	struct atomisp_sub_device *asd,
+	enum atomisp_input_stream_id stream_id,
+	struct camera_mipi_info *mipi_info)
 {
 	struct v4l2_control ctrl;
 	struct atomisp_device *isp = asd->isp;
Signature · 1 line
2.53.0
#1 lore raw
Quoted 3 lines · erqeons

Fix style issues reported by checkpatch.pl:
- Remove unnecessary return statement in void function.
- Convert spaces to tabs for function arguments indentation.

Split this into two patches.

Quoted 2 lines
Signed-off-by erqeons <[email protected]>

Real name, please.

Quoted 17 lines
---
 drivers/staging/media/atomisp/pci/atomisp_cmd.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)
drivers/staging/media/atomisp/pci/atomisp_cmd.c +0 -1
index 6cd500d9f..fb1ae146b 100644
@@ -1419,7 +1419,6 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
 
 err:
 	atomisp_css_free_stat_buffers(asd);
-	return;
 }
 
 static void atomisp_curr_user_grid_info(struct atomisp_sub_device *asd,

drivers/staging/media/atomisp/pci/atomisp_cmd.c int atomisp_calculate_real_zoom_region(struct atomisp_sub_device *asd, · line 1888

Quoted 7 lines
drivers/staging/media/atomisp/pci/atomisp_cmd.c +2 -2
@@ -1885,8 +1884,8 @@ int atomisp_calculate_real_zoom_region(struct atomisp_sub_device *asd,
  * Function to check the zoom region whether is effective
  */
 static bool atomisp_check_zoom_region(
-    struct atomisp_sub_device *asd,
-    struct ia_css_dz_config *dz_config)
+	struct atomisp_sub_device *asd,
+	struct ia_css_dz_config *dz_config)

Normally we would align it like this:

static bool atomisp_check_zoom_region(struct atomisp_sub_device *asd,
struct ia_css_dz_config *dz_config)
{

regards,
dan carpenter