Skip to contentSkip to conversation

staging: media: atomisp: Style and clean up fixes

PATCH Superseded A. Kalimov 2 participants 4 messages Jul 11

Subsystems (4)
Media (V4L/DVB) Staging Intel MID (Mobile Internet Device) platform Staging - atomisp driver

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

A. Kalimov

author
#0 lore raw

v2 cover staging: media: atomisp: Style and clean up fixes

This patch series splits the original submission into two separate patches and updates the function arguments indentation to match the open parenthesis, as suggested by Dan Carpenter. Also updated the Signed-off-by line with a real name.

A. Kalimov (2):
staging: media: atomisp: remove unnecessary return statement
staging: media: atomisp: fix function arguments indentation

 .../staging/media/atomisp/pci/atomisp_cmd.c    | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)
Signature · 1 line
2.53.0
author
#1 lore raw

PATCH v2 1/2 staging: media: atomisp: remove unnecessary return statement

Signed-off-by A. Kalimov <[email protected]>
---
 drivers/staging/media/atomisp/pci/atomisp_cmd.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/media/atomisp/pci/atomisp_cmd.c +0 -1
index 6cd500d9f..81d0afae8 100644
@@ -1419,7 +1419,6 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
 
 err:
 	atomisp_css_free_stat_buffers(asd);
-	return;
 }
 
 static void atomisp_curr_user_grid_info(struct atomisp_sub_device *asd,
Signature · 1 line
2.53.0
#2 lore raw

Re: [PATCH v2 1/2] staging: media: atomisp: remove unnecessary return statement

Quoted 2 lines · A. Kalimov
Signed-off-by A. Kalimov <[email protected]>

---

No commit message.

Please wait 24 hours between resends.

staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter

author
#3 lore raw

PATCH v2 2/2 staging: media: atomisp: fix function arguments indentation

In reply to A. Kalimov
Signed-off-by A. Kalimov <[email protected]>
---
 drivers/staging/media/atomisp/pci/atomisp_cmd.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)
drivers/staging/media/atomisp/pci/atomisp_cmd.c +7 -10
index 81d0afae8..d741f4f04 100644
@@ -1883,9 +1883,8 @@ int atomisp_calculate_real_zoom_region(struct atomisp_sub_device *asd,
 /*
  * Function to check the zoom region whether is effective
  */
-static bool atomisp_check_zoom_region(
-    struct atomisp_sub_device *asd,
-    struct ia_css_dz_config *dz_config)
+static bool atomisp_check_zoom_region(struct atomisp_sub_device *asd,
+				      struct ia_css_dz_config *dz_config)
 {
 	struct atomisp_resolution  config;
 	bool flag = false;

@@ -1918,9 +1917,8 @@ static bool atomisp_check_zoom_region(
 	return flag;
 }
 
-void atomisp_apply_css_parameters(
-    struct atomisp_sub_device *asd,
-    struct atomisp_css_params *css_param)
+void atomisp_apply_css_parameters(struct atomisp_sub_device *asd,
+				  struct atomisp_css_params *css_param)
 {
 	if (css_param->update_flag.wb_config)
 		asd->params.config.wb_config = &css_param->wb_config;

@@ -3893,10 +3891,9 @@ enum mipi_port_id atomisp_port_to_mipi_port(struct atomisp_device *isp,
 	}
 }
 
-static inline int atomisp_set_sensor_mipi_to_isp(
-    struct atomisp_sub_device *asd,
-    enum atomisp_input_stream_id stream_id,
-    struct camera_mipi_info *mipi_info)
+static inline int atomisp_set_sensor_mipi_to_isp(struct atomisp_sub_device *asd,
+						 enum atomisp_input_stream_id stream_id,
+						 struct camera_mipi_info *mipi_info)
 {
 	struct v4l2_control ctrl;
 	struct atomisp_device *isp = asd->isp;
Signature · 1 line
2.53.0