drm/amd/pm/ci: Don't disable MCLK DPM on Bonaire 0x6658 (R7 260X)
Subsystems (3)
PATCH 1/1 drm/amd/pm/ci: Don't disable MCLK DPM on Bonaire 0x6658 (R7 260X)
The old radeon driver has a documented workaround in ci_dpm.c which claims that Bonaire 0x6658 with old memory controller firmware is unstable with MCLK DPM, so as a precaution I disabled MCLK DPM on this ASIC in amdgpu.
Note that the old MC firmware is not actually used with amdgpu, but in theory it's possible that the VBIOS sets up the ASIC with an old MC firmware that is already running when amdgpu initializes (in which case amdgpu doesn't load its own firmware).
What I expected to happen is that the GPU would simply use its maximum memory clock, and indeed this is what seemed to happen according to amdgpu_pm_info which reads the current MCLK value from the SMU.
However, some users reported a huge perf regression and upon a closer look it seems that the GPU seems to not actually use the highest MCLK value, despite the SMU reporting that it does.
Let's not disable MCLK DPM on Bonaire 0x6658 (R7 260X).
Keep MCLK DPM disabled on R9 M380 in the 2015 iMac because that still hangs if we enable it.
--- drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c +2 -5
@@ -106,11 +106,8 @@ int hwmgr_early_init(struct pp_hwmgr *hwmgr) hwmgr->od_enabled = false;switch (hwmgr->chip_id) {case CHIP_BONAIRE : -/* R9 M380 in iMac 2015: SMU hangs when enabling MCLK DPM -* R7 260X cards with old MC ucode: MCLK DPM is unstable -*/ -if (adev->pdev->subsystem_vendor ==0x106B || - adev->pdev->device ==0x6658 ) { +/* R9 M380 in iMac 2015: SMU hangs when enabling MCLK DPM */ +if (adev->pdev->subsystem_vendor ==0x106B ) {dev_info (adev->dev,"disabling MCLK DPM on quirky ASIC" ); adev->pm.pp_feature &= ~PP_MCLK_DPM_MASK ; hwmgr->feature_mask &= ~PP_MCLK_DPM_MASK ;
Signature · 1 line
2.55.0
Quoted 11 lines · Timur Kristóf
The old radeon driver has a documented workaround in
ci_dpm.cwhich claims that Bonaire0x6658with old memory controller firmware is unstable with MCLK DPM, so as a precaution I disabled MCLK DPM on this ASIC in amdgpu.Note that the old MC firmware is not actually used with amdgpu, but in theory it's possible that the VBIOS sets up the ASIC with an old MC firmware that is already running when amdgpu initializes (in which case amdgpu doesn't load its own firmware).
Quoted 5 lines
What I expected to happen is that the GPU would simply use its maximum memory clock, and indeed this is what seemed to happen according to
amdgpu_pm_infowhich reads the current MCLK value from the SMU.
However, some users reported a huge perf regression
Were those private reports? If not, please consider linking them in the trailers using Link: or Closes: tags, as explained in the patch submission guidelines (and mandated by Linus, see the quotes and links in
https://www.kernel.org/doc/html/latest/process/handling-regressions.html#on-the-importance-of-pointing-to-bug-reports-using-link-closes-tags
for details).
Ciao, Thorsten
Quoted 33 lines
and upon a closer look it seems that the GPU seems to not actually use the highest MCLK value, despite the SMU reporting that it does.
Let's not disable MCLK DPM on Bonaire
0x6658(R7 260X).Keep MCLK DPM disabled on R9 M380 in the 2015 iMac because that still hangs if we enable it.
Fixes 9851f29cb06c ("drm/amd/pm/ci: Disable MCLK DPM on problematic CI ASICs")Signed-off-by Timur Kristóf <[email protected]>--- drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c +2
-5@@ -106,11 +106,8 @@ int hwmgr_early_init(struct pp_hwmgr *hwmgr) hwmgr->od_enabled = false;switch (hwmgr->chip_id) {case CHIP_BONAIRE : -/* R9 M380 in iMac 2015: SMU hangs when enabling MCLK DPM -* R7 260X cards with old MC ucode: MCLK DPM is unstable -*/ -if (adev->pdev->subsystem_vendor ==0x106B || - adev->pdev->device ==0x6658 ) { +/* R9 M380 in iMac 2015: SMU hangs when enabling MCLK DPM */ +if (adev->pdev->subsystem_vendor ==0x106B ) {dev_info (adev->dev,"disabling MCLK DPM on quirky ASIC" ); adev->pm.pp_feature &= ~PP_MCLK_DPM_MASK ; hwmgr->feature_mask &= ~PP_MCLK_DPM_MASK ;
Quoted 18 lines · Central European Summer Time Thorsten Leemhuis
Quoted 11 lines · Timur Kristóf
The old radeon driver has a documented workaround in
ci_dpm.cwhich claims that Bonaire0x6658with old memory controller firmware is unstable with MCLK DPM, so as a precaution I disabled MCLK DPM on this ASIC in amdgpu.Note that the old MC firmware is not actually used with amdgpu, but in theory it's possible that the VBIOS sets up the ASIC with an old MC firmware that is already running when amdgpu initializes (in which case amdgpu doesn't load its own firmware).
Quoted 5 lines
What I expected to happen is that the GPU would simply use its maximum memory clock, and indeed this is what seemed to happen according to
amdgpu_pm_infowhich reads the current MCLK value from the SMU.
However, some users reported a huge perf regression
Quoted 8 lines
Were those private reports? If not, please consider linking them in the
trailers using Link: or Closes: tags, as explained in the patch
submission guidelines (and mandated by Linus, see the quotes and links
in
https://www.kernel.org/doc/html/latest/process/handling-regressions.html#on-> the-importance-of-pointing-to-bug-reports-using-link-closes-tags for details).Ciao, Thorsten
Hi Thorsten,
There is no bug report. I had a conversation on Reddit which brought my attention to this issue, then I actually plugged in the GPU, tested it and noticed that there is indeed a problem, and this patch here is the best fix I could find.
Best regards,
Timur
Quoted 24 lines
Quoted 24 lines
and upon a closer look it seems that the GPU seems to not actually use the highest MCLK value, despite the SMU reporting that it does.
Let's not disable MCLK DPM on Bonaire
0x6658(R7 260X).Keep MCLK DPM disabled on R9 M380 in the 2015 iMac because that still hangs if we enable it.
Fixes 9851f29cb06c ("drm/amd/pm/ci: Disable MCLK DPM on problematic CIASICs") Signed-off-by: Timur Kristóf <[email protected]>
---drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)(quoted diff) +0
-0
b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.cindex1d6e30269d56..4d553be56396100644drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c +0
-0@@ -106,11 +106,8 @@ int hwmgr_early_init(struct pp_hwmgr *hwmgr)
Quoted 5 lines
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c int hwmgr_early_init(struct pp_hwmgr *hwmgr)
Quoted 5 lines
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c +0
-1hwmgr->od_enabled = false;switch (hwmgr->chip_id) {case CHIP_BONAIRE : -/* R9 M380 in iMac 2015: SMU hangs when
enabling MCLK DPM
Quoted 1 line
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c int hwmgr_early_init(struct pp_hwmgr *hwmgr) · line 112
Quoted 1 line
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c +0
-1-* R7 260X cards with old MC ucode: MCLK DPM
is unstable
Quoted 2 lines
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c int hwmgr_early_init(struct pp_hwmgr *hwmgr) · line 114
Quoted 2 lines
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c +0
-2-*/ - if (adev->pdev->subsystem_vendor == 0x106B
||
> > - adev->pdev->device == 0x6658) {Quoted 1 line
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c int hwmgr_early_init(struct pp_hwmgr *hwmgr) · line 111
Quoted 1 line
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c +1
-0+/* R9 M380 in iMac 2015: SMU hangs when
enabling MCLK DPM */
Quoted 1 line
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c int hwmgr_early_init(struct pp_hwmgr *hwmgr) · line 112
Quoted 1 line
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c +1
-0+if (adev->pdev->subsystem_vendor ==0x106B )
{
Quoted 2 lines
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c int hwmgr_early_init(struct pp_hwmgr *hwmgr) · line 113
Quoted 2 lines
drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c +0
-0dev_info(adev->dev, "disabling
MCLK DPM on quirky ASIC");
Quoted 1 line
Quoted 1 line
adev->pm.pp_feature&=
~PP_MCLK_DPM_MASK;
Quoted 1 line
Quoted 1 line
hwmgr->feature_mask&=
~PP_MCLK_DPM_MASK;
Quoted 10 lines · Timur Kristóf
Quoted 8 lines · Central European Summer Time Thorsten Leemhuis
Quoted 5 lines · Timur Kristóf
What I expected to happen is that the GPU would simply use its maximum memory clock, and indeed this is what seemed to happen according to
amdgpu_pm_infowhich reads the current MCLK value from the SMU.
However, some users reported a huge perf regression
Quoted 6 lines
Quoted 6 lines
Were those private reports? If not, please consider linking them in the
trailers using Link: or Closes: tags, as explained in the patch
submission guidelines (and mandated by Linus, see the quotes and links
in
https://www.kernel.org/doc/html/latest/process/handling-regressions.html#on-> the-importance-of-pointing-to-bug-reports-using-link-closes-tags for details).
Thx for the reply!
Quoted 3 lines
There is no bug report. I had a conversation on Reddit which brought my attention to this issue, then I actually plugged in the GPU, tested it and noticed that there is indeed a problem,
FWIW, we occasionally link to reddit threads as well, but sounds like this would not make sense here.
Quoted 1 line
and this patch here is the best fix I could find.
Great, thx.
BTW (feel free to ignore this if you have no idea): I first had wondered if there is a bug report about this in
https://gitlab.freedesktop.org/drm/amd/-/work_items and wanted to search if the culprit was mentioned anywhere. Do you by chance know if that is somehow possible?
To provide an example of what I want:
https://gitlab.freedesktop.org/drm/i915/kernel/-/work_items/16043#note_3563809
mentions commit-id 2914709c (Revert "drm/i915/backlight: Remove try_vesa_interface"") -- but I didn't find a way to find tickets then refer to that commit, for example with a search like this:
https://gitlab.freedesktop.org/search?search=2914709c&nav_source=navbar&search_code=true
Is there some trick to do this?
Ciao, Thorsten
Quoted 19 lines · Central European Summer Time Thorsten Leemhuis
Quoted 17 lines · Timur Kristóf
On Monday, July 13, 2026 10:28:08 AM Central European Summer Time Thorsten
Quoted 14 lines · Leemhuis
Quoted 5 lines · Timur Kristóf
What I expected to happen is that the GPU would simply use its maximum memory clock, and indeed this is what seemed to happen according to
amdgpu_pm_infowhich reads the current MCLK value from the SMU.
However, some users reported a huge perf regressionWere those private reports? If not, please consider linking them in the trailers using Link: or Closes: tags, as explained in the patch submission guidelines (and mandated by Linus, see the quotes and links in
https://www.kernel.org/doc/html/latest/process/handling-regressions.html#
on-> the-importance-of-pointing-to-bug-reports-using-link-closes-tags for details).
Quoted 8 lines
Thx for the reply!
Quoted 3 lines
There is no bug report. I had a conversation on Reddit which brought my attention to this issue, then I actually plugged in the GPU, tested it and noticed that there is indeed a problem,
FWIW, we occasionally link to reddit threads as well, but sounds like this would not make sense here.
There are no details about this on Reddit. I just heard that somebody experienced a slowdown with this specific GPU starting from the time when my previous patch was backported and I realized the PCI ID matches what I added in my previous patch. So I got suspicious that maybe it doesn't work as I had thought. Then I just tested it for myself and found what I explained in the commit message here.
I apologize for the trouble.
Quoted 6 lines
BTW (feel free to ignore this if you have no idea): I first had wondered if there is a bug report about this in
https://gitlab.freedesktop.org/drm/amd/-/work_items and wanted to search if the culprit was mentioned anywhere. Do you by chance know if that is somehow possible?
GitLab can show when a commit was mentioned, if it's a commit hash that the specific GitHub instance knows about. However I'm not sure how reliable that is, because the same commit may have a different hash depending on which tree you are working with. It may not know that the different hashes are really the same commit.
Quoted 11 lines
To provide an example of what I want:
https://gitlab.freedesktop.org/drm/i915/kernel/-/work_items/16043#note_35638
09 mentions commit-id2914709c(Revert "drm/i915/backlight: Removetry_vesa_interface"") -- but I didn't find a way to find tickets then refer to that commit, for example with a search like this:
https://gitlab.freedesktop.org/search?search=2914709c&nav_source=navbar&sear
ch_code=trueIs there some trick to do this?
For that example, if you open the commit link:
https://gitlab.freedesktop.org/drm/i915/kernel/-/commit/2914709c914101eb704e01bed2351070d4161ccf
You can scroll down and see that the commit was mentioned, and you can then click on the issues where it was mentioned.
Hope this helps,
Timur
Quoted 11 lines · Timur Kristóf
Quoted 11 lines
To provide an example of what I want:
https://gitlab.freedesktop.org/drm/i915/kernel/-/
work_items/16043#note_35638
09 mentions commit-id2914709c(Revert "drm/i915/backlight: Removetry_vesa_interface"") -- but I didn't find a way to find tickets then refer to that commit, for example with a search like this:
https://gitlab.freedesktop.org/search?
search=2914709c&nav_source=navbar&sear
ch_code=true
Quoted 7 lines
Quoted 1 line
Is there some trick to do this?
For that example, if you open the commit link:
https://gitlab.freedesktop.org/drm/i915/kernel/-/commit/2914709c914101eb704e01bed2351070d4161ccfYou can scroll down and see that the commit was mentioned, and you can then click on the issues where it was mentioned.
Ahh, great, thx, you helped me quite a lot. Fun fact: I had briefly looked at pages like that for a reference already, but seem I didn't scroll down far enough. :-/
Ciao, Thorsten
Alex Deucher
AppliedApplied. Thanks!
Quoted 53 lines · Timur Kristóf
The old radeon driver has a documented workaround in
ci_dpm.cwhich claims that Bonaire0x6658with old memory controller firmware is unstable with MCLK DPM, so as a precaution I disabled MCLK DPM on this ASIC in amdgpu.Note that the old MC firmware is not actually used with amdgpu, but in theory it's possible that the VBIOS sets up the ASIC with an old MC firmware that is already running when amdgpu initializes (in which case amdgpu doesn't load its own firmware).
What I expected to happen is that the GPU would simply use its maximum memory clock, and indeed this is what seemed to happen according to
amdgpu_pm_infowhich reads the current MCLK value from the SMU.
However, some users reported a huge perf regression and upon a closer look it seems that the GPU seems to not actually use the highest MCLK value, despite the SMU reporting that it does.Let's not disable MCLK DPM on Bonaire
0x6658(R7 260X).Keep MCLK DPM disabled on R9 M380 in the 2015 iMac because that still hangs if we enable it.
Fixes 9851f29cb06c ("drm/amd/pm/ci: Disable MCLK DPM on problematic CI ASICs")Signed-off-by Timur Kristóf <[email protected]>--- drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c +2
-6@@ -106,11 +106,8 @@ int hwmgr_early_init(struct pp_hwmgr *hwmgr) hwmgr->od_enabled = false;switch (hwmgr->chip_id) {case CHIP_BONAIRE : -/* R9 M380 in iMac 2015: SMU hangs when enabling MCLK DPM -* R7 260X cards with old MC ucode: MCLK DPM is unstable -*/ -if (adev->pdev->subsystem_vendor ==0x106B || - adev->pdev->device ==0x6658 ) { +/* R9 M380 in iMac 2015: SMU hangs when enabling MCLK DPM */ +if (adev->pdev->subsystem_vendor ==0x106B ) {dev_info (adev->dev,"disabling MCLK DPM on quirky ASIC" ); adev->pm.pp_feature &= ~PP_MCLK_DPM_MASK ; hwmgr->feature_mask &= ~PP_MCLK_DPM_MASK ; --2.55.0