net: txgbe: fix heap overflow when reading module EEPROM
Subsystems (3)
PATCH 1/1 net: txgbe: fix heap overflow when reading module EEPROM
From: Chenguang Zhao <[email protected]>
txgbe_read_eeprom_hostif() always copies round_up(length, 4) bytes into the caller buffer, which ethtool allocates with exactly 'length' bytes. A non-4-aligned length therefore causes an out-of-bounds write. Copy only the remaining bytes on the final dword instead.
--- drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c +4 -2
@@ -96,11 +96,13 @@ int txgbe_read_eeprom_hostif(struct wx *wx, dword_len =round_up (length,4 ) >>2 ;for (i =0 ; i < dword_len; i++) { +u32 copy_len =min_t (u32,4 , length - i *4 ); + value =rd32a (wx,WX_FW2SW_MBOX , i + offset);le32_to_cpus (&value); -memcpy (data, &value,4 ); - data +=4 ; +memcpy (data, &value, copy_len); + data += copy_len; }return 0 ;
Signature · 1 line
2.25.1
Quoted 33 lines
From: Chenguang Zhao <[email protected]>
txgbe_read_eeprom_hostif()always copiesround_up(length, 4)bytes into the caller buffer, which ethtool allocates with exactly 'length' bytes. A non-4-aligned length therefore causes an out-of-bounds write. Copy only the remaining bytes on the final dword instead.Signed-off-by Chenguang Zhao <[email protected]>--- drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c +4
-3@@ -96,11 +96,13 @@ int txgbe_read_eeprom_hostif(struct wx *wx, dword_len =round_up (length,4 ) >>2 ;for (i =0 ; i < dword_len; i++) { +u32 copy_len =min_t (u32,4 , length - i *4 ); + value =rd32a (wx,WX_FW2SW_MBOX , i + offset);le32_to_cpus (&value); -memcpy (data, &value,4 ); - data +=4 ; +memcpy (data, &value, copy_len); + data += copy_len; }return 0 ; --
Quoted 1 line
2.25.1
Thanks for the fix.
Quoted 9 lines · Chenguang Zhao
From: Chenguang Zhao <[email protected]>
txgbe_read_eeprom_hostif()always copiesround_up(length, 4)bytes into the caller buffer, which ethtool allocates with exactly 'length' bytes. A non-4-aligned length therefore causes an out-of-bounds write. Copy only the remaining bytes on the final dword instead.Signed-off-by Chenguang Zhao <[email protected]>---
Quoted 23 lines
drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c +4
-2@@ -96,11 +96,13 @@ int txgbe_read_eeprom_hostif(struct wx *wx, dword_len =round_up (length,4 ) >>2 ;for (i =0 ; i < dword_len; i++) { +u32 copy_len =min_t (u32,4 , length - i *4 ); + value =rd32a (wx,WX_FW2SW_MBOX , i + offset);le32_to_cpus (&value); -memcpy (data, &value,4 ); - data +=4 ; +memcpy (data, &value, copy_len); + data += copy_len; }return 0 ;
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Mon, 13 Jul 2026 16:51:11 +0800 you wrote:
From: Chenguang Zhao <[email protected]>
txgbe_read_eeprom_hostif()always copiesround_up(length, 4)bytes into the caller buffer, which ethtool allocates with exactly 'length' bytes. A non-4-aligned length therefore causes an out-of-bounds write. Copy only the remaining bytes on the final dword instead.[...]
Here is the summary with links:
- [net] net: txgbe: fix heap overflow when reading module EEPROM
https://git.kernel.org/netdev/net/c/6a905a71fd43
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html