syscall02: test invalid syscall number -1
PATCH v2 1/1 syscall02: test invalid syscall number -1
From: Andrea Cervesato <[email protected]>
Add a test verifying that a raw syscall() with the reserved number -1 fails with ENOSYS. The behavior is architecture specific, so the test is limited to the architectures where it was checked against kernel code.
---
Changes in v2:
- update imports and description
- Link to v1: https://lore.kernel.org/[email protected]
--- runtest/syscalls | 1 + testcases/kernel/syscalls/syscall/.gitignore | 1 + testcases/kernel/syscalls/syscall/syscall02.c | 31 +++++++++++++++++++++++++++ 3 files changed, 33 insertions(+)
runtest/syscalls +1 -0
@@ -1678,6 +1678,7 @@ sync_file_range01 sync_file_range01 sync_file_range02 sync_file_range02 syscall01 syscall01 +syscall02 syscall02 sysconf01 sysconf01
testcases/kernel/syscalls/syscall/.gitignore +1 -0
@@ -1 +1,2 @@ /syscall01 +/syscall02
testcases/kernel/syscalls/syscall/syscall02.c new file +31 -0
@@ -0,0 +1,31 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Copyright (c) 2026 SUSE LLC Andrea Cervesato <[email protected]> +*/ + +/*\ +* Verify that a raw :manpage:`syscall(2)` with the invalid system call +* number -1 fails with ENOSYS. +* +* The behavior of number -1 is architecture specific, so the test only runs on +* the architectures where it has been verified against the kernel entry code. +*/ + +#define _GNU_SOURCE +#include <unistd.h> + +#include "tst_test.h" + +static void run (void ) +{ +TST_EXP_FAIL2 (syscall (-1 ),ENOSYS ,"invalid syscall number -1" ); +} + +static struct tst_test test = { + .test_all = run, + .supported_archs = (const char *const []) { +"x86_64" , +"aarch64" , +NULL + }, +};
---
base-commit: 7ca5dc366a558f3666223e6abe579edd90bafd38
change-id: 20260714-syscall_invalid_nr-cf61f64f2741
Best regards,
Signature · 5 lines
Andrea Cervesato <[email protected]> -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Andrea,
Quoted 4 lines · Andrea Cervesato
syscall02: test invalid syscall number -1
Add a test verifying that a raw
syscall()with the reserved number -1 fails with ENOSYS.
The subject and the doc comment inside the test both say "invalid syscall number -1", but the commit body says "reserved number -1". These terms carry different meanings. "Reserved" implies deliberate kernel allocation for a specific purpose, while "invalid" is the user-facing description for an out-of-range syscall number. Could "reserved" be changed to "invalid" here to match the subject and the test description block?
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 46 lines
runtest/syscalls +1
-0@@ -1678,6 +1678,7 @@ sync_file_range01 sync_file_range01 sync_file_range02 sync_file_range02 syscall01 syscall01 +syscall02 syscall02 sysconf01 sysconf01testcases/kernel/syscalls/syscall/.gitignore +1
-0@@ -1 +1,2 @@ /syscall01 +/syscall02testcases/kernel/syscalls/syscall/syscall02.c new file +21
-0@@ -0,0 +1,31 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Copyright (c) 2026 SUSE LLC Andrea Cervesato <[email protected]> +*/ + +/*\ +* Verify that a raw :manpage:`syscall(2)` with the invalid system call +* number -1 fails with ENOSYS. +* +* The behavior of number -1 is architecture specific, so the test only runs on +* the architectures where it has been verified against the kernel entry code. +*/ + +#define _GNU_SOURCE +#include <unistd.h> + +#include "tst_test.h" + +static void run (void ) +{ +TST_EXP_FAIL2 (syscall (-1 ),ENOSYS ,"invalid syscall number -1" );
testcases/kernel/syscalls/syscall/syscall02.c line 31
Quoted 10 lines
testcases/kernel/syscalls/syscall/syscall02.c new file +10
-0+} + +static struct tst_test test = { + .test_all = run, + .supported_archs = (const char *const []) { +"x86_64" , +"aarch64" , +NULL + }, +};
I do not think that there is an architecture that has a valid syscall mapped to -1. I do not think that we need to restrict the architecture here.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp