riscv: hwprobe: Avoid uninitialized read in hwprobe_get_cpus()
PATCH v2 1/1 riscv: hwprobe: Avoid uninitialized read in hwprobe_get_cpus()
When cpusetsize < cpumask_size(), hwprobe_get_cpus() did not fully initialize its copy of the cpu mask, which could cause non-deterministic results from the riscv_hwprobe syscall on a system with more than 8 CPUs when the supplied cpu mask is empty. Address this by fully initializing the cpu mask.
Fixes e178bf146e4b ("RISC-V: hwprobe: Introduce which-cpus flag")
Signed-off-by Mark Harris <[email protected]>
Reviewed-by Nam Cao <[email protected]>
Reviewed-by Michael Ellerman <[email protected]>
---
v2: Add Fixes: and Reviewed-by: tags
arch/riscv/kernel/sys_hwprobe.c | 1 + 1 file changed, 1 insertion(+)
arch/riscv/kernel/sys_hwprobe.c +1 -0
@@ -450,6 +450,7 @@ static int hwprobe_get_cpus(struct riscv_hwprobe __user *pairs,if (cpusetsize >cpumask_size ()) cpusetsize =cpumask_size (); +cpumask_clear (&cpus); ret =copy_from_user (&cpus, cpus_user, cpusetsize);if (ret)return -EFAULT ;
Signature · 1 line
2.55.0
Paul Walmsley
maintainerQuoted 10 lines · Mark Harris
When cpusetsize <
cpumask_size(),hwprobe_get_cpus()did not fully initialize its copy of the cpu mask, which could cause non-deterministic results from theriscv_hwprobesyscall on a system with more than 8 CPUs when the supplied cpu mask is empty. Address this by fully initializing the cpu mask.Fixes e178bf146e4b ("RISC-V: hwprobe: Introduce which-cpus flag")Signed-off-by Mark Harris <[email protected]>Reviewed-by Nam Cao <[email protected]>Reviewed-by Michael Ellerman <[email protected]>
Thanks, queued for v7.2-rc.
- Paul