Skip to contentSkip to conversation

Kconfig: ram: select FDT_64BIT for K3_INLINE_ECC

PATCH In review Bin Liu 4 participants 4 messages Jul 16 – Jul 28

lore
Share & tools
lore

Bin Liu

author
#0 lore raw

PATCH 1/1 Kconfig: ram: select FDT_64BIT for K3_INLINE_ECC

Commit f43f71012254 ("ram: k3-ddrss: Add support for a partial inline ECC region") uses ofnode_get_addr_size() to read memory address and size from devicetree using type fdt_addr_t and fdt_size_t. However these data types are 32bit if CONFIG_FDT_64BIT is not defined on ARMv7 build.

So enable CONFIG_FDT_64BIT to retrieve correct 64bit memory address and size from devicetree.

---
 drivers/ram/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/ram/Kconfig +1 -0
index cfbfa1252d0e..acd6d9cfd6a9 100644
@@ -121,6 +121,7 @@ config IMXRT_SDRAM
 config K3_INLINE_ECC
 	bool "Enable TI Inline ECC support"
 	depends on K3_DDRSS
+	select FDT_64BIT
 	help
 	  Enable Inline ECC support on K3 platforms. 1/9th of the SDRAM space
 	  is used for ECC storage and the rest 8/9th is available for system
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Bin Liu

Commit f43f71012254 ("ram: k3-ddrss: Add support for a partial inline ECC region") uses ofnode_get_addr_size() to read memory address and size from devicetree using type fdt_addr_t and fdt_size_t. However these data types are 32bit if CONFIG_FDT_64BIT is not defined on ARMv7 build.

So enable CONFIG_FDT_64BIT to retrieve correct 64bit memory address and size from devicetree.

---
 drivers/ram/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/ram/Kconfig +0 -0
index cfbfa1252d0e..acd6d9cfd6a9 100644

drivers/ram/Kconfig config IMXRT_SDRAM · line 124

Quoted 4 lines
drivers/ram/Kconfig +1 -0
@@ -121,6 +121,7 @@ config IMXRT_SDRAM
 config K3_INLINE_ECC
 	bool "Enable TI Inline ECC support"
 	depends on K3_DDRSS
+	select FDT_64BIT

Good catch

Quoted 3 lines
drivers/ram/Kconfig +0 -0
 	help
 	  Enable Inline ECC support on K3 platforms. 1/9th of the SDRAM space
 	  is used for ECC storage and the rest 8/9th is available for system
#3 lore raw
In reply to Bin Liu
Quoted 10 lines · Bin Liu

Commit f43f71012254 ("ram: k3-ddrss: Add support for a partial inline ECC region") uses ofnode_get_addr_size() to read memory address and size from devicetree using type fdt_addr_t and fdt_size_t. However these data types are 32bit if CONFIG_FDT_64BIT is not defined on ARMv7 build.

So enable CONFIG_FDT_64BIT to retrieve correct 64bit memory address and size from devicetree.

[...]

Applied to u-boot/main, thanks!

[1/1] Kconfig: ram: select FDT_64BIT for K3_INLINE_ECC

      commit: 1ca41edced1a7213a9d737c1ced772b91181e9ad
Signature · 1 line
Tom