Skip to contentSkip to conversation

pinctrl: qcom: ipq9650: fix audio_sec_mclk_in1/out1 group pins

PATCH Applied Taceddin Sancak 5 participants 5 messages Jul 18 – Jul 27

Subsystems (5)
Arm Qualcomm mailing list GPIO Pin control Pin controller - Qualcomm +1 more subsystems
lore
Share & tools
lore

Taceddin Sancak

author
#0 lore raw

PATCH 1/1 pinctrl: qcom: ipq9650: fix audio_sec_mclk_in1/out1 group pins

The audio_sec_mclk_in1 and audio_sec_mclk_out1 groups both list "gpio37", but in the pingroup table those functions are muxed on gpio39, while gpio37 provides the audio_sec_mclk_in0/out0 variants. This makes both functions unusable: selecting them on gpio39 is rejected by the pinmux core because the group is not listed for the function, and selecting them on gpio37 trips the WARN_ON() in msm_pinmux_set_mux() and fails with -EINVAL because that group cannot mux them.

Point both groups at gpio39, matching the pingroup table. This also mirrors the primary audio MCLK pair, where the mclk0 and mclk1 variants live on separate pins (gpio53 and gpio51 respectively).

Fixes 3c8e7ba0e399 ("pinctrl: qcom: Introduce IPQ9650 TLMM driver")
Assisted-by Claude:claude-fable-5
Signed-off-by Taceddin Sancak <[email protected]>
---
 drivers/pinctrl/qcom/pinctrl-ipq9650.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/qcom/pinctrl-ipq9650.c +2 -2
index 64e443aa31b2..5399d7ad934c 100644
@@ -310,11 +310,11 @@ static const char *const audio_sec_mclk_out0_groups[] = {
 };
 
 static const char *const audio_sec_mclk_in1_groups[] = {
-	"gpio37",
+	"gpio39",
 };
 
 static const char *const audio_sec_mclk_out1_groups[] = {
-	"gpio37",
+	"gpio39",
 };
 
 static const char *const audio_sec_groups[] = {
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Taceddin Sancak

The audio_sec_mclk_in1 and audio_sec_mclk_out1 groups both list "gpio37", but in the pingroup table those functions are muxed on gpio39, while gpio37 provides the audio_sec_mclk_in0/out0 variants. This makes both functions unusable: selecting them on gpio39 is rejected by the pinmux core because the group is not listed for the function, and selecting them on gpio37 trips the WARN_ON() in msm_pinmux_set_mux() and fails with -EINVAL because that group cannot mux them.

Quoted 8 lines

Point both groups at gpio39, matching the pingroup table. This also mirrors the primary audio MCLK pair, where the mclk0 and mclk1 variants live on separate pins (gpio53 and gpio51 respectively).

Fixes 3c8e7ba0e399 ("pinctrl: qcom: Introduce IPQ9650 TLMM driver")
Assisted-by Claude:claude-fable-5
Signed-off-by Taceddin Sancak <[email protected]>

---

Reviewed-by Konrad Dybcio <[email protected]>

Konrad

Reviewed-by on v1 1/1
#2 lore raw
In reply to Taceddin Sancak
Quoted 9 lines · Taceddin Sancak

The audio_sec_mclk_in1 and audio_sec_mclk_out1 groups both list "gpio37", but in the pingroup table those functions are muxed on gpio39, while gpio37 provides the audio_sec_mclk_in0/out0 variants. This makes both functions unusable: selecting them on gpio39 is rejected by the pinmux core because the group is not listed for the function, and selecting them on gpio37 trips the WARN_ON() in msm_pinmux_set_mux() and fails with -EINVAL because that group cannot mux them.

Quoted 8 lines

Point both groups at gpio39, matching the pingroup table. This also mirrors the primary audio MCLK pair, where the mclk0 and mclk1 variants live on separate pins (gpio53 and gpio51 respectively).

Fixes 3c8e7ba0e399 ("pinctrl: qcom: Introduce IPQ9650 TLMM driver")
Assisted-by Claude:claude-fable-5
Signed-off-by Taceddin Sancak <[email protected]>

---

Thanks for catching this!

Reviewed-by Kathiravan Thirumoorthy <[email protected]>
maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Taceddin Sancak
Quoted 9 lines · Taceddin Sancak

The audio_sec_mclk_in1 and audio_sec_mclk_out1 groups both list "gpio37", but in the pingroup table those functions are muxed on gpio39, while gpio37 provides the audio_sec_mclk_in0/out0 variants. This makes both functions unusable: selecting them on gpio39 is rejected by the pinmux core because the group is not listed for the function, and selecting them on gpio37 trips the WARN_ON() in msm_pinmux_set_mux() and fails with -EINVAL because that group cannot mux them.

Quoted 7 lines

Point both groups at gpio39, matching the pingroup table. This also mirrors the primary audio MCLK pair, where the mclk0 and mclk1 variants live on separate pins (gpio53 and gpio51 respectively).

Fixes 3c8e7ba0e399 ("pinctrl: qcom: Introduce IPQ9650 TLMM driver")
Assisted-by Claude:claude-fable-5
Signed-off-by Taceddin Sancak <[email protected]>

This patch -> Bartosz

Acked-by Linus Walleij <[email protected]>

Yours,
Linus Walleij

Applied
#4 lore raw
In reply to Taceddin Sancak
Quoted 10 lines · Taceddin Sancak

The audio_sec_mclk_in1 and audio_sec_mclk_out1 groups both list "gpio37", but in the pingroup table those functions are muxed on gpio39, while gpio37 provides the audio_sec_mclk_in0/out0 variants. This makes both functions unusable: selecting them on gpio39 is rejected by the pinmux core because the group is not listed for the function, and selecting them on gpio37 trips the WARN_ON() in msm_pinmux_set_mux() and fails with -EINVAL because that group cannot mux them.

[...]

Applied, thanks!

[1/1] pinctrl: qcom: ipq9650: fix audio_sec_mclk_in1/out1 group pins

      https://git.kernel.org/brgl/c/4a2e2c563b0ee2253a7902f775bf71232820186d

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>