staging: rtl8723bs: Remove whitespaces
cover staging: rtl8723bs: Remove whitespaces
This patch mainly removes whitespaces but also includes coding style fixes.
No functional changes are intended with this patchset.
Dalvin-Ehinoma Noah Aiguobas (3):
staging: rtl8723bs: remove unnecessary whitespace
staging: rtl8723bs: wrap line over 100 characters
staging: rtl8723bs: Renaming variables with type prefix
drivers/staging/rtl8723bs/core/rtw_mlme.c | 300 +++++++++--------- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- .../staging/rtl8723bs/include/wlan_bssdef.h | 56 ++-- 3 files changed, 181 insertions(+), 177 deletions(-)
Signature · 1 line
2.54.0
PATCH 1/3 staging: rtl8723bs: remove unnecessary whitespace
Remove unnecessary whitespace to improve readability and coding style consistency.
No functional changes are intended in this patch.
--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 154 +++++++++--------- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- .../staging/rtl8723bs/include/wlan_bssdef.h | 56 +++---- 3 files changed, 106 insertions(+), 106 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme.c +77 -77
@@ -39,13 +39,13 @@ static void rtw_init_mlme_timer(struct adapter *padapter) _rtw_set_scan_deny_timer_hdl, 0); } -int rtw_init_mlme_priv (struct adapter *padapter) +int rtw_init_mlme_priv (struct adapter *padapter) { -int i; +int i;u8 *pbuf; -struct wlan_network *pnetwork; -struct mlme_priv *pmlmepriv = &padapter->mlmepriv; -int res = _SUCCESS; +struct wlan_network *pnetwork; +struct mlme_priv *pmlmepriv = &padapter->mlmepriv; +int res = _SUCCESS; pmlmepriv->nic_hdl = (u8 *)padapter;
@@ -137,9 +137,9 @@ void _rtw_free_mlme_priv(struct mlme_priv *pmlmepriv) } } -struct wlan_network *rtw_alloc_network (struct mlme_priv *pmlmepriv) +struct wlan_network *rtw_alloc_network (struct mlme_priv *pmlmepriv) { -struct wlan_network *pnetwork; +struct wlan_network *pnetwork;struct __queue *free_queue = &pmlmepriv->free_bss_pool;struct list_head *plist =NULL ;
@@ -167,7 +167,7 @@ struct wlan_network *rtw_alloc_network(struct mlme_priv *pmlmepriv)return pnetwork; } -void _rtw_free_network (struct mlme_priv *pmlmepriv,struct wlan_network *pnetwork,u8 isfreeall) +void _rtw_free_network (struct mlme_priv *pmlmepriv,struct wlan_network *pnetwork,u8 isfreeall) {unsigned int delta_time;u32 lifetime =SCANQUEUE_LIFETIME ;
@@ -198,7 +198,7 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *pnetworspin_unlock_bh (&free_queue->lock); } -void _rtw_free_network_nolock (struct mlme_priv *pmlmepriv,struct wlan_network *pnetwork) +void _rtw_free_network_nolock (struct mlme_priv *pmlmepriv,struct wlan_network *pnetwork) {struct __queue *free_queue = &pmlmepriv->free_bss_pool;
@@ -220,8 +220,8 @@ void _rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_network **/ struct wlan_network *_rtw_find_network (struct __queue *scanned_queue,u8 *addr) { -struct list_head *phead, *plist; -struct wlan_network *pnetwork =NULL ; +struct list_head *phead, *plist; +struct wlan_network *pnetwork =NULL ;if (is_zero_ether_addr (addr)) { pnetwork =NULL ;
@@ -319,9 +319,9 @@ void rtw_free_network_nolock(struct adapter *padapter, struct wlan_network *pnet* * Shall be called under atomic context... to avoid possible racing condition... */ -struct wlan_network *rtw_find_network (struct __queue *scanned_queue,u8 *addr) +struct wlan_network *rtw_find_network (struct __queue *scanned_queue,u8 *addr) { -struct wlan_network *pnetwork =_rtw_find_network (scanned_queue, addr); +struct wlan_network *pnetwork =_rtw_find_network (scanned_queue, addr);return pnetwork; }
@@ -385,12 +385,12 @@ struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue, strucreturn found; } -struct wlan_network *rtw_get_oldest_wlan_network (struct __queue *scanned_queue) +struct wlan_network *rtw_get_oldest_wlan_network (struct __queue *scanned_queue) { -struct list_head *plist, *phead; +struct list_head *plist, *phead; -struct wlan_network *pwlan =NULL ; -struct wlan_network *oldest =NULL ; +struct wlan_network *pwlan =NULL ; +struct wlan_network *oldest =NULL ; phead =get_list_head (scanned_queue);
@@ -467,12 +467,12 @@ static void update_current_network(struct adapter *adapter, struct wlan_bssid_ex/* Caller must hold pmlmepriv->lock first. */ void rtw_update_scanned_network (struct adapter *adapter,struct wlan_bssid_ex *target) { -struct list_head *plist, *phead; +struct list_head *plist, *phead;u32 bssid_ex_sz;struct mlme_priv *pmlmepriv = &adapter->mlmepriv; -struct __queue *queue = &pmlmepriv->scanned_queue; -struct wlan_network *pnetwork =NULL ; -struct wlan_network *oldest =NULL ; +struct __queue *queue = &pmlmepriv->scanned_queue; +struct wlan_network *pnetwork =NULL ; +struct wlan_network *oldest =NULL ;int target_find =0 ;u8 feature =0 ;
@@ -632,11 +632,11 @@ static bool rtw_is_desired_network(struct adapter *adapter, struct wlan_networkreturn bselected; } -void rtw_survey_event_callback (struct adapter *adapter,u8 *pbuf) +void rtw_survey_event_callback (struct adapter *adapter,u8 *pbuf) {u32 len;struct wlan_bssid_ex *pnetwork; -struct mlme_priv *pmlmepriv = &adapter->mlmepriv; +struct mlme_priv *pmlmepriv = &adapter->mlmepriv; pnetwork = (struct wlan_bssid_ex *)pbuf;
@@ -675,9 +675,9 @@ void rtw_survey_event_callback(struct adapter *adapter, u8 *pbuf)spin_unlock_bh (&pmlmepriv->lock); } -void rtw_surveydone_event_callback (struct adapter *adapter,u8 *pbuf) +void rtw_surveydone_event_callback (struct adapter *adapter,u8 *pbuf) { -struct mlme_priv *pmlmepriv = &adapter->mlmepriv; +struct mlme_priv *pmlmepriv = &adapter->mlmepriv;spin_lock_bh (&pmlmepriv->lock);if (pmlmepriv->wps_probe_req_ie) {
@@ -704,7 +704,7 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)_set_timer (&pmlmepriv->assoc_timer,MAX_JOIN_TIMEOUT ); }else {u8 ret = _SUCCESS; -struct wlan_bssid_ex *pdev_network = &adapter->registrypriv.dev_network; +struct wlan_bssid_ex *pdev_network = &adapter->registrypriv.dev_network;u8 *pibss = adapter->registrypriv.dev_network.mac_address;/* pmlmepriv->fw_state ^= _FW_UNDER_SURVEY;because don't set assoc_timer */
@@ -782,11 +782,11 @@ void rtw_fwdbg_event_callback(struct adapter *adapter, u8 *pbuf) { } -static void free_scanqueue (struct mlme_priv *pmlmepriv) +static void free_scanqueue (struct mlme_priv *pmlmepriv) {struct __queue *free_queue = &pmlmepriv->free_bss_pool;struct __queue *scan_queue = &pmlmepriv->scanned_queue; -struct list_head *plist, *phead, *ptemp; +struct list_head *plist, *phead, *ptemp;spin_lock_bh (&scan_queue->lock);spin_lock_bh (&free_queue->lock);
@@ -808,7 +808,7 @@ static void free_scanqueue(struct mlme_priv *pmlmepriv)static void find_network (struct adapter *adapter) {struct wlan_network *pwlan =NULL ; -struct mlme_priv *pmlmepriv = &adapter->mlmepriv; +struct mlme_priv *pmlmepriv = &adapter->mlmepriv;struct wlan_network *tgt_network = &pmlmepriv->cur_network; pwlan =rtw_find_network (&pmlmepriv->scanned_queue, tgt_network->network.mac_address);
@@ -825,14 +825,14 @@ static void find_network(struct adapter *adapter)/* rtw_free_assoc_resources: the caller has to lock pmlmepriv->lock */ void rtw_free_assoc_resources (struct adapter *adapter,int lock_scanned_queue) { -struct mlme_priv *pmlmepriv = &adapter->mlmepriv; +struct mlme_priv *pmlmepriv = &adapter->mlmepriv;struct wlan_network *tgt_network = &pmlmepriv->cur_network;if (check_fwstate (pmlmepriv,WIFI_STATION_STATE |WIFI_AP_STATE )) {struct sta_info *psta; psta =rtw_get_stainfo (&adapter->stapriv, tgt_network->network.mac_address); -rtw_free_stainfo (adapter, psta); +rtw_free_stainfo (adapter, psta); }if (check_fwstate (pmlmepriv,WIFI_ADHOC_STATE |WIFI_ADHOC_MASTER_STATE |WIFI_AP_STATE )) {
@@ -954,7 +954,7 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter, strif (psta) {/* update ptarget_sta */ - psta->aid = pnetwork->join_res; + psta->aid = pnetwork->join_res;update_sta_info (padapter, psta);
@@ -1024,10 +1024,10 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter, str/* pnetwork : returns from rtw_joinbss_event_callback */ /* ptarget_wlan: found from scanned_queue */ -static void rtw_joinbss_update_network (struct adapter *padapter,struct wlan_network *ptarget_wlan,struct wlan_network *pnetwork) +static void rtw_joinbss_update_network (struct adapter *padapter,struct wlan_network *ptarget_wlan,struct wlan_network *pnetwork) {struct mlme_priv *pmlmepriv = &padapter->mlmepriv; -struct wlan_network *cur_network = &pmlmepriv->cur_network; +struct wlan_network *cur_network = &pmlmepriv->cur_network;/* why not use ptarget_wlan?? */ memcpy (&cur_network->network, &pnetwork->network, pnetwork->network.length);
@@ -1073,7 +1073,7 @@ static void rtw_joinbss_update_network(struct adapter *padapter, struct wlan_netrtw_update_ht_cap (padapter, cur_network->network.ies, cur_network->network.ie_length, (u8 ) cur_network->network.configuration.ds_config); } -static struct rt_pmkid_list backupPMKIDList[NUM_PMKID_CACHE ]; +static struct rt_pmkid_list backupPMKIDList[NUM_PMKID_CACHE ];void rtw_reset_securitypriv (struct adapter *adapter) {u8 backupPMKIDIndex =0 ;
@@ -1141,12 +1141,12 @@ void rtw_reset_securitypriv(struct adapter *adapter)void rtw_joinbss_event_prehandle (struct adapter *adapter,u8 *pbuf) {struct sta_info *ptarget_sta =NULL , *pcur_sta =NULL ; -struct sta_priv *pstapriv = &adapter->stapriv; -struct mlme_priv *pmlmepriv = &adapter->mlmepriv; -struct wlan_network *pnetwork = (struct wlan_network *)pbuf; -struct wlan_network *cur_network = &pmlmepriv->cur_network; -struct wlan_network *pcur_wlan =NULL , *ptarget_wlan =NULL ; -unsigned int the_same_macaddr = false; +struct sta_priv *pstapriv = &adapter->stapriv; +struct mlme_priv *pmlmepriv = &adapter->mlmepriv; +struct wlan_network *pnetwork = (struct wlan_network *)pbuf; +struct wlan_network *cur_network = &pmlmepriv->cur_network; +struct wlan_network *pcur_wlan =NULL , *ptarget_wlan =NULL ; +unsigned int the_same_macaddr = false; the_same_macaddr = !memcmp (pnetwork->network.mac_address, cur_network->network.mac_address,ETH_ALEN );
@@ -1248,7 +1248,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adapter, u8 *pbuf)void rtw_joinbss_event_callback (struct adapter *adapter,u8 *pbuf) { -struct wlan_network *pnetwork = (struct wlan_network *)pbuf; +struct wlan_network *pnetwork = (struct wlan_network *)pbuf;mlmeext_joinbss_event_callback (adapter, pnetwork->join_res);
@@ -1271,9 +1271,9 @@ void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf) {struct sta_info *psta;struct mlme_priv *pmlmepriv = &adapter->mlmepriv; -struct stassoc_event *pstassoc = (struct stassoc_event *)pbuf; -struct wlan_network *cur_network = &pmlmepriv->cur_network; -struct wlan_network *ptarget_wlan =NULL ; +struct stassoc_event *pstassoc = (struct stassoc_event *)pbuf; +struct wlan_network *cur_network = &pmlmepriv->cur_network; +struct wlan_network *ptarget_wlan =NULL ;if (!rtw_access_ctrl (adapter, pstassoc->macaddr))return ;
@@ -1365,8 +1365,8 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf)struct wlan_network *pwlan =NULL ;struct wlan_bssid_ex *pdev_network =NULL ;u8 *pibss =NULL ; -struct mlme_priv *pmlmepriv = &adapter->mlmepriv; -struct stadel_event *pstadel = (struct stadel_event *)pbuf; +struct mlme_priv *pmlmepriv = &adapter->mlmepriv; +struct stadel_event *pstadel = (struct stadel_event *)pbuf;struct wlan_network *tgt_network = &pmlmepriv->cur_network;struct mlme_ext_priv *pmlmeext = &adapter->mlmeextpriv;struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
@@ -1435,7 +1435,7 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf)if (check_fwstate (pmlmepriv,WIFI_ADHOC_MASTER_STATE ) ||check_fwstate (pmlmepriv,WIFI_ADHOC_STATE )) { -rtw_free_stainfo (adapter, psta); +rtw_free_stainfo (adapter, psta);if (adapter->stapriv.asoc_sta_count ==1 ) {/* a sta + bc/mc_stainfo (not Ibss_stainfo) */ u8 ret = _SUCCESS;
@@ -1497,7 +1497,7 @@ void _rtw_join_timeout_handler(struct timer_list *t) {struct adapter *adapter =timer_container_of (adapter, t, mlmepriv.assoc_timer); -struct mlme_priv *pmlmepriv = &adapter->mlmepriv; +struct mlme_priv *pmlmepriv = &adapter->mlmepriv;if (adapter->bDriverStopped || adapter->bSurpriseRemoved)return ;
@@ -1540,7 +1540,7 @@ void rtw_scan_timeout_handler(struct timer_list *t) {struct adapter *adapter =timer_container_of (adapter, t, mlmepriv.scan_to_timer); -struct mlme_priv *pmlmepriv = &adapter->mlmepriv; +struct mlme_priv *pmlmepriv = &adapter->mlmepriv;spin_lock_bh (&pmlmepriv->lock);
@@ -1696,10 +1696,10 @@ static int rtw_check_roaming_candidate(struct mlme_priv *mlmeint rtw_select_roaming_candidate (struct mlme_priv *mlme) {int ret = _FAIL; -struct list_head *phead; -struct __queue *queue = &mlme->scanned_queue; -struct wlan_network *pnetwork =NULL ; -struct wlan_network *candidate =NULL ; +struct list_head *phead; +struct __queue *queue = &mlme->scanned_queue; +struct wlan_network *pnetwork =NULL ; +struct wlan_network *candidate =NULL ;if (!mlme->cur_network_scanned) {WARN_ON (1 );
@@ -1787,11 +1787,11 @@ static int rtw_check_join_candidate(struct mlme_priv *mlmeint rtw_select_and_join_from_scanned_queue (struct mlme_priv *pmlmepriv) {int ret; -struct list_head *phead; +struct list_head *phead;struct adapter *adapter; -struct __queue *queue = &pmlmepriv->scanned_queue; -struct wlan_network *pnetwork =NULL ; -struct wlan_network *candidate =NULL ; +struct __queue *queue = &pmlmepriv->scanned_queue; +struct wlan_network *pnetwork =NULL ; +struct wlan_network *candidate =NULL ; adapter = (struct adapter *)pmlmepriv->nic_hdl;
@@ -1837,10 +1837,10 @@ int rtw_select_and_join_from_scanned_queue(struct mlme_priv *pmlmepriv)signed int rtw_set_auth (struct adapter *adapter,struct security_priv *psecuritypriv) { -struct cmd_obj *pcmd; -struct setauth_parm *psetauthparm; -struct cmd_priv *pcmdpriv = &adapter->cmdpriv; -signed int res = _SUCCESS; +struct cmd_obj *pcmd; +struct setauth_parm *psetauthparm; +struct cmd_priv *pcmdpriv = &adapter->cmdpriv; +signed int res = _SUCCESS; pcmd =kzalloc_obj (*pcmd);if (!pcmd) {
@@ -1859,7 +1859,7 @@ signed int rtw_set_auth(struct adapter *adapter, struct security_priv *psecurity pcmd->cmdcode =SET_AUTH_CMD ; pcmd->parmbuf = (unsigned char *)psetauthparm; - pcmd->cmdsz = (sizeof (struct setauth_parm )); + pcmd->cmdsz = (sizeof (struct setauth_parm )); pcmd->rsp =NULL ; pcmd->rspsz =0 ;
@@ -1875,9 +1875,9 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp {u8 keylen;struct cmd_obj *pcmd; -struct setkey_parm *psetkeyparm; +struct setkey_parm *psetkeyparm;struct cmd_priv *pcmdpriv = &adapter->cmdpriv; -signed int res = _SUCCESS; +signed int res = _SUCCESS; psetkeyparm =kzalloc_obj (*psetkeyparm);if (!psetkeyparm) {
@@ -1930,7 +1930,7 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp pcmd->cmdcode =SET_KEY_CMD ; pcmd->parmbuf = (u8 *)psetkeyparm; - pcmd->cmdsz = (sizeof (struct setkey_parm )); + pcmd->cmdsz = (sizeof (struct setkey_parm )); pcmd->rsp =NULL ; pcmd->rspsz =0 ;
@@ -1948,7 +1948,7 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp/* adjust ies for rtw_joinbss_cmd in WMM */ int rtw_restruct_wmm_ie (struct adapter *adapter,u8 *in_ie,u8 *out_ie,uint in_len,uint initial_out_len) { -unsigned int ielength =0 ; +unsigned int ielength =0 ;unsigned int i, j; i =12 ;/* after the fixed IE */
@@ -2025,7 +2025,7 @@ static int rtw_append_pmkid(struct adapter *Adapter, int iEntry, u8 *ie, uint iestatic void rtw_report_sec_ie (struct adapter *adapter,u8 authmode,u8 *sec_ie) { -uint len; +uint len;u8 *buff, *p;union iwreq_data wrqu;
@@ -2059,12 +2059,12 @@ static void rtw_report_sec_ie(struct adapter *adapter, u8 authmode, u8 *sec_ie)signed int rtw_restruct_sec_ie (struct adapter *adapter,u8 *in_ie,u8 *out_ie,uint in_len) {u8 authmode =0x0 ; -uint ielength; +uint ielength;int iEntry;struct mlme_priv *pmlmepriv = &adapter->mlmepriv;struct security_priv *psecuritypriv = &adapter->securitypriv; -uint ndisauthmode = psecuritypriv->ndisauthtype; +uint ndisauthmode = psecuritypriv->ndisauthtype;/* copy fixed ie only */ memcpy (out_ie, in_ie,12 );
@@ -2099,7 +2099,7 @@ void rtw_init_registrypriv_dev_network(struct adapter *adapter) {struct registry_priv *pregistrypriv = &adapter->registrypriv;struct eeprom_priv *peepriv = &adapter->eeprompriv; -struct wlan_bssid_ex *pdev_network = &pregistrypriv->dev_network; +struct wlan_bssid_ex *pdev_network = &pregistrypriv->dev_network;u8 *myhwaddr =myid (peepriv);memcpy (pdev_network->mac_address, myhwaddr,ETH_ALEN );
@@ -2114,9 +2114,9 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter) {int sz =0 ;struct registry_priv *pregistrypriv = &adapter->registrypriv; -struct wlan_bssid_ex *pdev_network = &pregistrypriv->dev_network; -struct security_priv *psecuritypriv = &adapter->securitypriv; -struct wlan_network *cur_network = &adapter->mlmepriv.cur_network; +struct wlan_bssid_ex *pdev_network = &pregistrypriv->dev_network; +struct security_priv *psecuritypriv = &adapter->securitypriv; +struct wlan_network *cur_network = &adapter->mlmepriv.cur_network; pdev_network->privacy = (psecuritypriv->dot11_privacy_algrthm >0 ?1 :0 ) ;/* adhoc no 802.1x */
@@ -2137,7 +2137,7 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter) pdev_network->ie_length = sz; - pdev_network->length =get_wlan_bssid_ex_sz ((struct wlan_bssid_ex *)pdev_network); + pdev_network->length =get_wlan_bssid_ex_sz ((struct wlan_bssid_ex *)pdev_network);/* notes: translate ie_length & length after assign the length to cmdsz in createbss_cmd(); */ /* pdev_network->ie_length = cpu_to_le32(sz); */
@@ -2178,8 +2178,8 @@ void rtw_ht_use_default_setting(struct adapter *padapter)struct mlme_priv *pmlmepriv = &padapter->mlmepriv;struct ht_priv *phtpriv = &pmlmepriv->htpriv;struct registry_priv *pregistrypriv = &padapter->registrypriv; -bool bHwLDPCSupport = false, bHwSTBCSupport = false; -bool bHwSupportBeamformer = false, bHwSupportBeamformee = false; +bool bHwLDPCSupport = false, bHwSTBCSupport = false; +bool bHwSupportBeamformer = false, bHwSupportBeamformee = false;if (pregistrypriv->wifi_spec) phtpriv->bss_coexist =1 ;
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c +1 -1
@@ -454,7 +454,7 @@ void rtw_free_all_stainfo(struct adapter *padapter)/* any station allocated can be searched by hash list */ struct sta_info *rtw_get_stainfo (struct sta_priv *pstapriv,u8 *hwaddr) { -struct list_head *plist, *phead; +struct list_head *plist, *phead;struct sta_info *psta =NULL ;u32 index;u8 *addr;
drivers/staging/rtl8723bs/include/wlan_bssdef.h +28 -28
91 lines not on this page · raw message
Signature · 1 line
2.54.0
PATCH 2/3 staging: rtl8723bs: wrap line over 100 characters
In reply to Dalvin-Ehinoma Noah AiguobasFix checkpatch warning by wrapping the lines.
--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme.c +7 -3
@@ -704,13 +704,16 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)_set_timer (&pmlmepriv->assoc_timer,MAX_JOIN_TIMEOUT ); }else {u8 ret = _SUCCESS; -struct wlan_bssid_ex *pdev_network = &adapter->registrypriv.dev_network; +struct wlan_bssid_ex *pdev_network = + &adapter->registrypriv.dev_network; +u8 *pibss = adapter->registrypriv.dev_network.mac_address;/* pmlmepriv->fw_state ^= _FW_UNDER_SURVEY;because don't set assoc_timer */ _clr_fwstate_ (pmlmepriv, _FW_UNDER_SURVEY); -memcpy (&pdev_network->ssid, &pmlmepriv->assoc_ssid,sizeof (struct ndis_802_11_ssid )); +memcpy (&pdev_network->ssid, &pmlmepriv->assoc_ssid, +sizeof (struct ndis_802_11_ssid ));rtw_update_registrypriv_dev_network (adapter);rtw_generate_random_ibss (pibss);
@@ -1024,7 +1027,8 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter, str/* pnetwork : returns from rtw_joinbss_event_callback */ /* ptarget_wlan: found from scanned_queue */ -static void rtw_joinbss_update_network (struct adapter *padapter,struct wlan_network *ptarget_wlan,struct wlan_network *pnetwork) +static void rtw_joinbss_update_network (struct adapter *padapter,struct wlan_network *ptarget_wlan, +struct wlan_network *pnetwork) {struct mlme_priv *pmlmepriv = &padapter->mlmepriv;struct wlan_network *cur_network = &pmlmepriv->cur_network;
Signature · 1 line
2.54.0
PATCH 3/3 staging: rtl8723bs: Renaming variables with type prefix
In reply to Dalvin-Ehinoma Noah AiguobasRenaming deprecated variable names which use prefixes as type indicators to conform to the styleguide and for improved readability.
--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 152 +++++++++++----------- 1 file changed, 76 insertions(+), 76 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme.c +76 -76
@@ -675,52 +675,52 @@ void rtw_survey_event_callback(struct adapter *adapter, u8 *pbuf)spin_unlock_bh (&pmlmepriv->lock); } -void rtw_surveydone_event_callback (struct adapter *adapter,u8 *pbuf) +void rtw_surveydone_event_callback (struct adapter *adapter,u8 *buf) { -struct mlme_priv *pmlmepriv = &adapter->mlmepriv; +struct mlme_priv *mlme_priv = &adapter->mlmepriv; -spin_lock_bh (&pmlmepriv->lock); -if (pmlmepriv->wps_probe_req_ie) { - pmlmepriv->wps_probe_req_ie_len =0 ; -kfree (pmlmepriv->wps_probe_req_ie); - pmlmepriv->wps_probe_req_ie =NULL ; +spin_lock_bh (&mlme_priv->lock); +if (mlme_priv->wps_probe_req_ie) { + mlme_priv->wps_probe_req_ie_len =0 ; +kfree (mlme_priv->wps_probe_req_ie); + mlme_priv->wps_probe_req_ie =NULL ; } -if (check_fwstate (pmlmepriv, _FW_UNDER_SURVEY)) { -spin_unlock_bh (&pmlmepriv->lock); -timer_delete_sync (&pmlmepriv->scan_to_timer); -spin_lock_bh (&pmlmepriv->lock); -_clr_fwstate_ (pmlmepriv, _FW_UNDER_SURVEY); +if (check_fwstate (mlme_priv, _FW_UNDER_SURVEY)) { +spin_unlock_bh (&mlme_priv->lock); +timer_delete_sync (&mlme_priv->scan_to_timer); +spin_lock_bh (&mlme_priv->lock); +_clr_fwstate_ (mlme_priv, _FW_UNDER_SURVEY); }rtw_set_signal_stat_timer (&adapter->recvpriv); -if (pmlmepriv->to_join) { -if (check_fwstate (pmlmepriv,WIFI_ADHOC_STATE )) { -if (!check_fwstate (pmlmepriv, _FW_LINKED)) { -set_fwstate (pmlmepriv, _FW_UNDER_LINKING); +if (mlme_priv->to_join) { +if (check_fwstate (mlme_priv,WIFI_ADHOC_STATE )) { +if (!check_fwstate (mlme_priv, _FW_LINKED)) { +set_fwstate (mlme_priv, _FW_UNDER_LINKING); -if (rtw_select_and_join_from_scanned_queue (pmlmepriv) == _SUCCESS) { -_set_timer (&pmlmepriv->assoc_timer,MAX_JOIN_TIMEOUT ); +if (rtw_select_and_join_from_scanned_queue (mlme_priv) == _SUCCESS) { +_set_timer (&mlme_priv->assoc_timer,MAX_JOIN_TIMEOUT ); }else {u8 ret = _SUCCESS; -struct wlan_bssid_ex *pdev_network = +struct wlan_bssid_ex *dev_network = &adapter->registrypriv.dev_network; -u8 *pibss = adapter->registrypriv.dev_network.mac_address; +u8 *ibss = adapter->registrypriv.dev_network.mac_address; -/* pmlmepriv->fw_state ^= _FW_UNDER_SURVEY;because don't set assoc_timer */ -_clr_fwstate_ (pmlmepriv, _FW_UNDER_SURVEY); +/* mlme_priv->fw_state ^= _FW_UNDER_SURVEY;because don't set assoc_timer */ +_clr_fwstate_ (mlme_priv, _FW_UNDER_SURVEY); -memcpy (&pdev_network->ssid, &pmlmepriv->assoc_ssid, +memcpy (&dev_network->ssid, &mlme_priv->assoc_ssid,sizeof (struct ndis_802_11_ssid ));rtw_update_registrypriv_dev_network (adapter); -rtw_generate_random_ibss (pibss); +rtw_generate_random_ibss (ibss); - pmlmepriv->fw_state =WIFI_ADHOC_MASTER_STATE ; + mlme_priv->fw_state =WIFI_ADHOC_MASTER_STATE ; - pmlmepriv->to_join = false; + mlme_priv->to_join = false; ret =rtw_createbss_cmd (adapter);if (ret != _SUCCESS)
@@ -730,37 +730,37 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) }else {int s_ret; -set_fwstate (pmlmepriv, _FW_UNDER_LINKING); - pmlmepriv->to_join = false; - s_ret =rtw_select_and_join_from_scanned_queue (pmlmepriv); +set_fwstate (mlme_priv, _FW_UNDER_LINKING); + mlme_priv->to_join = false; + s_ret =rtw_select_and_join_from_scanned_queue (mlme_priv);if (s_ret == _SUCCESS) { -_set_timer (&pmlmepriv->assoc_timer,MAX_JOIN_TIMEOUT ); +_set_timer (&mlme_priv->assoc_timer,MAX_JOIN_TIMEOUT ); }else if (s_ret ==2 ) {/* there is no need to wait for join */ -_clr_fwstate_ (pmlmepriv, _FW_UNDER_LINKING); +_clr_fwstate_ (mlme_priv, _FW_UNDER_LINKING);rtw_indicate_connect (adapter); }else {if (rtw_to_roam (adapter) !=0 ) {if (rtw_dec_to_roam (adapter) ==0 || -rtw_sitesurvey_cmd (adapter, &pmlmepriv->assoc_ssid, +rtw_sitesurvey_cmd (adapter, &mlme_priv->assoc_ssid,1 ,NULL ,0 ) != _SUCCESS) {rtw_set_to_roam (adapter,0 );rtw_free_assoc_resources (adapter,1 );rtw_indicate_disconnect (adapter); }else { - pmlmepriv->to_join = true; + mlme_priv->to_join = true; } }else {rtw_indicate_disconnect (adapter); } -_clr_fwstate_ (pmlmepriv, _FW_UNDER_LINKING); +_clr_fwstate_ (mlme_priv, _FW_UNDER_LINKING); } } }else {if (rtw_chk_roam_flags (adapter,RTW_ROAM_ACTIVE )) { -if (check_fwstate (pmlmepriv,WIFI_STATION_STATE ) && -check_fwstate (pmlmepriv, _FW_LINKED)) { -if (rtw_select_roaming_candidate (pmlmepriv) == _SUCCESS) { -receive_disconnect (adapter, pmlmepriv->cur_network.network.mac_address +if (check_fwstate (mlme_priv,WIFI_STATION_STATE ) && +check_fwstate (mlme_priv, _FW_LINKED)) { +if (rtw_select_roaming_candidate (mlme_priv) == _SUCCESS) { +receive_disconnect (adapter, mlme_priv->cur_network.network.mac_address ,WLAN_REASON_ACTIVE_ROAM ); } }
@@ -768,7 +768,7 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) } unlock: -spin_unlock_bh (&pmlmepriv->lock); +spin_unlock_bh (&mlme_priv->lock);rtw_os_xmit_schedule (adapter);
@@ -2177,57 +2177,57 @@ void rtw_joinbss_reset(struct adapter *padapter) } } -void rtw_ht_use_default_setting (struct adapter *padapter) +void rtw_ht_use_default_setting (struct adapter *adapter) { -struct mlme_priv *pmlmepriv = &padapter->mlmepriv; -struct ht_priv *phtpriv = &pmlmepriv->htpriv; -struct registry_priv *pregistrypriv = &padapter->registrypriv; -bool bHwLDPCSupport = false, bHwSTBCSupport = false; -bool bHwSupportBeamformer = false, bHwSupportBeamformee = false; +struct mlme_priv *mlme_priv = &adapter->mlmepriv; +struct ht_priv *ht_priv = &mlme_priv->htpriv; +struct registry_priv *registry_priv = &adapter->registrypriv; +bool hw_ldpc_support = false, hw_stbc_support = false; +bool hw_support_beamformer = false, hw_support_beamformee = false; -if (pregistrypriv->wifi_spec) - phtpriv->bss_coexist =1 ; +if (registry_priv->wifi_spec) + ht_priv->bss_coexist =1 ;else - phtpriv->bss_coexist =0 ; + ht_priv->bss_coexist =0 ; - phtpriv->sgi_40m =TEST_FLAG (pregistrypriv->short_gi,BIT (1 )) ? true : false; - phtpriv->sgi_20m =TEST_FLAG (pregistrypriv->short_gi,BIT (0 )) ? true : false; + ht_priv->sgi_40m =TEST_FLAG (registry_priv->short_gi,BIT (1 )) ? true : false; + ht_priv->sgi_20m =TEST_FLAG (registry_priv->short_gi,BIT (0 )) ? true : false;/* LDPC support */ -rtw_hal_get_def_var (padapter,HAL_DEF_RX_LDPC , (u8 *)&bHwLDPCSupport); -CLEAR_FLAGS (phtpriv->ldpc_cap); -if (bHwLDPCSupport) { -if (TEST_FLAG (pregistrypriv->ldpc_cap,BIT (4 ))) -SET_FLAG (phtpriv->ldpc_cap,LDPC_HT_ENABLE_RX ); +rtw_hal_get_def_var (adapter,HAL_DEF_RX_LDPC , (u8 *)&hw_ldpc_support); +CLEAR_FLAGS (ht_priv->ldpc_cap); +if (hw_ldpc_support) { +if (TEST_FLAG (registry_priv->ldpc_cap,BIT (4 ))) +SET_FLAG (ht_priv->ldpc_cap,LDPC_HT_ENABLE_RX ); } -rtw_hal_get_def_var (padapter,HAL_DEF_TX_LDPC , (u8 *)&bHwLDPCSupport); -if (bHwLDPCSupport) { -if (TEST_FLAG (pregistrypriv->ldpc_cap,BIT (5 ))) -SET_FLAG (phtpriv->ldpc_cap,LDPC_HT_ENABLE_TX ); +rtw_hal_get_def_var (adapter,HAL_DEF_TX_LDPC , (u8 *)&hw_ldpc_support); +if (hw_ldpc_support) { +if (TEST_FLAG (registry_priv->ldpc_cap,BIT (5 ))) +SET_FLAG (ht_priv->ldpc_cap,LDPC_HT_ENABLE_TX ); }/* STBC */ -rtw_hal_get_def_var (padapter,HAL_DEF_TX_STBC , (u8 *)&bHwSTBCSupport); -CLEAR_FLAGS (phtpriv->stbc_cap); -if (bHwSTBCSupport) { -if (TEST_FLAG (pregistrypriv->stbc_cap,BIT (5 ))) -SET_FLAG (phtpriv->stbc_cap,STBC_HT_ENABLE_TX ); +rtw_hal_get_def_var (adapter,HAL_DEF_TX_STBC , (u8 *)&hw_stbc_support); +CLEAR_FLAGS (ht_priv->stbc_cap); +if (hw_stbc_support) { +if (TEST_FLAG (registry_priv->stbc_cap,BIT (5 ))) +SET_FLAG (ht_priv->stbc_cap,STBC_HT_ENABLE_TX ); } -rtw_hal_get_def_var (padapter,HAL_DEF_RX_STBC , (u8 *)&bHwSTBCSupport); -if (bHwSTBCSupport) { -if (TEST_FLAG (pregistrypriv->stbc_cap,BIT (4 ))) -SET_FLAG (phtpriv->stbc_cap,STBC_HT_ENABLE_RX ); +rtw_hal_get_def_var (adapter,HAL_DEF_RX_STBC , (u8 *)&hw_stbc_support); +if (hw_stbc_support) { +if (TEST_FLAG (registry_priv->stbc_cap,BIT (4 ))) +SET_FLAG (ht_priv->stbc_cap,STBC_HT_ENABLE_RX ); }/* Beamforming setting */ -rtw_hal_get_def_var (padapter,HAL_DEF_EXPLICIT_BEAMFORMER , (u8 *)&bHwSupportBeamformer); -rtw_hal_get_def_var (padapter,HAL_DEF_EXPLICIT_BEAMFORMEE , (u8 *)&bHwSupportBeamformee); -CLEAR_FLAGS (phtpriv->beamform_cap); -if (TEST_FLAG (pregistrypriv->beamform_cap,BIT (4 )) && bHwSupportBeamformer) -SET_FLAG (phtpriv->beamform_cap,BEAMFORMING_HT_BEAMFORMER_ENABLE ); - -if (TEST_FLAG (pregistrypriv->beamform_cap,BIT (5 )) && bHwSupportBeamformee) -SET_FLAG (phtpriv->beamform_cap,BEAMFORMING_HT_BEAMFORMEE_ENABLE ); +rtw_hal_get_def_var (adapter,HAL_DEF_EXPLICIT_BEAMFORMER , (u8 *)&hw_support_beamformer); +rtw_hal_get_def_var (adapter,HAL_DEF_EXPLICIT_BEAMFORMEE , (u8 *)&hw_support_beamformee); +CLEAR_FLAGS (ht_priv->beamform_cap); +if (TEST_FLAG (registry_priv->beamform_cap,BIT (4 )) && hw_support_beamformer) +SET_FLAG (ht_priv->beamform_cap,BEAMFORMING_HT_BEAMFORMER_ENABLE ); + +if (TEST_FLAG (registry_priv->beamform_cap,BIT (5 )) && hw_support_beamformee) +SET_FLAG (ht_priv->beamform_cap,BEAMFORMING_HT_BEAMFORMEE_ENABLE ); }void rtw_build_wmm_ie_ht (struct adapter *padapter,u8 *out_ie,uint *pout_len)
Signature · 1 line
2.54.0
Greg KH
maintainerRe: [PATCH 3/3] staging: rtl8723bs: Renaming variables with type prefix
Quoted 13 lines · Dalvin-Ehinoma Noah Aiguobas
Renaming deprecated variable names which use prefixes as type indicators to conform to the styleguide and for improved readability.
Signed-off-by Dalvin-Ehinoma Noah Aiguobas <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 152 +++++++++++----------- 1 file changed, 76 insertions(+), 76 deletions(-)drivers/staging/rtl8723bs/core/rtw_mlme.c +0
-0
drivers/staging/rtl8723bs/core/rtw_mlme.c void rtw_survey_event_callback(struct adapter *adapter, u8 *pbuf) · line 680
Quoted 8 lines
drivers/staging/rtl8723bs/core/rtw_mlme.c +2
-2@@ -675,52 +675,52 @@ void rtw_survey_event_callback(struct adapter *adapter, u8 *pbuf)spin_unlock_bh (&pmlmepriv->lock); } -void rtw_surveydone_event_callback (struct adapter *adapter,u8 *pbuf) +void rtw_surveydone_event_callback (struct adapter *adapter,u8 *buf) { -struct mlme_priv *pmlmepriv = &adapter->mlmepriv; +struct mlme_priv *mlme_priv = &adapter->mlmepriv;
As you are changing all of the variables, this patch is hard to read and verify that this is correct. Please only do one variable name at a time.
thanks,
greg k-h