Skip to contentSkip to conversation

ASoC: codecs: ES8389: Remove redundant comparison

PATCH In review Ethan Tidmore 2 participants 2 messages Jul 19 – Jul 21

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: codecs: ES8389: Remove redundant comparison

The comparison (target_hz < 0) will always be false because the variable 'target_hz' is of the u32 type.

Remove redundant comparison and simply code around it.

Fixes 87592da1a490a ("ASoC: codecs: ES8389: Add private members about HPF")
---
 sound/soc/codecs/es8389.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/es8389.c +1 -1
index 0c7567e2ffc2..80efce3e0a22 100644
@@ -106,7 +106,7 @@ static bool find_best_hpf_freq(u32 target_hz, u8 *hpf1, u8 *hpf2, u32 *out)
 	u32 f, diff;
 	int i, j;
 
-	if ((target_hz > 1020) | (target_hz < 0))
+	if (target_hz > 1020)
 		return false;
 
 	for (i = 0; i < 10; i++) {
Signature · 3 lines
Thanks,
ET
https://github.com/sponsors/ethantidmore
maintainer
#1 lore raw
Quoted 1 line · Ethan Tidmore

ASoC: codecs: ES8389: Remove redundant comparison

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/1] ASoC: codecs: ES8389: Remove redundant comparison

      https://git.kernel.org/broonie/sound/c/acc414eda8e9

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark