Skip to contentSkip to conversation

ASoC: tas2781: Use correct calibration data for SINEGAIN2 register

PATCH In review [email protected] 2 participants 2 messages Jul 20 – Jul 27

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: tas2781: Use correct calibration data for SINEGAIN2 register

From: wangdicheng <[email protected]>

The SINEGAIN2_REG case in cali_reg_update() references t->sin_gn[] rather than t->sin_gn2[], causing the second pilot tone gain calibration to be programmed with the wrong register address.

These are distinct fields in struct fct_param_address and are populated from separate firmware parameters by the parser in tas2781-fmwlib.c.

Fixes 84d6a465f211 ("ASoC: tas2781: Support dsp firmware Alpha and Beta seaies")
---
 sound/soc/codecs/tas2781-i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/tas2781-i2c.c +2 -2
index 9e6f0ad5f05d..209067e98e1f 100644
@@ -1310,8 +1310,8 @@ static void cali_reg_update(struct bulk_reg_val *p,
 				t->sin_gn[2]);
 			break;
 		case TAS2781_PRM_SINEGAIN2_REG:
-			reg = TASDEVICE_REG(t->sin_gn[0], t->sin_gn[1],
-				t->sin_gn[2]);
+			reg = TASDEVICE_REG(t->sin_gn2[0], t->sin_gn2[1],
+				t->sin_gn2[2]);
 			break;
 		default:
 			reg = 0;
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 1 line · On Mon, 20 Jul 2026 16:16:16 +0800, [email protected] wrote:

ASoC: tas2781: Use correct calibration data for SINEGAIN2 register

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.2

Thanks!

[1/1] ASoC: tas2781: Use correct calibration data for SINEGAIN2 register

      https://git.kernel.org/broonie/sound/c/dd88cf6273de

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark