Skip to contentSkip to conversation

soundwire: dmi-quirks: Disable ghost Realtek on Asus Zenbook Duo

PATCH Applied Charles Keepax 3 participants 3 messages Jul 20 – Aug 6

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soundwire: dmi-quirks: Disable ghost Realtek on Asus Zenbook Duo

The Asus Zenbook Duo also has a Realtek device in the ACPI that doesn't exist in the physical hardware. This confuses the machine driver into attempting to create DAI links for the device. Add a quirk to remove this device.

---
 drivers/soundwire/dmi-quirks.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/soundwire/dmi-quirks.c +7 -0
index 62cee6e2179da..f738e547a1f30 100644
@@ -200,6 +200,13 @@ static const struct dmi_system_id adr_remap_quirk_table[] = {
 		},
 		.driver_data = (void *)ghost_realtek,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUS"),
+			DMI_MATCH(DMI_BOARD_NAME, "UX8407AA"),
+		},
+		.driver_data = (void *)ghost_realtek,
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
Signature · 1 line
2.47.3
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Charles Keepax

The Asus Zenbook Duo also has a Realtek device in the ACPI that doesn't exist in the physical hardware. This confuses the machine driver into attempting to create DAI links for the device. Add a quirk to remove this device.

This is likely to be a never-ending race... I wonder if the machine description used to find the relevant machine driver could be used to drop that ghost device, or if there would be any merit in having a quirk file provided to distros and read via e.g. sysfs to have faster patching done by userspace.

Quoted 22 lines
---
 drivers/soundwire/dmi-quirks.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/soundwire/dmi-quirks.c +7 -0
index 62cee6e2179da..f738e547a1f30 100644
@@ -200,6 +200,13 @@ static const struct dmi_system_id adr_remap_quirk_table[] = {
 		},
 		.driver_data = (void *)ghost_realtek,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUS"),
+			DMI_MATCH(DMI_BOARD_NAME, "UX8407AA"),
+		},
+		.driver_data = (void *)ghost_realtek,
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
maintainer Applied
#2 lore raw
In reply to Charles Keepax
Quoted 6 lines · Charles Keepax

The Asus Zenbook Duo also has a Realtek device in the ACPI that doesn't exist in the physical hardware. This confuses the machine driver into attempting to create DAI links for the device. Add a quirk to remove this device.

Applied, thanks!

[1/1] soundwire: dmi-quirks: Disable ghost Realtek on Asus Zenbook Duo

      commit: ca02ffd4975ca5249abf0cfb750a495d23b453ee

Best regards,

Signature · 1 line
~Vinod