tipc: fix integer overflow in tipc_recvmsg() and tipc_recvstream()
Subsystems (3)
PATCH 1/1 tipc: fix integer overflow in tipc_recvmsg() and tipc_recvstream()
In tipc_recvmsg(), the copy length is computed as:
copy = min_t(int, dlen - offset, buflen);
buflen is size_t but min_t(int, ...) casts it to int. When buflen exceeds INT_MAX (e.g. 0xFFFFFFFF via io_uring provided buffers), it wraps negative, wins the comparison, and the negative copy length propagates to simple_copy_to_iter() where int-to-size_t promotion makes it SIZE_MAX, triggering a WARN_ON. tipc_recvstream() has the same pattern.
Kernel panic - not syncing: kernel: panic_on_warn set ... RIP: 0010:simple_copy_to_iter+0x9e/0xd0 (net/core/datagram.c:521) Call Trace: __skb_datagram_iter+0x123/0x8b0 (net/core/datagram.c:402) skb_copy_datagram_iter+0x77/0x1a0 (net/core/datagram.c:534) tipc_recvmsg+0x3d7/0xe80 (net/tipc/socket.c:1934) io_recvmsg+0x47e/0xda0
Fix by changing min_t(int, ...) to min_t(size_t, ...) in both functions. The result is always <= (dlen - offset), which is bounded by TIPC maximum message size (0x1ffff bytes), so the implicit narrowing on assignment to int copy is always safe.
--- net/tipc/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/tipc/socket.c +2 -2
@@ -1935,7 +1935,7 @@ static int tipc_recvmsg(struct socket *sock, struct msghdr *m,if (likely (!err)) {int offset = skb_cb->bytes_read; - copy =min_t (int, dlen - offset, buflen); + copy =min_t (size_t, dlen - offset, buflen); rc =skb_copy_datagram_msg (skb, hlen + offset, m, copy);if (unlikely (rc)) goto exit;
@@ -2067,7 +2067,7 @@ static int tipc_recvstream(struct socket *sock, struct msghdr *m,/* Copy data if msg ok, otherwise return error/partial data */ if (likely (!err)) { offset = skb_cb->bytes_read; - copy =min_t (int, dlen - offset, buflen - copied); + copy =min_t (size_t, dlen - offset, buflen - copied); rc =skb_copy_datagram_msg (skb, hlen + offset, m, copy);if (unlikely (rc))break ;
Signature · 1 line
2.53.0
Quoted 26 lines
Subject: [PATCH net] tipc: fix integer overflow in
tipc_recvmsg()andtipc_recvstream()In
tipc_recvmsg(), the copy length is computed as:copy = min_t(int, dlen - offset, buflen);buflen is
size_tbutmin_t(int, ...)casts it to int. When buflen exceedsINT_MAX(e.g.0xFFFFFFFFviaio_uringprovided buffers), it wraps negative, wins the comparison, and the negative copy length propagates tosimple_copy_to_iter()where int-to-size_t promotion makes itSIZE_MAX, triggering aWARN_ON.tipc_recvstream()has the same pattern.Kernel panic - not syncing: kernel: panic_on_warn set ... RIP: 0010:simple_copy_to_iter+0x9e/0xd0 (net/core/datagram.c:521) Call Trace: __skb_datagram_iter+0x123/0x8b0 (net/core/datagram.c:402) skb_copy_datagram_iter+0x77/0x1a0 (net/core/datagram.c:534) tipc_recvmsg+0x3d7/0xe80 (net/tipc/socket.c:1934) io_recvmsg+0x47e/0xda0Fix by changing
min_t(int, ...)tomin_t(size_t, ...)in both functions. The result is always <= (dlen - offset), which is bounded by TIPC maximum message size (0x1ffffbytes), so the implicit narrowing on assignment to int copy is always safe.
Quoted 5 lines
Fixes e9f8b10101c6 ("tipc: refactor function tipc_sk_recvmsg()")Fixes ec8a09fbbeff ("tipc: refactor function tipc_sk_recv_stream()")Reported-by [email protected]Signed-off-by Cen Zhang (Microsoft) <[email protected]>---
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 4 lines · On Mon, 20 Jul 2026 17:41:03 -0400 you wrote:
In
tipc_recvmsg(), the copy length is computed as:copy = min_t(int, dlen - offset, buflen);
Quoted 8 lines
buflen is
size_tbutmin_t(int, ...)casts it to int. When buflen exceedsINT_MAX(e.g.0xFFFFFFFFviaio_uringprovided buffers), it wraps negative, wins the comparison, and the negative copy length propagates tosimple_copy_to_iter()where int-to-size_t promotion makes itSIZE_MAX, triggering aWARN_ON.tipc_recvstream()has the same pattern.[...]
Here is the summary with links:
- [net] tipc: fix integer overflow in tipc_recvmsg() and tipc_recvstream()
https://git.kernel.org/netdev/net/c/47f42ff521b4
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html