accel/accel-irq: Avoid using inlined functions with external linkage
PATCH 1/1 accel/accel-irq: Avoid using inlined functions with external linkage
Similarly to commit 9de9fa5cf2 ("hw/arm/smmu-common: Avoid using inlined functions with external linkage"):
None of our code base require / use inlined functions with external linkage. Some places use internal inlining in the hot path. These two functions are certainly not in any hot path and don't justify any inlining, so these are likely oversights rather than intentional.
--- accel/accel-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
accel/accel-irq.c +1 -1
@@ -90,7 +90,7 @@ int accel_irqchip_remove_irqfd_notifier_gsi(EventNotifier *n, int virq)return -ENOSYS ; } -inline AccelRouteChange accel_irqchip_begin_route_changes (void ) +AccelRouteChange accel_irqchip_begin_route_changes (void ) {if (mshv_msi_via_irqfd_enabled ()) { return (AccelRouteChange) {
Signature · 1 line
2.53.0
Quoted 18 lines · Philippe Mathieu-Daudé
Similarly to commit
9de9fa5cf2("hw/arm/smmu-common: Avoid using inlined functions with external linkage"):None of our code base require / use inlined functions with external linkage. Some places use internal inlining in the hot path. These two functions are certainly not in any hot path and don't justify any inlining, so these are likely oversights rather than intentional.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- accel/accel-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)accel/accel-irq.c +0
-0
accel/accel-irq.c int accel_irqchip_remove_irqfd_notifier_gsi(EventNotifier *n, int virq) · line 96
Quoted 8 lines
accel/accel-irq.c +1
-1@@ -90,7 +90,7 @@ int accel_irqchip_remove_irqfd_notifier_gsi(EventNotifier *n, int virq)return -ENOSYS ; } -inline AccelRouteChange accel_irqchip_begin_route_changes (void ) +AccelRouteChange accel_irqchip_begin_route_changes (void ) {if (mshv_msi_via_irqfd_enabled ()) { return (AccelRouteChange) {
r~