RDMA/mlx5: Make sure that UMR page is aligned to PAGE_SIZE
Subsystems (2)
PATCH 1/1 RDMA/mlx5: Make sure that UMR page is aligned to PAGE_SIZE
From: Leon Romanovsky <[email protected]>
The UMR XLT buffer needs to be aligned to PAGE_SIZE.
--- drivers/infiniband/hw/mlx5/umr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/mlx5/umr.c +1 -1
@@ -518,7 +518,7 @@ static void *mlx5r_umr_alloc_xlt(size_t *nents, size_t ent_size, gfp_t gfp_mask) size =min_t (size_t, ent_size *ALIGN (*nents, xlt_chunk_align),MLX5_MAX_UMR_CHUNK ); *nents = size / ent_size; - res =kmalloc (size, gfp_mask | __GFP_NOWARN); + res =kmalloc (PAGE_ALIGN (size), gfp_mask | __GFP_NOWARN);if (res)return res;
---
base-commit: 0e8e94c15091041ea8910cbfcade5a9c7cfe3f90
change-id: 20260722-fix-get-order-alignment-b35d7958832d
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>
Quoted 3 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
The UMR XLT buffer needs to be aligned to
PAGE_SIZE.
Why? It goes into a sgl? The device certainly does not work on PAGE_SIZE, so if there is some alignment here it should be the MLX5 adaptor alignment
Jason
Quoted 8 lines · Jason Gunthorpe
Quoted 3 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
The UMR XLT buffer needs to be aligned to
PAGE_SIZE.Why? It goes into a sgl? The device certainly does not work on
PAGE_SIZE, so if there is some alignment here it should be the MLX5 adaptor alignment
We need an alignment to 2Kb as a minimum here.
In our case, we got the following assert:
‘mlx5_post_send_umr: assertion failed (MLX5_GET64(umr_pointer_desc_argument, data, address) & 0×7ff == 0)’
Thanks
Quoted 3 lines
Jason
Quoted 6 lines · Leon Romanovsky
Quoted 5 lines · Jason Gunthorpe
Quoted 3 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
The UMR XLT buffer needs to be aligned to
PAGE_SIZE.
Quoted 8 lines
Quoted 3 lines
Why? It goes into a sgl? The device certainly does not work on
PAGE_SIZE, so if there is some alignment here it should be the MLX5 adaptor alignmentWe need an alignment to 2Kb as a minimum here.
In our case, we got the following assert:
‘mlx5_post_send_umr: assertion failed (MLX5_GET64(umr_pointer_desc_argument, data, address)& 0×7ff == 0)’
So use that value, or the adaptor page size
There is no reason to align this to 64k if we need a 2k only.
Jason
Quoted 1 line · Leon Romanovsky
The UMR XLT buffer needs to be aligned to
PAGE_SIZE.
Applied, thanks!
[1/1] RDMA/mlx5: Make sure that UMR page is aligned to PAGE_SIZE
https://git.kernel.org/rdma/rdma/c/c715007b21a4f6
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>