Skip to contentSkip to conversation

rcu: Remove unused rdp parameter from rcu_check_gp_start_stall()

PATCH New Zqiang 1 participant 1 message Jul 22 RCU

lore
Share & tools
lore

Zqiang

author reviewer
#0 lore raw

PATCH 1/1 rcu: Remove unused rdp parameter from rcu_check_gp_start_stall()

The rcu_check_gp_start_stall() works entirely on rnp parameter, and never uses it's rdp parameter. this commit therefore drop it, updating both callers and the declaration.

No functional change.

---
 kernel/rcu/tree.c       | 2 +-
 kernel/rcu/tree.h       | 3 +--
 kernel/rcu/tree_stall.h | 5 ++---
 3 files changed, 4 insertions(+), 6 deletions(-)
kernel/rcu/tree.c +1 -1
index 27104edace0b..4bb7e9ca5ab7 100644
@@ -2911,7 +2911,7 @@ static __latent_entropy void rcu_core(void)
 			rcu_accelerate_cbs_unlocked(rnp, rdp);
 	}
 
-	rcu_check_gp_start_stall(rnp, rdp, rcu_jiffies_till_stall_check());
+	rcu_check_gp_start_stall(rnp, rcu_jiffies_till_stall_check());
 
 	/* If there are callbacks ready, invoke them. */
 	if (!rcu_rdp_is_offloaded(rdp) && rcu_segcblist_ready_cbs(&rdp->cblist) &&
kernel/rcu/tree.h +1 -2
index 9b85eeaa0071..eedfa43059e8 100644
@@ -545,8 +545,7 @@ static bool rcu_nohz_full_cpu(void);
 static void record_gp_stall_check_time(void);
 static void rcu_iw_handler(struct irq_work *iwp);
 static void check_cpu_stall(struct rcu_data *rdp);
-static void rcu_check_gp_start_stall(struct rcu_node *rnp, struct rcu_data *rdp,
-				     const unsigned long gpssdelay);
+static void rcu_check_gp_start_stall(struct rcu_node *rnp, const unsigned long gpssdelay);
 
 /* Forward declarations for tree_exp.h. */
 static void sync_rcu_do_polled_gp(struct work_struct *wp);
kernel/rcu/tree_stall.h +2 -3
index 45b9856ccd2b..02684dadb4ee 100644
@@ -998,8 +998,7 @@ EXPORT_SYMBOL_GPL(show_rcu_gp_kthreads);
  * This function checks for grace-period requests that fail to motivate
  * RCU to come out of its idle mode.
  */
-static void rcu_check_gp_start_stall(struct rcu_node *rnp, struct rcu_data *rdp,
-				     const unsigned long gpssdelay)
+static void rcu_check_gp_start_stall(struct rcu_node *rnp, const unsigned long gpssdelay)
 {
 	unsigned long flags;
 	unsigned long j;
@@ -1074,7 +1073,7 @@ void rcu_fwd_progress_check(unsigned long j)
 			__func__, jiffies - data_race(READ_ONCE(rcu_state.gp_end)));
 		preempt_disable();
 		rdp = this_cpu_ptr(&rcu_data);
-		rcu_check_gp_start_stall(rdp->mynode, rdp, j);
+		rcu_check_gp_start_stall(rdp->mynode, j);
 		preempt_enable();
 	}
 	for_each_possible_cpu(cpu) {
Signature · 1 line
2.17.1