s390/bpf: Support load-acquire and store-release instructions
Subsystems (5)
cover s390/bpf: Support load-acquire and store-release instructions
Support load-acquire (BPF_LOAD_ACQ) and store-release (BPF_STORE_REL) instructions. Since s390 has strong memory model, implement them as regular BPF_LDX/BPF_STX instructions.
Maxim Khmelevskii (3):
s390/bpf: Add emit_ldx and emit_stx functions s390/bpf: Support load-acquire and store-release instructions s390/bpf: Enable atomics tests for s390
arch/s390/net/bpf_jit_comp.c | 198 ++++++++++-------- .../selftests/bpf/progs/arena_atomics.c | 18 +- tools/testing/selftests/bpf/progs/bpf_misc.h | 9 +- 3 files changed, 123 insertions(+), 102 deletions(-)
Signature · 1 line
2.55.0
PATCH 1/3 s390/bpf: Add emit_ldx and emit_stx functions
Add new functions for load and store to reuse
them in the load-acquire and store-release logic.
--- arch/s390/net/bpf_jit_comp.c | 167 +++++++++++++++++------------------ 1 file changed, 82 insertions(+), 85 deletions(-)
arch/s390/net/bpf_jit_comp.c +82 -85
@@ -830,6 +830,72 @@ static int bpf_jit_probe_post(struct bpf_jit *jit, struct bpf_prog *fp,return 0 ; } +static int emit_ldx (struct bpf_jit *jit,struct bpf_prog *fp,struct bpf_insn *insn) +{ +struct bpf_jit_probe probe; + +bpf_jit_probe_init (&probe); +bpf_jit_probe_load_pre (jit, insn, &probe); + +switch (BPF_SIZE (insn->code)) { +case BPF_B :/* dst = *(u8 *)(ul) (src + off) */ +/* llgc %dst,off(%src,%arena) */ +EMIT6_DISP_LH (0xe3000000 ,0x0090 , insn->dst_reg, insn->src_reg, + probe.arena_reg, insn->off); +break ; +case BPF_H :/* dst = *(u16 *)(ul) (src + off) */ +/* llgh %dst,off(%src,%arena) */ +EMIT6_DISP_LH (0xe3000000 ,0x0091 , insn->dst_reg, insn->src_reg, + probe.arena_reg, insn->off); +break ; +case BPF_W :/* dst = *(u32 *)(ul) (src + off) */ +/* llgf %dst,off(%src,%arena) */ +EMIT6_DISP_LH (0xe3000000 ,0x0016 , insn->dst_reg, insn->src_reg, + probe.arena_reg, insn->off); +break ; +case BPF_DW :/* dst = *(u64 *)(ul) (src + off) */ +/* lg %dst,off(%src,%arena) */ +EMIT6_DISP_LH (0xe3000000 ,0x0004 , insn->dst_reg, insn->src_reg, + probe.arena_reg, insn->off); +break ; + } + +return bpf_jit_probe_post (jit, fp, &probe); +} + +static int emit_stx (struct bpf_jit *jit,struct bpf_prog *fp,struct bpf_insn *insn) +{ +struct bpf_jit_probe probe; + +bpf_jit_probe_init (&probe); +bpf_jit_probe_store_pre (jit, insn, &probe); + +switch (BPF_SIZE (insn->code)) { +case BPF_B :/* *(u8 *)(dst + off) = src_reg */ +/* stcy %src,off(%dst,%arena) */ +EMIT6_DISP_LH (0xe3000000 ,0x0072 , insn->src_reg, insn->dst_reg, + probe.arena_reg, insn->off); +break ; +case BPF_H :/* (u16 *)(dst + off) = src */ +/* sthy %src,off(%dst,%arena) */ +EMIT6_DISP_LH (0xe3000000 ,0x0070 , insn->src_reg, insn->dst_reg, + probe.arena_reg, insn->off); +break ; +case BPF_W :/* *(u32 *)(dst + off) = src */ +/* sty %src,off(%dst,%arena) */ +EMIT6_DISP_LH (0xe3000000 ,0x0050 , insn->src_reg, insn->dst_reg, + probe.arena_reg, insn->off); +break ; +case BPF_DW :/* (u64 *)(dst + off) = src */ +/* stg %src,off(%dst,%arena) */ +EMIT6_DISP_LH (0xe3000000 ,0x0024 , insn->src_reg, insn->dst_reg, + probe.arena_reg, insn->off); +break ; + } + +return bpf_jit_probe_post (jit, fp, &probe); +} +/* * Sign- or zero-extend the register if necessary */
@@ -1477,44 +1543,13 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,*/ case BPF_STX |BPF_MEM |BPF_B :/* *(u8 *)(dst + off) = src_reg */ case BPF_STX |BPF_PROBE_MEM32 |BPF_B : -bpf_jit_probe_store_pre (jit, insn, &probe); -/* stcy %src,off(%dst,%arena) */ -EMIT6_DISP_LH (0xe3000000 ,0x0072 , src_reg, dst_reg, - probe.arena_reg, off); - err =bpf_jit_probe_post (jit, fp, &probe); -if (err <0 ) -return err; - jit->seen |=SEEN_MEM ; -break ;case BPF_STX |BPF_MEM |BPF_H :/* (u16 *)(dst + off) = src */ case BPF_STX |BPF_PROBE_MEM32 |BPF_H : -bpf_jit_probe_store_pre (jit, insn, &probe); -/* sthy %src,off(%dst,%arena) */ -EMIT6_DISP_LH (0xe3000000 ,0x0070 , src_reg, dst_reg, - probe.arena_reg, off); - err =bpf_jit_probe_post (jit, fp, &probe); -if (err <0 ) -return err; - jit->seen |=SEEN_MEM ; -break ;case BPF_STX |BPF_MEM |BPF_W :/* *(u32 *)(dst + off) = src */ case BPF_STX |BPF_PROBE_MEM32 |BPF_W : -bpf_jit_probe_store_pre (jit, insn, &probe); -/* sty %src,off(%dst,%arena) */ -EMIT6_DISP_LH (0xe3000000 ,0x0050 , src_reg, dst_reg, - probe.arena_reg, off); - err =bpf_jit_probe_post (jit, fp, &probe); -if (err <0 ) -return err; - jit->seen |=SEEN_MEM ; -break ;case BPF_STX |BPF_MEM |BPF_DW :/* (u64 *)(dst + off) = src */ case BPF_STX |BPF_PROBE_MEM32 |BPF_DW : -bpf_jit_probe_store_pre (jit, insn, &probe); -/* stg %src,off(%dst,%arena) */ -EMIT6_DISP_LH (0xe3000000 ,0x0024 , src_reg, dst_reg, - probe.arena_reg, off); - err =bpf_jit_probe_post (jit, fp, &probe); + err =emit_stx (jit, fp, insn);if (err <0 )return err; jit->seen |=SEEN_MEM ;
@@ -1574,8 +1609,12 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,/* * BPF_ATOMIC */ +case BPF_STX |BPF_ATOMIC |BPF_B : +case BPF_STX |BPF_ATOMIC |BPF_H :case BPF_STX |BPF_ATOMIC |BPF_DW :case BPF_STX |BPF_ATOMIC |BPF_W : +case BPF_STX |BPF_PROBE_ATOMIC |BPF_B : +case BPF_STX |BPF_PROBE_ATOMIC |BPF_H :case BPF_STX |BPF_PROBE_ATOMIC |BPF_DW :case BPF_STX |BPF_PROBE_ATOMIC |BPF_W : {
@@ -1687,15 +1726,20 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,case BPF_LDX |BPF_MEM |BPF_B :/* dst = *(u8 *)(ul) (src + off) */ case BPF_LDX |BPF_PROBE_MEM |BPF_B :case BPF_LDX |BPF_PROBE_MEM32 |BPF_B : -bpf_jit_probe_load_pre (jit, insn, &probe); -/* llgc %dst,off(%src,%arena) */ -EMIT6_DISP_LH (0xe3000000 ,0x0090 , dst_reg, src_reg, - probe.arena_reg, off); - err =bpf_jit_probe_post (jit, fp, &probe); +case BPF_LDX |BPF_MEM |BPF_H :/* dst = *(u16 *)(ul) (src + off) */ +case BPF_LDX |BPF_PROBE_MEM |BPF_H : +case BPF_LDX |BPF_PROBE_MEM32 |BPF_H : +case BPF_LDX |BPF_MEM |BPF_W :/* dst = *(u32 *)(ul) (src + off) */ +case BPF_LDX |BPF_PROBE_MEM |BPF_W : +case BPF_LDX |BPF_PROBE_MEM32 |BPF_W : +case BPF_LDX |BPF_MEM |BPF_DW :/* dst = *(u64 *)(ul) (src + off) */ +case BPF_LDX |BPF_PROBE_MEM |BPF_DW : +case BPF_LDX |BPF_PROBE_MEM32 |BPF_DW : + err =emit_ldx (jit, fp, insn);if (err <0 )return err; jit->seen |=SEEN_MEM ; -if (insn_is_zext (&insn[1 ])) +if (BPF_SIZE (insn->code) !=BPF_DW &&insn_is_zext (&insn[1 ])) insn_count =2 ;break ;case BPF_LDX |BPF_MEMSX |BPF_B :/* dst = *(s8 *)(ul) (src + off) */
@@ -1708,20 +1752,6 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,return err; jit->seen |=SEEN_MEM ;break ; -case BPF_LDX |BPF_MEM |BPF_H :/* dst = *(u16 *)(ul) (src + off) */ -case BPF_LDX |BPF_PROBE_MEM |BPF_H : -case BPF_LDX |BPF_PROBE_MEM32 |BPF_H : -bpf_jit_probe_load_pre (jit, insn, &probe); -/* llgh %dst,off(%src,%arena) */ -EMIT6_DISP_LH (0xe3000000 ,0x0091 , dst_reg, src_reg, - probe.arena_reg, off); - err =bpf_jit_probe_post (jit, fp, &probe); -if (err <0 ) -return err; - jit->seen |=SEEN_MEM ; -if (insn_is_zext (&insn[1 ])) - insn_count =2 ; -break ;case BPF_LDX |BPF_MEMSX |BPF_H :/* dst = *(s16 *)(ul) (src + off) */ case BPF_LDX |BPF_PROBE_MEMSX |BPF_H :bpf_jit_probe_load_pre (jit, insn, &probe);
@@ -1732,20 +1762,6 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,return err; jit->seen |=SEEN_MEM ;break ; -case BPF_LDX |BPF_MEM |BPF_W :/* dst = *(u32 *)(ul) (src + off) */ -case BPF_LDX |BPF_PROBE_MEM |BPF_W : -case BPF_LDX |BPF_PROBE_MEM32 |BPF_W : -bpf_jit_probe_load_pre (jit, insn, &probe); -/* llgf %dst,off(%src) */ - jit->seen |=SEEN_MEM ; -EMIT6_DISP_LH (0xe3000000 ,0x0016 , dst_reg, src_reg, - probe.arena_reg, off); - err =bpf_jit_probe_post (jit, fp, &probe); -if (err <0 ) -return err; -if (insn_is_zext (&insn[1 ])) - insn_count =2 ; -break ;case BPF_LDX |BPF_MEMSX |BPF_W :/* dst = *(s32 *)(ul) (src + off) */ case BPF_LDX |BPF_PROBE_MEMSX |BPF_W :bpf_jit_probe_load_pre (jit, insn, &probe);
@@ -1756,18 +1772,6 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,if (err <0 )return err;break ; -case BPF_LDX |BPF_MEM |BPF_DW :/* dst = *(u64 *)(ul) (src + off) */ -case BPF_LDX |BPF_PROBE_MEM |BPF_DW : -case BPF_LDX |BPF_PROBE_MEM32 |BPF_DW : -bpf_jit_probe_load_pre (jit, insn, &probe); -/* lg %dst,off(%src,%arena) */ - jit->seen |=SEEN_MEM ; -EMIT6_DISP_LH (0xe3000000 ,0x0004 , dst_reg, src_reg, - probe.arena_reg, off); - err =bpf_jit_probe_post (jit, fp, &probe); -if (err <0 ) -return err; -break ;/* * BPF_JMP / CALL */
@@ -3028,13 +3032,6 @@ bool bpf_jit_supports_insn(struct bpf_insn *insn, bool in_arena)if (!in_arena)return true;switch (insn->code) { -case BPF_STX |BPF_ATOMIC |BPF_B : -case BPF_STX |BPF_ATOMIC |BPF_H : -case BPF_STX |BPF_ATOMIC |BPF_W : -case BPF_STX |BPF_ATOMIC |BPF_DW : -if (bpf_atomic_is_load_store (insn)) -return false; -break ;case BPF_LDX |BPF_MEMSX |BPF_B :case BPF_LDX |BPF_MEMSX |BPF_H :case BPF_LDX |BPF_MEMSX |BPF_W :
Signature · 1 line
2.55.0
PATCH 2/3 s390/bpf: Support load-acquire and store-release instructions
In reply to Maxim KhmelevskiiSupport load-acquire (BPF_LOAD_ACQ) and store-release (BPF_STORE_REL) instructions. Since s390 has strong memory model, implement them as regular BPF_LDX/BPF_STX instructions.
Tested with:
./test_progs -t verifier_load_acquire,verifier_store_release,atomics
--- arch/s390/net/bpf_jit_comp.c | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-)
arch/s390/net/bpf_jit_comp.c +23 -8
@@ -743,10 +743,12 @@ static void bpf_jit_probe_load_pre(struct bpf_jit *jit, struct bpf_insn *insn, {if (BPF_MODE (insn->code) !=BPF_PROBE_MEM &&BPF_MODE (insn->code) !=BPF_PROBE_MEMSX && -BPF_MODE (insn->code) !=BPF_PROBE_MEM32 ) +BPF_MODE (insn->code) !=BPF_PROBE_MEM32 && +BPF_MODE (insn->code) !=BPF_PROBE_ATOMIC )return ; -if (BPF_MODE (insn->code) ==BPF_PROBE_MEM32 ) { +if (BPF_MODE (insn->code) ==BPF_PROBE_MEM32 || +BPF_MODE (insn->code) ==BPF_PROBE_ATOMIC ) {/* lgrl %r1,kern_arena */ EMIT6_PCREL_RILB (0xc4080000 ,REG_W1 , jit->kern_arena); probe->arena_reg =REG_W1 ;
@@ -758,7 +760,8 @@ static void bpf_jit_probe_load_pre(struct bpf_jit *jit, struct bpf_insn *insn,static void bpf_jit_probe_store_pre (struct bpf_jit *jit,struct bpf_insn *insn,struct bpf_jit_probe *probe) { -if (BPF_MODE (insn->code) !=BPF_PROBE_MEM32 ) +if (BPF_MODE (insn->code) !=BPF_PROBE_MEM32 && +BPF_MODE (insn->code) !=BPF_PROBE_ATOMIC )return ;/* lgrl %r1,kern_arena */
@@ -1621,11 +1624,11 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,bool is32 =BPF_SIZE (insn->code) ==BPF_W ;/* -* Unlike loads and stores, atomics have only a base register, -* but no index register. For the non-arena case, simply use -* %dst as a base. For the arena case, use the work register -* %r1: first, load the arena base into it, and then add %dst -* to it. +* Unlike loads and stores, s390 atomics have only a base +* register, but no index register. For the non-arena case, +* simply use %dst as a base. For the arena case, use the +* work register %r1: first, load the arena base into it, +* and then add %dst to it. */ probe.arena_reg = dst_reg;
@@ -1712,6 +1715,18 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,if (err <0 )return err;break ; +case BPF_LOAD_ACQ : +/* s390 has strong ordering, just use load */ + err =emit_ldx (jit, fp, insn); +if (err <0 ) +return err; +break ; +case BPF_STORE_REL : +/* s390 has strong ordering, just use store */ + err =emit_stx (jit, fp, insn); +if (err <0 ) +return err; +break ;default :pr_err ("Unknown atomic operation %02x\n" , insn->imm);return -1 ;
Signature · 1 line
2.55.0
PATCH 3/3 s390/bpf: Enable atomics tests for s390
In reply to Maxim KhmelevskiiAdd s390 to the if statement, that defines CAN_USE_LOAD_ACQ_STORE_REL. Reuse CAN_USE_LOAD_ACQ_STORE_REL in arena_atomics selftest, to remove code duplication.
--- .../selftests/bpf/progs/arena_atomics.c | 18 ++++++++++++------ tools/testing/selftests/bpf/progs/bpf_misc.h | 9 ++++++--- 2 files changed, 18 insertions(+), 9 deletions(-)
tools/testing/selftests/bpf/progs/arena_atomics.c +12 -6
@@ -28,8 +28,10 @@ bool skip_all_tests = true;#if defined(ENABLE_ATOMICS_TESTS ) && \ defined(__BPF_FEATURE_ADDR_SPACE_CAST) && \ - (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86) || \ - (defined(__TARGET_ARCH_riscv) && __riscv_xlen ==64 )) + (defined(__TARGET_ARCH_arm64) || \ + defined(__TARGET_ARCH_x86) || \ + (defined(__TARGET_ARCH_riscv) && __riscv_xlen ==64 ) || \ + defined(__TARGET_ARCH_s390)) bool skip_lacq_srel_tests __attribute((__section__(".data"))) = false;#else bool skip_lacq_srel_tests = true;
@@ -315,8 +317,10 @@ int load_acquire(const void *ctx) {#if defined(ENABLE_ATOMICS_TESTS ) && \ defined(__BPF_FEATURE_ADDR_SPACE_CAST) && \ - (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86) || \ - (defined(__TARGET_ARCH_riscv) && __riscv_xlen ==64 )) + (defined(__TARGET_ARCH_arm64) || \ + defined(__TARGET_ARCH_x86) || \ + (defined(__TARGET_ARCH_riscv) && __riscv_xlen ==64 ) || \ + defined(__TARGET_ARCH_s390))#define LOAD_ACQUIRE_ARENA (SIZEOP ,SIZE ,SRC ,DST ) \ { asm volatile ( \
@@ -367,8 +371,10 @@ int store_release(const void *ctx) {#if defined(ENABLE_ATOMICS_TESTS ) && \ defined(__BPF_FEATURE_ADDR_SPACE_CAST) && \ - (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86) || \ - (defined(__TARGET_ARCH_riscv) && __riscv_xlen ==64 )) + (defined(__TARGET_ARCH_arm64) || \ + defined(__TARGET_ARCH_x86) || \ + (defined(__TARGET_ARCH_riscv) && __riscv_xlen ==64 ) || \ + defined(__TARGET_ARCH_s390))#define STORE_RELEASE_ARENA (SIZEOP ,DST ,VAL ) \ { asm volatile ( \
tools/testing/selftests/bpf/progs/bpf_misc.h +6 -3
@@ -264,9 +264,12 @@#endif #if __clang_major__ >=18 && defined(ENABLE_ATOMICS_TESTS ) && \ - (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86) || \ - (defined(__TARGET_ARCH_riscv) && __riscv_xlen ==64 ) || \ - defined(__TARGET_ARCH_powerpc) || defined(__TARGET_ARCH_loongarch)) + (defined(__TARGET_ARCH_arm64) || \ + defined(__TARGET_ARCH_x86) || \ + (defined(__TARGET_ARCH_riscv) && __riscv_xlen ==64 ) || \ + defined(__TARGET_ARCH_s390) || \ + defined(__TARGET_ARCH_powerpc) || \ + defined(__TARGET_ARCH_loongarch))#define CAN_USE_LOAD_ACQ_STORE_REL #endif
Signature · 1 line
2.55.0
[email protected]
AI reviewRe: [PATCH bpf-next 3/3] s390/bpf: Enable atomics tests for s390
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Meaningful code and commit message mismatch: failure to reuse CAN_USE_LOAD_ACQ_STORE_REL in…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Meaningful code and commit message mismatch: failure to reuse CAN_USE_LOAD_ACQ_STORE_REL in arena_atomics.c. --
--- Patch [3]: [PATCH bpf-next 3/3] s390/bpf: Enable atomics tests for s390 --- commit c1e0ed2dde3c2d83049962c67b540464ea7a24d3
Author: Maxim Khmelevskii <[email protected]>
s390/bpf: Enable atomics tests for s390
This commit adds s390 to the list of supported architectures for atomics tests and updates CAN_USE_LOAD_ACQ_STORE_REL in bpf_misc.h.
Quoted 2 lines
Reuse
CAN_USE_LOAD_ACQ_STORE_RELinarena_atomicsselftest, to remove code duplication.
[Severity: Medium]
Is this description accurate for the changes actually made in arena_atomics.c?
Quoted 5 lines
tools/testing/selftests/bpf/progs/arena_atomics.c +0
-0
tools/testing/selftests/bpf/progs/arena_atomics.c bool skip_all_tests = true; · line 34
Quoted 9 lines
tools/testing/selftests/bpf/progs/arena_atomics.c +4
-2@@ -28,8 +28,10 @@ bool skip_all_tests = true;#if defined(ENABLE_ATOMICS_TESTS ) && \ defined(__BPF_FEATURE_ADDR_SPACE_CAST) && \ - (defined(__TARGET_ARCH_arm64) || defined(__TARGET_ARCH_x86) || \ - (defined(__TARGET_ARCH_riscv) && __riscv_xlen ==64 )) + (defined(__TARGET_ARCH_arm64) || \ + defined(__TARGET_ARCH_x86) || \ + (defined(__TARGET_ARCH_riscv) && __riscv_xlen ==64 ) || \ + defined(__TARGET_ARCH_s390))
[Severity: Medium]
Could this #if block use CAN_USE_LOAD_ACQ_STORE_REL as mentioned in the commit message, instead of manually expanding the architecture list?
By not using the macro, it appears that powerpc and loongarch support defined in bpf_misc.h are omitted in these checks. This manual expansion also seems to be duplicated in load_acquire() and store_release() later in the patch.
[ ... ]
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
[email protected]
AI reviewRe: [PATCH bpf-next 1/3] s390/bpf: Add emit_ldx and emit_stx functions
In reply to Maxim KhmelevskiiThis isn't a bug, but the changelog describes the commit only as adding the emit_ldx()/emit_stx() helpers for reuse, while the diff also makes a couple of functional changes that aren't mentioned.
Quoted 7 lines
s390/bpf: Add
emit_ldxandemit_stxfunctionsAdd new functions for load and store to reuse
them in the load-acquire and store-release logic.Reviewed-by Ilya Leoshkevich <[email protected]>Signed-off-by Maxim Khmelevskii <[email protected]>
This isn't a bug, but the changelog describes the commit only as adding the emit_ldx()/emit_stx() helpers for reuse, while the diff also makes a couple of functional changes that aren't mentioned.
It drops the arena atomic load/store rejection from bpf_jit_supports_insn():
switch (insn->code) {
case BPF_STX | BPF_ATOMIC | BPF_B:
case BPF_STX | BPF_ATOMIC | BPF_H:
case BPF_STX | BPF_ATOMIC | BPF_W:
case BPF_STX | BPF_ATOMIC | BPF_DW:
if (bpf_atomic_is_load_store(insn))
return false;
break;
and it adds new case labels to the BPF_ATOMIC switch in bpf_jit_insn():
case BPF_STX | BPF_ATOMIC | BPF_B: case BPF_STX | BPF_ATOMIC | BPF_H:
...
case BPF_STX | BPF_PROBE_ATOMIC | BPF_B:
case BPF_STX | BPF_PROBE_ATOMIC | BPF_H:
Would it read more clearly to mention these gating changes in the changelog, or to fold them into the commit that adds the load-acquire/store-release handlers?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/30016652277
This series was applied to bpf/bpf-next.git (master) by Kumar Kartikeya Dwivedi <[email protected]>:
Hello:
This series was applied to bpf/bpf-next.git (master) by Kumar Kartikeya Dwivedi <[email protected]>:
Quoted 10 lines · On Thu, 23 Jul 2026 16:03:48 +0200 you wrote:
Support load-acquire (
BPF_LOAD_ACQ) and store-release (BPF_STORE_REL) instructions. Since s390 has strong memory model, implement them as regular BPF_LDX/BPF_STX instructions.Maxim Khmelevskii (3):
s390/bpf: Addemit_ldxandemit_stxfunctions s390/bpf: Support load-acquire and store-release instructions s390/bpf: Enable atomics tests for s390[...]
Here is the summary with links:
- [bpf-next,1/3] s390/bpf: Add emit_ldx and emit_stx functions
https://git.kernel.org/bpf/bpf-next/c/2d7f576c9d83 - [bpf-next,2/3] s390/bpf: Support load-acquire and store-release instructions https://git.kernel.org/bpf/bpf-next/c/898343edde47 - [bpf-next,3/3] s390/bpf: Enable atomics tests for s390 https://git.kernel.org/bpf/bpf-next/c/2925f8deeade
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html