crypto: qce - fix error path in devm_qce_register_algs
PATCH 1/1 crypto: qce - fix error path in devm_qce_register_algs
If ops->register_algs() fails, the error path repeatedly calls the same ops->unregister_algs() from the failed registration. Use the loop index to unregister the previously registered algorithms instead.
Fixes e80cf84b6087 ("crypto: qce - unregister previously registered algos in error path")
Signed-off-by Thorsten Blum <[email protected]>
--- drivers/crypto/qce/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/qce/core.c +1 -1
@@ -58,7 +58,7 @@ static int devm_qce_register_algs(struct qce_device *qce) ret = ops->register_algs (qce);if (ret) {for (j = i -1 ; j >=0 ; j--) - ops->unregister_algs (qce); + qce_ops[j]->unregister_algs (qce);return ret; } }
Quoted 17 lines · Thorsten Blum
If
ops->register_algs()fails, the error path repeatedly calls the sameops->unregister_algs()from the failed registration. Use the loop index to unregister the previously registered algorithms instead.Fixes e80cf84b6087 ("crypto: qce - unregister previously registered algos in error path")Signed-off-by Thorsten Blum <[email protected]>--- drivers/crypto/qce/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/crypto/qce/core.c +0
-0
drivers/crypto/qce/core.c static int devm_qce_register_algs(struct qce_device *qce) · line 64
Quoted 8 lines
drivers/crypto/qce/core.c +1
-1@@ -58,7 +58,7 @@ static int devm_qce_register_algs(struct qce_device *qce) ret = ops->register_algs (qce);if (ret) {for (j = i -1 ; j >=0 ; j--) - ops->unregister_algs (qce); + qce_ops[j]->unregister_algs (qce);return ret; } }
Reviewed-by Bartosz Golaszewski <[email protected]>