Skip to contentSkip to conversation

riscv: dts: sophgo: Add Milk-V Duo 256M board support

PATCH Applied Chen-Yu Yeh 2 participants 5 messages Jul 25 – Jul 29

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v5 cover riscv: dts: sophgo: Add Milk-V Duo 256M board support

The Milk-V Duo 256M is a small form factor development board based on the Sophgo SG2002 SoC.

This series adds the board binding, the PWR_GPIO controller node for the CV180x/CV181x family, and the board device tree with support for the UART console, SD/MMC, USB host and the onboard blue status LED.

Tested on actual Milk-V Duo 256M hardware: verified boot to shell, SD card rootfs mount, USB host (root hub detected) and the heartbeat LED, both via the default heartbeat trigger and manual sysfs control.

A U-Boot series adding support for the same board [0] refers to this series as the canonical device tree, and intends to switch to the upstream kernel DT once this lands.

[0] https://lore.kernel.org/u-boot/[email protected]/

Changes since v4:
- Fix the coprocessor RTOS reserved region in the board dts. v4 carried over the address from the 64M Duo (0x83f40000/0xc0000), which sits at the top of 64MB and is wrong for this board. The vendor device tree passed by the bootloader declares memory as <0x80000000 0x0fe00000>, i.e. the firmware keeps the top 2MB of the 256MB DRAM for the RTOS, so the region is 0x8fe00000/0x200000. This matches cv1812h-huashan-pi, which has the same amount of DRAM. Verified on hardware:

OF: reserved mem: 0x000000008fe00000..0x000000008fffffff (2048 KiB)
nomap non-reusable region@8fe00000

(Reported by sashiko-bot)

Changes since v3:
- Move the pwr_gpio node in cv180x.dtsi to follow unit-address ordering, placing it between usb@4340000 and rtc@5025000 (Inochi Amaoto)

Changes since v2:
- Add the PWR_GPIO (porte) controller node to cv180x.dtsi as a new patch, instead of dropping the LED node (Inochi Amaoto)
- Restore the gpio-leds node for the onboard blue status LED
- Add my copyright to the new board dts
- Drop the unrelated Makefile trailing-newline change

Changes since v1:
- Removed the leds node because &porte was not supported in cv180x.dtsi (reworked in v3)
- Retained the &usb node because it is already defined in cv180x.dtsi

Chen-Yu Yeh (3):
dt-bindings: soc: sophgo: add Milk-V Duo 256M board
riscv: dts: sophgo: cv180x: Add PWR_GPIO controller
riscv: dts: sophgo: Add Milk-V Duo 256M board support

 .../bindings/soc/sophgo/sophgo.yaml           |   4 +
 arch/riscv/boot/dts/sophgo/Makefile           |   1 +
 arch/riscv/boot/dts/sophgo/cv180x.dtsi        |  18 +++
 .../boot/dts/sophgo/sg2002-milkv-duo256m.dts  | 121 ++++++++++++++++++
 4 files changed, 144 insertions(+)
 create mode 100644 arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts
Signature · 1 line
2.43.0
#1 lore raw

PATCH v5 1/3 dt-bindings: soc: sophgo: add Milk-V Duo 256M board

Add compatible string for the Milk-V Duo 256M board.

---
 Documentation/devicetree/bindings/soc/sophgo/sophgo.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/soc/sophgo/sophgo.yaml +4 -0
index 0b6fbab48b74..99194d8721ef 100644
@@ -35,6 +35,10 @@ properties:
           - enum:
               - milkv,duo-s
           - const: sophgo,sg2000
+      - items:
+          - enum:
+              - milkv,duo256m
+          - const: sophgo,sg2002
       - items:
           - enum:
               - sipeed,licheerv-nano-b
Signature · 1 line
2.43.0
#2 lore raw

PATCH v5 2/3 riscv: dts: sophgo: cv180x: Add PWR_GPIO controller

In reply to Chen-Yu Yeh

The CV180x/CV181x family has an additional DesignWare APB GPIO controller (PWR_GPIO) located in the always-on power domain at 0x5021000. Add the node so that boards can reference GPIOs in this bank, such as status LEDs.

---
 arch/riscv/boot/dts/sophgo/cv180x.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/riscv/boot/dts/sophgo/cv180x.dtsi +18 -0
index 06b0ce5a2db7..8bf67ee4eca5 100644
@@ -448,6 +448,24 @@ usb: usb@4340000 {
 			status = "disabled";
 		};
 
+		gpio4: gpio@5021000 {
+			compatible = "snps,dw-apb-gpio";
+			reg = <0x5021000 0x1000>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			porte: gpio-controller@0 {
+				compatible = "snps,dw-apb-gpio-port";
+				gpio-controller;
+				#gpio-cells = <2>;
+				ngpios = <32>;
+				reg = <0>;
+				interrupt-controller;
+				#interrupt-cells = <2>;
+				interrupts = <SOC_PERIPHERAL_IRQ(54) IRQ_TYPE_LEVEL_HIGH>;
+			};
+		};
+
 		rtc@5025000 {
 			compatible = "sophgo,cv1800b-rtc", "syscon";
 			reg = <0x5025000 0x2000>;
Signature · 1 line
2.43.0
#3 lore raw

PATCH v5 3/3 riscv: dts: sophgo: Add Milk-V Duo 256M board support

In reply to Chen-Yu Yeh

The Milk-V Duo 256M is a small form factor development board based on the Sophgo SG2002 SoC.

This patch adds basic device tree support for the board, including:
- UART console
- SD/MMC controller
- USB host
- Onboard blue status LED (connected to PWR_GPIO[2] / porte 2)

Tested on actual Milk-V Duo 256M hardware, verified boot to shell and heartbeat LED functionality.

---
 arch/riscv/boot/dts/sophgo/Makefile           |   1 +
 .../boot/dts/sophgo/sg2002-milkv-duo256m.dts  | 121 ++++++++++++++++++
 2 files changed, 122 insertions(+)
 create mode 100644 arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts
arch/riscv/boot/dts/sophgo/Makefile +1 -0
index 6f65526d4193..1ff69cf7f178 100644
@@ -2,6 +2,7 @@
 dtb-$(CONFIG_ARCH_SOPHGO) += cv1800b-milkv-duo.dtb
 dtb-$(CONFIG_ARCH_SOPHGO) += cv1812h-huashan-pi.dtb
 dtb-$(CONFIG_ARCH_SOPHGO) += sg2002-licheerv-nano-b.dtb
+dtb-$(CONFIG_ARCH_SOPHGO) += sg2002-milkv-duo256m.dtb
 dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-milkv-pioneer.dtb
 dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-evb-v1.dtb
 dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-evb-v2.dtb
arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts new file +121 -0

121 lines not on this page · raw message

Signature · 1 line
2.43.0
maintainer Applied
#4 lore raw
In reply to Chen-Yu Yeh
Quoted 8 lines · Chen-Yu Yeh

The Milk-V Duo 256M is a small form factor development board based on the Sophgo SG2002 SoC.

This series adds the board binding, the PWR_GPIO controller node for the CV180x/CV181x family, and the board device tree with support for the UART console, SD/MMC, USB host and the onboard blue status LED.

[...]

Applied to dt/riscv, thanks!

[1/3] dt-bindings: soc: sophgo: add Milk-V Duo 256M board

      https://github.com/sophgo/linux/commit/623a0b16bc3a822742c2793266128f59ba4f847c
[2/3] riscv: dts: sophgo: cv180x: Add PWR_GPIO controller
      https://github.com/sophgo/linux/commit/a625117e6c58cd77e88295e5470a3cc9578e4ad4
[3/3] riscv: dts: sophgo: Add Milk-V Duo 256M board support
      https://github.com/sophgo/linux/commit/11881041b745b444e4f6c87a2748f1951cf02742

Thanks,
Inochi