xfs/842: verify CoW after exchangerange with FILE1_WRITTEN on shared extents
PATCH v2 1/1 xfs/842: verify CoW after exchangerange with FILE1_WRITTEN on shared extents
When a full-file exchangerange is requested with FILE1_WRITTEN for a fully sparse donor file, every mapping pair is skipped, so no extents actually move. However, the kernel decides to swap the reflink inode flag based on the request geometry alone, so the target file used to lose its reflink flag to the donor while still owning shared extents. A subsequent write then took the non-reflink write path and modified the shared physical blocks in place, silently corrupting the other file sharing them:
--- tests/xfs/842.out
+++ results/xfs/842.out.bad
@@ -1,4 +1,5 @@
QA output created by 842
+vX.reflink = 0
vX.reflink = 1
-vX.reflink = 1
+orig changed: md5 e6065c4aa2ab1603008fc18410f579d4 -> 32c5189478e6bafa1cc76423f06c88f2 (write hit shared blocks in place)
Silence is golden
This test clones a file so that both share extents, swaps the clone against a sparse donor with FILE1_WRITTEN, and then checks the defect twice. First it inspects the inodes directly with xfs_db: the clone must still be flagged reflink after the exchange (the donor carrying the flag too is the conservative outcome of the fix and is harmless). Then it writes to the clone and verifies after a mount cycle that the original file's data is intact, i.e. the write was redirected through CoW.
The kernel fix "xfs: fix exchange-range reflink flag clearing issue with INO1_WRITTEN" refuses the reflink flag exchange whenever FILE1_WRITTEN is requested, which makes this test pass.
--- tests/xfs/842 | 65 +++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/842.out | 4 +++ 2 files changed, 69 insertions(+) create mode 100755 tests/xfs/842 create mode 100644 tests/xfs/842.out
tests/xfs/842 new file +65 -0
@@ -0,0 +1,65 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2026 Tencent. All Rights Reserved. +# +# FS QA Test No. 842 +# +# Make sure that a full-file exchangerange under FILE1_WRITTEN does not strip +# the reflink flag from a file that still owns shared extents. When the +# donor file is fully sparse, every mapping pair is skipped, so no extents +# actually move; the target file must keep its reflink flag, and a later +# write must go through CoW instead of modifying the shared blocks in place. + +. ./common/preamble +_begin_fstest auto quick fiexchange + +# Import common functions. +. ./common/filter +. ./common/reflink + +_require_xfs_io_command exchangerange +_require_scratch_reflink +_require_scratch + +_scratch_mkfs >> $seqres.full +_scratch_mount + +# Create the original file with a known pattern and clone it, so that both +# files share the same extents. +_pwrite_byte 0x41 0 1m $SCRATCH_MNT/orig >> $seqres.full +_reflink $SCRATCH_MNT/orig $SCRATCH_MNT/clone >> $seqres.full + +# Create a fully sparse donor file of the same size. +$XFS_IO_PROG -f -c 'truncate 1m' $SCRATCH_MNT/donor + +md5_before=$(md5sum $SCRATCH_MNT/orig | awk '{print $1}') + +# Swap the clone against the sparse donor, claiming the donor is fully +# written (-w). Every donor mapping is a hole, so all pairs are skipped +# and the clone keeps its shared extents in place. +$XFS_IO_PROG -c "exchangerange -f -w $SCRATCH_MNT/donor" $SCRATCH_MNT/clone \ + >> $seqres.full + +# Directly confirm the inode flag state after the exchange: the clone +# must still be flagged reflink. The donor may also carry the flag, which +# is the conservative outcome of refusing the flag exchange under +# FILE1_WRITTEN; the extra flag is harmless and can be dropped later by +# the regular reflink flag cleanup path. +_scratch_unmount +_scratch_xfs_db -c "path /clone" -c print -c "path /donor" -c print | \ + grep reflink | sed -e 's/^v[0-9]*/vX/g' +_scratch_mount + +# Overwrite part of the clone. With the reflink flag correctly retained, +# this must go through CoW and leave the shared blocks of orig untouched. +_pwrite_byte 0x42 0 64k $SCRATCH_MNT/clone >> $seqres.full +_scratch_cycle_mount + +md5_after=$(md5sum $SCRATCH_MNT/orig | awk '{print $1}') + +test "$md5_before" != "$md5_after" && \ + echo "orig changed: md5 $md5_before -> $md5_after (write hit shared blocks in place)" + +echo Silence is golden +status=0 +exit
tests/xfs/842.out new file +4 -0
@@ -0,0 +1,4 @@ +QA output created by 842 +vX.reflink = 1 +vX.reflink = 1 +Silence is golden
Signature · 1 line
2.50.1 (Apple Git-155)
Looks good:
Quoted 28 lines · Lin Jiapeng
When a full-file exchangerange is requested with
FILE1_WRITTENfor a fully sparse donor file, every mapping pair is skipped, so no extents actually move. However, the kernel decides to swap the reflink inode flag based on the request geometry alone, so the target file used to lose its reflink flag to the donor while still owning shared extents. A subsequent write then took the non-reflink write path and modified the shared physical blocks in place, silently corrupting the other file sharing them:--- tests/xfs/842.out
+++ results/xfs/842.out.bad
@@ -1,4 +1,5 @@
QA output created by 842
+vX.reflink = 0
vX.reflink = 1
-vX.reflink = 1
+orig changed: md5e6065c4aa2ab1603008fc18410f579d4->32c5189478e6bafa1cc76423f06c88f2(write hit shared blocks in place)
Silence is goldenThis test clones a file so that both share extents, swaps the clone against a sparse donor with
FILE1_WRITTEN, and then checks the defect twice. First it inspects the inodes directly withxfs_db: the clone must still be flagged reflink after the exchange (the donor carrying the flag too is the conservative outcome of the fix and is harmless). Then it writes to the clone and verifies after a mount cycle that the original file's data is intact, i.e. the write was redirected through CoW.
Quoted 2 lines
The kernel fix "xfs: fix exchange-range reflink flag clearing issue with
INO1_WRITTEN" refuses the reflink flag exchange whenever
So this patch/case uncovers a known bug which is fixed by:
"xfs: fix exchange-range reflink flag clearing issue with INO1_WRITTEN" ?
If so please add:
_fixed_by_fs_commit xfs xxxxxxxxxxxx \
"xfs: fix exchange-range reflink flag clearing issue with INO1_WRITTEN"
Quoted 33 lines
FILE1_WRITTENis requested, which makes this test pass.Suggested-by Christoph Hellwig <[email protected]>Suggested-by "Darrick J. Wong" <[email protected]>Reviewed-by "Darrick J. Wong" <[email protected]>Signed-off-by Lin Jiapeng <[email protected]>--- tests/xfs/842 | 65 +++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/842.out | 4 +++ 2 files changed, 69 insertions(+) create mode 100755 tests/xfs/842 create mode 100644 tests/xfs/842.outtests/xfs/842 new file +12
-0@@ -0,0 +1,65 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2026 Tencent. All Rights Reserved. +# +# FS QA Test No. 842 +# +# Make sure that a full-file exchangerange under FILE1_WRITTEN does not strip +# the reflink flag from a file that still owns shared extents. When the +# donor file is fully sparse, every mapping pair is skipped, so no extents +# actually move; the target file must keep its reflink flag, and a later +# write must go through CoW instead of modifying the shared blocks in place. +
tests/xfs/842 line 22
Quoted 10 lines
tests/xfs/842 new file +10
-0+. ./common/preamble +_begin_fstest auto quick fiexchange + +# Import common functions. +. ./common/filter +. ./common/reflink + +_require_xfs_io_command exchangerange +_require_scratch_reflink +_require_scratch
_require_scratch_reflink contains _require_scratch, so you can save the _require_scratch.
Quoted 31 lines
tests/xfs/842 new file +31
-0+ +_scratch_mkfs >> $seqres.full +_scratch_mount + +# Create the original file with a known pattern and clone it, so that both +# files share the same extents. +_pwrite_byte 0x41 0 1m $SCRATCH_MNT/orig >> $seqres.full +_reflink $SCRATCH_MNT/orig $SCRATCH_MNT/clone >> $seqres.full + +# Create a fully sparse donor file of the same size. +$XFS_IO_PROG -f -c 'truncate 1m' $SCRATCH_MNT/donor + +md5_before=$(md5sum $SCRATCH_MNT/orig | awk '{print $1}') + +# Swap the clone against the sparse donor, claiming the donor is fully +# written (-w). Every donor mapping is a hole, so all pairs are skipped +# and the clone keeps its shared extents in place. +$XFS_IO_PROG -c "exchangerange -f -w $SCRATCH_MNT/donor" $SCRATCH_MNT/clone \ + >> $seqres.full + +# Directly confirm the inode flag state after the exchange: the clone +# must still be flagged reflink. The donor may also carry the flag, which +# is the conservative outcome of refusing the flag exchange under +# FILE1_WRITTEN; the extra flag is harmless and can be dropped later by +# the regular reflink flag cleanup path. +_scratch_unmount +_scratch_xfs_db -c "path /clone" -c print -c "path /donor" -c print | \ + grep reflink | sed -e 's/^v[0-9]*/vX/g' +_scratch_mount + +# Overwrite part of the clone. With the reflink flag correctly retained,
tests/xfs/842 line 63
Quoted 10 lines
tests/xfs/842 new file +10
-0+# this must go through CoW and leave the shared blocks of orig untouched. +_pwrite_byte 0x42 0 64k $SCRATCH_MNT/clone >> $seqres.full +_scratch_cycle_mount + +md5_after=$(md5sum $SCRATCH_MNT/orig | awk '{print $1}') + +test "$md5_before" != "$md5_after" && \ + echo "orig changed: md5 $md5_before -> $md5_after (write hit shared blocks in place)" + +echo Silence is golden
This case has expected output, so it's not "Silence is golden", please remove this line.
tests/xfs/842 line 65
Quoted 2 lines
tests/xfs/842 new file +2
-0+status=0 +exit
I remember we've changed xfstests/new script, it should give "_exit 0" at here.
Thanks,
Zorro
Quoted 13 lines
tests/xfs/842.out new file +4
-0@@ -0,0 +1,4 @@ +QA output created by 842 +vX.reflink = 1 +vX.reflink = 1 +Silence is goldenSignature · 1 line
2.50.1 (Apple Git-155)
Quoted 139 lines · Zorro Lang
Quoted 28 lines · Lin Jiapeng
When a full-file exchangerange is requested with
FILE1_WRITTENfor a fully sparse donor file, every mapping pair is skipped, so no extents actually move. However, the kernel decides to swap the reflink inode flag based on the request geometry alone, so the target file used to lose its reflink flag to the donor while still owning shared extents. A subsequent write then took the non-reflink write path and modified the shared physical blocks in place, silently corrupting the other file sharing them:--- tests/xfs/842.out
+++ results/xfs/842.out.bad
@@ -1,4 +1,5 @@
QA output created by 842
+vX.reflink = 0
vX.reflink = 1
-vX.reflink = 1
+orig changed: md5e6065c4aa2ab1603008fc18410f579d4->32c5189478e6bafa1cc76423f06c88f2(write hit shared blocks in place)
Silence is goldenThis test clones a file so that both share extents, swaps the clone against a sparse donor with
FILE1_WRITTEN, and then checks the defect twice. First it inspects the inodes directly withxfs_db: the clone must still be flagged reflink after the exchange (the donor carrying the flag too is the conservative outcome of the fix and is harmless). Then it writes to the clone and verifies after a mount cycle that the original file's data is intact, i.e. the write was redirected through CoW.Quoted 2 lines
The kernel fix "xfs: fix exchange-range reflink flag clearing issue with
INO1_WRITTEN" refuses the reflink flag exchange wheneverSo this patch/case uncovers a known bug which is fixed by:
"xfs: fix exchange-range reflink flag clearing issue withINO1_WRITTEN" ?If so please add:
_fixed_by_fs_commitxfs xxxxxxxxxxxx \
"xfs: fix exchange-range reflink flag clearing issue withINO1_WRITTEN"Quoted 33 lines
FILE1_WRITTENis requested, which makes this test pass.Suggested-by Christoph Hellwig <[email protected]>Suggested-by "Darrick J. Wong" <[email protected]>Reviewed-by "Darrick J. Wong" <[email protected]>Signed-off-by Lin Jiapeng <[email protected]>--- tests/xfs/842 | 65 +++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/842.out | 4 +++ 2 files changed, 69 insertions(+)create mode 100755 tests/xfs/842
create mode 100644 tests/xfs/842.outtests/xfs/842 new file +12
-0@@ -0,0 +1,65 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2026 Tencent. All Rights Reserved. +# +# FS QA Test No. 842 +# +# Make sure that a full-file exchangerange under FILE1_WRITTEN does not strip +# the reflink flag from a file that still owns shared extents. When the +# donor file is fully sparse, every mapping pair is skipped, so no extents +# actually move; the target file must keep its reflink flag, and a later +# write must go through CoW instead of modifying the shared blocks in place. +tests/xfs/842 line 22
Quoted 10 lines
tests/xfs/842 new file +10
-0+. ./common/preamble +_begin_fstest auto quick fiexchange + +# Import common functions. +. ./common/filter +. ./common/reflink + +_require_xfs_io_command exchangerange +_require_scratch_reflink +_require_scratch
_require_scratch_reflinkcontains_require_scratch, so you can save the_require_scratch.Quoted 31 lines
tests/xfs/842 new file +31
-0+ +_scratch_mkfs >> $seqres.full +_scratch_mount + +# Create the original file with a known pattern and clone it, so that both +# files share the same extents. +_pwrite_byte 0x41 0 1m $SCRATCH_MNT/orig >> $seqres.full +_reflink $SCRATCH_MNT/orig $SCRATCH_MNT/clone >> $seqres.full + +# Create a fully sparse donor file of the same size. +$XFS_IO_PROG -f -c 'truncate 1m' $SCRATCH_MNT/donor + +md5_before=$(md5sum $SCRATCH_MNT/orig | awk '{print $1}') + +# Swap the clone against the sparse donor, claiming the donor is fully +# written (-w). Every donor mapping is a hole, so all pairs are skipped +# and the clone keeps its shared extents in place. +$XFS_IO_PROG -c "exchangerange -f -w $SCRATCH_MNT/donor" $SCRATCH_MNT/clone \ + >> $seqres.full + +# Directly confirm the inode flag state after the exchange: the clone +# must still be flagged reflink. The donor may also carry the flag, which +# is the conservative outcome of refusing the flag exchange under +# FILE1_WRITTEN; the extra flag is harmless and can be dropped later by +# the regular reflink flag cleanup path. +_scratch_unmount +_scratch_xfs_db -c "path /clone" -c print -c "path /donor" -c print | \ + grep reflink | sed -e 's/^v[0-9]*/vX/g' +_scratch_mount + +# Overwrite part of the clone. With the reflink flag correctly retained,tests/xfs/842 line 63
Quoted 10 lines
tests/xfs/842 new file +10
-0+# this must go through CoW and leave the shared blocks of orig untouched. +_pwrite_byte 0x42 0 64k $SCRATCH_MNT/clone >> $seqres.full +_scratch_cycle_mount + +md5_after=$(md5sum $SCRATCH_MNT/orig | awk '{print $1}') + +test "$md5_before" != "$md5_after" && \ + echo "orig changed: md5 $md5_before -> $md5_after (write hit shared blocks in place)" + +echo Silence is goldenThis case has expected output, so it's not "Silence is golden", please remove this line.
tests/xfs/842 line 65
Quoted 2 lines
tests/xfs/842 new file +2
-0+status=0 +exitI remember we've changed xfstests/new script, it should give "
_exit0" at here.Thanks,
Zorro
Quoted 13 lines
Quoted 13 lines
tests/xfs/842.out new file +4
-0@@ -0,0 +1,4 @@ +QA output created by 842 +vX.reflink = 1 +vX.reflink = 1 +Silence is goldenSignature · 1 line
2.50.1 (Apple Git-155)
Thanks a lot for your review!
Yes, this test case uncovers the bug fixed by "xfs: fix exchange-range reflink flag clearing issue with INO1_WRITTEN". However, that fix is still under review on linux-xfs and has not landed in for-next / xfs-7.2-fixes yet, so there is no stable commit ID to reference. I will add the _fixed_by_fs_commit annotation as soon as the fix is merged.
The other comments will be addressed in v4.
Lin Jiapeng
Quoted 158 lines · Lin Jiapeng
Quoted 139 lines · Zorro Lang
Quoted 28 lines · Lin Jiapeng
When a full-file exchangerange is requested with
FILE1_WRITTENfor a fully sparse donor file, every mapping pair is skipped, so no extents actually move. However, the kernel decides to swap the reflink inode flag based on the request geometry alone, so the target file used to lose its reflink flag to the donor while still owning shared extents. A subsequent write then took the non-reflink write path and modified the shared physical blocks in place, silently corrupting the other file sharing them:--- tests/xfs/842.out
+++ results/xfs/842.out.bad
@@ -1,4 +1,5 @@
QA output created by 842
+vX.reflink = 0
vX.reflink = 1
-vX.reflink = 1
+orig changed: md5e6065c4aa2ab1603008fc18410f579d4->32c5189478e6bafa1cc76423f06c88f2(write hit shared blocks in place)
Silence is goldenThis test clones a file so that both share extents, swaps the clone against a sparse donor with
FILE1_WRITTEN, and then checks the defect twice. First it inspects the inodes directly withxfs_db: the clone must still be flagged reflink after the exchange (the donor carrying the flag too is the conservative outcome of the fix and is harmless). Then it writes to the clone and verifies after a mount cycle that the original file's data is intact, i.e. the write was redirected through CoW.Quoted 2 lines
The kernel fix "xfs: fix exchange-range reflink flag clearing issue with
INO1_WRITTEN" refuses the reflink flag exchange wheneverSo this patch/case uncovers a known bug which is fixed by:
"xfs: fix exchange-range reflink flag clearing issue withINO1_WRITTEN" ?If so please add:
_fixed_by_fs_commitxfs xxxxxxxxxxxx \
"xfs: fix exchange-range reflink flag clearing issue withINO1_WRITTEN"Quoted 33 lines
FILE1_WRITTENis requested, which makes this test pass.Suggested-by Christoph Hellwig <[email protected]>Suggested-by "Darrick J. Wong" <[email protected]>Reviewed-by "Darrick J. Wong" <[email protected]>Signed-off-by Lin Jiapeng <[email protected]>--- tests/xfs/842 | 65 +++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/842.out | 4 +++ 2 files changed, 69 insertions(+)create mode 100755 tests/xfs/842
create mode 100644 tests/xfs/842.outtests/xfs/842 new file +12
-0@@ -0,0 +1,65 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2026 Tencent. All Rights Reserved. +# +# FS QA Test No. 842 +# +# Make sure that a full-file exchangerange under FILE1_WRITTEN does not strip +# the reflink flag from a file that still owns shared extents. When the +# donor file is fully sparse, every mapping pair is skipped, so no extents +# actually move; the target file must keep its reflink flag, and a later +# write must go through CoW instead of modifying the shared blocks in place. +tests/xfs/842 line 22
Quoted 10 lines
tests/xfs/842 new file +10
-0+. ./common/preamble +_begin_fstest auto quick fiexchange + +# Import common functions. +. ./common/filter +. ./common/reflink + +_require_xfs_io_command exchangerange +_require_scratch_reflink +_require_scratch
_require_scratch_reflinkcontains_require_scratch, so you can save the_require_scratch.Quoted 31 lines
tests/xfs/842 new file +31
-0+ +_scratch_mkfs >> $seqres.full +_scratch_mount + +# Create the original file with a known pattern and clone it, so that both +# files share the same extents. +_pwrite_byte 0x41 0 1m $SCRATCH_MNT/orig >> $seqres.full +_reflink $SCRATCH_MNT/orig $SCRATCH_MNT/clone >> $seqres.full + +# Create a fully sparse donor file of the same size. +$XFS_IO_PROG -f -c 'truncate 1m' $SCRATCH_MNT/donor + +md5_before=$(md5sum $SCRATCH_MNT/orig | awk '{print $1}') + +# Swap the clone against the sparse donor, claiming the donor is fully +# written (-w). Every donor mapping is a hole, so all pairs are skipped +# and the clone keeps its shared extents in place. +$XFS_IO_PROG -c "exchangerange -f -w $SCRATCH_MNT/donor" $SCRATCH_MNT/clone \ + >> $seqres.full + +# Directly confirm the inode flag state after the exchange: the clone +# must still be flagged reflink. The donor may also carry the flag, which +# is the conservative outcome of refusing the flag exchange under +# FILE1_WRITTEN; the extra flag is harmless and can be dropped later by +# the regular reflink flag cleanup path. +_scratch_unmount +_scratch_xfs_db -c "path /clone" -c print -c "path /donor" -c print | \ + grep reflink | sed -e 's/^v[0-9]*/vX/g' +_scratch_mount + +# Overwrite part of the clone. With the reflink flag correctly retained,tests/xfs/842 line 63
Quoted 10 lines
tests/xfs/842 new file +10
-0+# this must go through CoW and leave the shared blocks of orig untouched. +_pwrite_byte 0x42 0 64k $SCRATCH_MNT/clone >> $seqres.full +_scratch_cycle_mount + +md5_after=$(md5sum $SCRATCH_MNT/orig | awk '{print $1}') + +test "$md5_before" != "$md5_after" && \ + echo "orig changed: md5 $md5_before -> $md5_after (write hit shared blocks in place)" + +echo Silence is goldenThis case has expected output, so it's not "Silence is golden", please remove this line.
tests/xfs/842 line 65
Quoted 2 lines
tests/xfs/842 new file +2
-0+status=0 +exitI remember we've changed xfstests/new script, it should give "
_exit0" at here.Thanks,
ZorroQuoted 13 lines
Quoted 13 lines
tests/xfs/842.out new file +4
-0@@ -0,0 +1,4 @@ +QA output created by 842 +vX.reflink = 1 +vX.reflink = 1 +Silence is goldenSignature · 1 line
2.50.1 (Apple Git-155)Thanks a lot for your review!
Quoted 3 lines
Yes, this test case uncovers the bug fixed by "xfs: fix exchange-range reflink flag clearing issue with
INO1_WRITTEN". However, that fix is still under review on linux-xfs and has not landed in for-next / xfs-7.2-fixes
Generally, we don't merge a test case before its corresponding kernel patch is guaranteed to be merged. However, given that Darrick has already acked this patch, I feel like that xfs fix has strong backing, so merging this test case now should be fine.
Quoted 2 lines
yet, so there is no stable commit ID to reference. I will add the
_fixed_by_fs_commitannotation as soon as the fix is merged.
Thanks, actually we can write:
_fixed_by_fs_commit xfs xxxxxxxxxxxx
"xfs: fix exchange-range reflink flag clearing issue with INO1_WRITTEN"
Before the fix is officially merged into mainline Linux, "xxxx..." can serve as a placeholder for the commit ID to remind us to update it later.
Don't need one more patch, I'll help to add that it when I merge your v4, please feel free to update it after that fix is merged.
Thanks,
Zorro
Quoted 6 lines
The other comments will be addressed in v4.
Lin Jiapeng
Quoted 176 lines · Zorro Lang
Quoted 158 lines · Lin Jiapeng
Quoted 139 lines · Zorro Lang
Quoted 28 lines · Lin Jiapeng
When a full-file exchangerange is requested with
FILE1_WRITTENfor a fully sparse donor file, every mapping pair is skipped, so no extents actually move. However, the kernel decides to swap the reflink inode flag based on the request geometry alone, so the target file used to lose its reflink flag to the donor while still owning shared extents. A subsequent write then took the non-reflink write path and modified the shared physical blocks in place, silently corrupting the other file sharing them:--- tests/xfs/842.out +++ results/xfs/842.out.bad @@ -1,4 +1,5 @@ QA output created by 842 +vX.reflink = 0 vX.reflink = 1 -vX.reflink = 1 +orig changed: md5 e6065c4aa2ab1603008fc18410f579d4 -> 32c5189478e6bafa1cc76423f06c88f2 (write hit shared blocks in place) Silence is goldenThis test clones a file so that both share extents, swaps the clone against a sparse donor with
FILE1_WRITTEN, and then checks the defect twice. First it inspects the inodes directly withxfs_db: the clone must still be flagged reflink after the exchange (the donor carrying the flag too is the conservative outcome of the fix and is harmless). Then it writes to the clone and verifies after a mount cycle that the original file's data is intact, i.e. the write was redirected through CoW.Quoted 2 lines
The kernel fix "xfs: fix exchange-range reflink flag clearing issue with
INO1_WRITTEN" refuses the reflink flag exchange wheneverSo this patch/case uncovers a known bug which is fixed by:
"xfs: fix exchange-range reflink flag clearing issue withINO1_WRITTEN" ?If so please add:
_fixed_by_fs_commitxfs xxxxxxxxxxxx \
"xfs: fix exchange-range reflink flag clearing issue withINO1_WRITTEN"Quoted 33 lines
FILE1_WRITTENis requested, which makes this test pass.Suggested-by Christoph Hellwig <[email protected]>Suggested-by "Darrick J. Wong" <[email protected]>Reviewed-by "Darrick J. Wong" <[email protected]>Signed-off-by Lin Jiapeng <[email protected]>--- tests/xfs/842 | 65 +++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/842.out | 4 +++ 2 files changed, 69 insertions(+)create mode 100755 tests/xfs/842
create mode 100644 tests/xfs/842.outtests/xfs/842 new file +12
-0@@ -0,0 +1,65 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2026 Tencent. All Rights Reserved. +# +# FS QA Test No. 842 +# +# Make sure that a full-file exchangerange under FILE1_WRITTEN does not strip +# the reflink flag from a file that still owns shared extents. When the +# donor file is fully sparse, every mapping pair is skipped, so no extents +# actually move; the target file must keep its reflink flag, and a later +# write must go through CoW instead of modifying the shared blocks in place. +tests/xfs/842 line 22
Quoted 10 lines
tests/xfs/842 new file +10
-0+. ./common/preamble +_begin_fstest auto quick fiexchange + +# Import common functions. +. ./common/filter +. ./common/reflink + +_require_xfs_io_command exchangerange +_require_scratch_reflink +_require_scratch
_require_scratch_reflinkcontains_require_scratch, so you can save the_require_scratch.Quoted 31 lines
tests/xfs/842 new file +31
-0+ +_scratch_mkfs >> $seqres.full +_scratch_mount + +# Create the original file with a known pattern and clone it, so that both +# files share the same extents. +_pwrite_byte 0x41 0 1m $SCRATCH_MNT/orig >> $seqres.full +_reflink $SCRATCH_MNT/orig $SCRATCH_MNT/clone >> $seqres.full + +# Create a fully sparse donor file of the same size. +$XFS_IO_PROG -f -c 'truncate 1m' $SCRATCH_MNT/donor + +md5_before=$(md5sum $SCRATCH_MNT/orig | awk '{print $1}') + +# Swap the clone against the sparse donor, claiming the donor is fully +# written (-w). Every donor mapping is a hole, so all pairs are skipped +# and the clone keeps its shared extents in place. +$XFS_IO_PROG -c "exchangerange -f -w $SCRATCH_MNT/donor" $SCRATCH_MNT/clone \ + >> $seqres.full + +# Directly confirm the inode flag state after the exchange: the clone +# must still be flagged reflink. The donor may also carry the flag, which +# is the conservative outcome of refusing the flag exchange under +# FILE1_WRITTEN; the extra flag is harmless and can be dropped later by +# the regular reflink flag cleanup path. +_scratch_unmount +_scratch_xfs_db -c "path /clone" -c print -c "path /donor" -c print | \ + grep reflink | sed -e 's/^v[0-9]*/vX/g' +_scratch_mount + +# Overwrite part of the clone. With the reflink flag correctly retained,tests/xfs/842 line 63
Quoted 10 lines
tests/xfs/842 new file +10
-0+# this must go through CoW and leave the shared blocks of orig untouched. +_pwrite_byte 0x42 0 64k $SCRATCH_MNT/clone >> $seqres.full +_scratch_cycle_mount + +md5_after=$(md5sum $SCRATCH_MNT/orig | awk '{print $1}') + +test "$md5_before" != "$md5_after" && \ + echo "orig changed: md5 $md5_before -> $md5_after (write hit shared blocks in place)" + +echo Silence is goldenThis case has expected output, so it's not "Silence is golden", please remove this line.
tests/xfs/842 line 65
Quoted 2 lines
tests/xfs/842 new file +2
-0+status=0 +exitI remember we've changed xfstests/new script, it should give "
_exit0" at here.Thanks,
ZorroQuoted 13 lines
Quoted 13 lines
tests/xfs/842.out new file +4
-0@@ -0,0 +1,4 @@ +QA output created by 842 +vX.reflink = 1 +vX.reflink = 1 +Silence is goldenSignature · 1 line
2.50.1 (Apple Git-155)Thanks a lot for your review!
Quoted 3 lines
Yes, this test case uncovers the bug fixed by "xfs: fix exchange-range reflink flag clearing issue with
INO1_WRITTEN". However, that fix is still under review on linux-xfs and has not landed in for-next / xfs-7.2-fixesGenerally, we don't merge a test case before its corresponding kernel patch is guaranteed to be merged. However, given that Darrick has already acked this patch, I feel like that xfs fix has strong backing, so merging this test case now should be fine.
Quoted 2 lines
yet, so there is no stable commit ID to reference. I will add the
_fixed_by_fs_commitannotation as soon as the fix is merged.Thanks, actually we can write:
_fixed_by_fs_commitxfs xxxxxxxxxxxx
"xfs: fix exchange-range reflink flag clearing issue withINO1_WRITTEN"
Quoted 15 lines
Before the fix is officially merged into mainline Linux, "xxxx..." can serve as a placeholder for the commit ID to remind us to update it later.
Don't need one more patch, I'll help to add that it when I merge your v4, please feel free to update it after that fix is merged.
Thanks,
ZorroQuoted 6 lines
The other comments will be addressed in v4.
Lin Jiapeng
Thanks for offering to add the _fixed_by_fs_commit annotation when merging.
And I will keep tracking the xfs tree and send a follow-up patch to fill in the real commit ID as soon as the fix is merged.
Best regards,
Lin Jiapeng