ASoC: sprd: sprd-mcdt: Drop redundant error messages
Subsystems (3)
PATCH 1/2 ASoC: sprd: sprd-mcdt: Drop redundant error messages
From: bui duc phuc <[email protected]>
The called functions already log failures where appropriate. Return the original error directly and avoid duplicate error messages.
--- sound/soc/sprd/sprd-mcdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
sound/soc/sprd/sprd-mcdt.c +1 -3
@@ -931,10 +931,8 @@ static int sprd_mcdt_probe(struct platform_device *pdev) ret =devm_request_irq (&pdev->dev, irq, sprd_mcdt_irq_handler,0 ,"sprd-mcdt" , mcdt); -if (ret) { -dev_err (&pdev->dev,"Failed to request MCDT IRQ\n" ); +if (ret)return ret; - }sprd_mcdt_init_chans (mcdt, res);
Signature · 1 line
2.43.0
PATCH 2/2 ASoC: sprd: sprd-pcm-dma: Drop redundant error messages
From: bui duc phuc <[email protected]>
The called functions already log failures where appropriate. Remove the error log here to avoid duplicate error messages.
--- sound/soc/sprd/sprd-pcm-dma.c | 2 -- 1 file changed, 2 deletions(-)
sound/soc/sprd/sprd-pcm-dma.c +0 -2
@@ -469,8 +469,6 @@ static int sprd_soc_platform_probe(struct platform_device *pdev) ret =devm_snd_soc_register_component (&pdev->dev, &sprd_soc_component,NULL ,0 ); -if (ret) -dev_err (&pdev->dev,"could not register platform:%d\n" , ret);return ret; }
Signature · 1 line
2.43.0
Quoted 7 lines · On 7/29/26 3:35 PM, [email protected] wrote:
From: bui duc phuc <[email protected]>
The called functions already log failures where appropriate. Return the original error directly and avoid duplicate error messages.
Signed-off-by bui duc phuc <[email protected]>---
LGTM.
Quoted 19 lines
sound/soc/sprd/sprd-mcdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)sound/soc/sprd/sprd-mcdt.c +1
-3@@ -931,10 +931,8 @@ static int sprd_mcdt_probe(struct platform_device *pdev) ret =devm_request_irq (&pdev->dev, irq, sprd_mcdt_irq_handler,0 ,"sprd-mcdt" , mcdt); -if (ret) { -dev_err (&pdev->dev,"Failed to request MCDT IRQ\n" ); +if (ret)return ret; - }sprd_mcdt_init_chans (mcdt, res);
Re: [PATCH 2/2] ASoC: sprd: sprd-pcm-dma: Drop redundant error messages
In reply to [email protected]Quoted 7 lines · On 7/29/26 3:35 PM, [email protected] wrote:
From: bui duc phuc <[email protected]>
The called functions already log failures where appropriate. Remove the error log here to avoid duplicate error messages.
Signed-off-by bui duc phuc <[email protected]>---
LGTM.
Quoted 16 lines
sound/soc/sprd/sprd-pcm-dma.c | 2 -- 1 file changed, 2 deletions(-)sound/soc/sprd/sprd-pcm-dma.c +0
-2@@ -469,8 +469,6 @@ static int sprd_soc_platform_probe(struct platform_device *pdev) ret =devm_snd_soc_register_component (&pdev->dev, &sprd_soc_component,NULL ,0 ); -if (ret) -dev_err (&pdev->dev,"could not register platform:%d\n" , ret);return ret; }
Mark Brown
maintainerQuoted 1 line · On Wed, 29 Jul 2026 14:35:31 +0700, [email protected] wrote:
ASoC: sprd: sprd-mcdt: Drop redundant error messages
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3
Thanks!
[1/2] ASoC: sprd: sprd-mcdt: Drop redundant error messages
https://git.kernel.org/broonie/sound/c/4f08e2b88896 [2/2] ASoC: sprd: sprd-pcm-dma: Drop redundant error messages https://git.kernel.org/broonie/sound/c/595201d39108
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark