Skip to contentSkip to conversation

common/rc: support f2fs in _require_fanotify_ioerrors()

PATCH In review Chao Yu 3 participants 3 messages Jul 29 – Aug 2

lore
Share & tools
lore

Chao Yu

author
#0 lore raw

PATCH v3 1/1 common/rc: support f2fs in _require_fanotify_ioerrors()

f2fs has supported to report fserror, this patch adds support for f2fs in _require_fanotify_ioerrors(), so that we can run generic/791 on f2fs.

Cc Darrick J. Wong <[email protected]>

---
v3:
- fix to chech sysfs node correctly

 common/rc | 6 ++++++
 1 file changed, 6 insertions(+)
common/rc +6 -0
index 106f044ad..3a8f03412 100644
@@ -6266,6 +6266,12 @@ _require_fanotify_ioerrors()
 		x="$(_get_fs_sysfs_attr $TEST_DEV err_report_sec)"
 		test -n "$x" && return 0
 		;;
+	f2fs)
+		local feat_file="/sys/fs/f2fs/features/fserror"
+		if [ -f "$feat_file" ] && [ "$(cat "$feat_file")" = "supported" ]; then
+			return 0
+		fi
+		;;
 	esac
 
 	_notrun "$FSTYP does not support fanotify ioerrors"
Signature · 1 line
2.49.0
Reviewed-by on v3 1/1
#1 lore raw
Quoted 5 lines · Chao Yu

f2fs has supported to report fserror, this patch adds support for f2fs in _require_fanotify_ioerrors(), so that we can run generic/791 on f2fs.

Cc Darrick J. Wong <[email protected]>

Looks fine to me,

--D

Quoted 27 lines

---
v3:
- fix to chech sysfs node correctly

 common/rc | 6 ++++++
 1 file changed, 6 insertions(+)
common/rc +6 -0
index 106f044ad..3a8f03412 100644
@@ -6266,6 +6266,12 @@ _require_fanotify_ioerrors()
 		x="$(_get_fs_sysfs_attr $TEST_DEV err_report_sec)"
 		test -n "$x" && return 0
 		;;
+	f2fs)
+		local feat_file="/sys/fs/f2fs/features/fserror"
+		if [ -f "$feat_file" ] && [ "$(cat "$feat_file")" = "supported" ]; then
+			return 0
+		fi
+		;;
 	esac
 
 	_notrun "$FSTYP does not support fanotify ioerrors"
Signature · 1 line
2.49.0
Reviewed-by on v3 1/1
#2 lore raw
In reply to Chao Yu
Quoted 8 lines · Chao Yu

f2fs has supported to report fserror, this patch adds support for f2fs in _require_fanotify_ioerrors(), so that we can run generic/791 on f2fs.

Cc Darrick J. Wong <[email protected]>

---
v3:
- fix to chech sysfs node correctly

Thanks, let's have this at first.

Quoted 23 lines
 common/rc | 6 ++++++
 1 file changed, 6 insertions(+)
common/rc +6 -0
index 106f044ad..3a8f03412 100644
@@ -6266,6 +6266,12 @@ _require_fanotify_ioerrors()
 		x="$(_get_fs_sysfs_attr $TEST_DEV err_report_sec)"
 		test -n "$x" && return 0
 		;;
+	f2fs)
+		local feat_file="/sys/fs/f2fs/features/fserror"
+		if [ -f "$feat_file" ] && [ "$(cat "$feat_file")" = "supported" ]; then
+			return 0
+		fi
+		;;
 	esac
 
 	_notrun "$FSTYP does not support fanotify ioerrors"
Signature · 1 line
2.49.0