regulator: rt6245: Restore state on enable failure
PATCH 1/1 regulator: rt6245: Restore state on enable failure
From: bui duc phuc <[email protected]>
Currently, if regcache_sync() fails after the enable GPIO has been asserted, the driver returns with enable_gpio still set high and regcache_cache_only() left disabled. This leaves the device state inconsistent with the disabled state, where the enable GPIO is low and cache_only is enabled.
On failure, restore the original state by setting cache_only back to true and driving the enable GPIO low before returning the error.
--- drivers/regulator/rt6245-regulator.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/regulator/rt6245-regulator.c +4 -1
@@ -49,8 +49,11 @@ static int rt6245_enable(struct regulator_dev *rdev)regcache_cache_only (regmap, false); ret =regcache_sync (regmap); -if (ret) +if (ret) { +regcache_cache_only (regmap, true); +gpiod_direction_output (priv->enable_gpio,0 );return ret; + } priv->enable_state = true;return 0 ;
Signature · 1 line
2.43.0
Mark Brown
maintainerQuoted 1 line · On Wed, 29 Jul 2026 17:00:18 +0700, [email protected] wrote:
regulator: rt6245: Restore state on enable failure
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.3
Thanks!
[1/1] regulator: rt6245: Restore state on enable failure
https://git.kernel.org/broonie/regulator/c/e95a0a309ca0
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark