FAILED: patch "[PATCH] drm/vc4: Prevent shader BO mappings from becoming writable" failed to apply to 5.10-stable tree
Subsystems (4)
[email protected]
maintainerThe patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y
git checkout FETCH_HEAD
git cherry-pick -x 0c9e6367639548307d3f578f6943ce72c9d39087
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026072955-sizable-shaft-8750@gregkh' --subject-prefix 'PATCH 5.10.y' 'HEAD^..'
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 0c9e6367639548307d3f578f6943ce72c9d39087 Mon Sep 17 00:00:00 2001
From: Linmao Li <[email protected]>
Date: Tue, 21 Jul 2026 09:15:58 +0800
Subject: [PATCH] drm/vc4: Prevent shader BO mappings from becoming writable
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
vc4_gem_object_mmap() rejects a writable mapping of a validated shader BO, but leaves VM_MAYWRITE set. Userspace can map the BO read-only and then turn it writable with mprotect().
Validated shader BOs must stay read-only: the validator checks the instructions once and the GPU trusts them afterwards. A writable mapping lets userspace rewrite the code after validation, bypassing the validator.
Clear VM_MAYWRITE on the read-only path so the mapping cannot be upgraded, as i915 already does for its read-only objects.
drivers/gpu/drm/vc4/vc4_bo.c +7 -3
@@ -732,9 +732,13 @@ static int vc4_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struct {struct vc4_bo *bo =to_vc4_bo (obj); -if (bo->validated_shader && (vma->vm_flags &VM_WRITE )) { -DRM_DEBUG ("mmapping of shader BOs for writing not allowed.\n" ); -return -EINVAL ; +if (bo->validated_shader) { +if (vma->vm_flags &VM_WRITE ) { +DRM_DEBUG ("mmapping of shader BOs for writing not allowed.\n" ); +return -EINVAL ; + } + +vm_flags_clear (vma,VM_MAYWRITE ); }mutex_lock (&bo->madv_lock);