perf sched latency: Refine outputs, unit scaling, and histogram support
v5 cover perf sched latency: Refine outputs, unit scaling, and histogram support
This patch series improves 'perf sched latency' by fixing misleading empty table output, introducing dynamic unit auto-scaling for latency and runtime statistics, and adding latency histogram visualisation along with time-span filtering.
Patch 1 fixes an issue where 'perf sched latency' would fall through and return success (0) when perf_session__has_traces() failed due to missing tracepoint events in perf.data. This resulted in empty header tables and zeroed summary statistics being printed.
To support pipe mode streams:
- Missing callbacks (.attr, .tracing_data, .build_id, and .feature) are registered in cmd_sched() so pipe header events are properly parsed
- The handlers array is promoted to file-scope latency_handlers[] and evlist__set_tracepoints_handlers() is invoked dynamically inside perf_sched__process_tracepoint_sample() when evsel->handler is NULL
- Trace presence checks are performed post-processing when handling pipe data, while non-pipe files continue to abort early upfront. Additionally, map_switch_event() is guarded against potential NULL pointer dereferences under memory allocation failures
Patch 2 introduces dynamic auto-scaling for latency and runtime display columns (Runtime, Avg delay, Max delay). Previously, all values were unconditionally formatted in milliseconds (ms), making microsecond or second-scale latencies hard to read. Columns are now scaled dynamically to the most appropriate unit (ns, us, ms, s), column headers are updated, and format specifiers are aligned character-for-character with the table headers.
Patch 3 adds three new command-line options to 'perf sched latency':
--histogram (-H):
Displays an ASCII bar chart of CPU wait latencies between snapshots
--hist-mode:
Configures the bucketing scheme to either logarithmic (log) or 100 us equal-width linear (linear) mode
--time:
Filters event processing to a specified [start,stop] time span
Changes since v4:
- Added the missing .feature callback to sched.tool in cmd_sched()
- Fixed memory leak by reusing uncompleted work atoms when sched_in events are skipped or lost
- Promoted the handlers array to file-scope (i.e., latency_handlers[]) and added a dynamic lookup via evlist__set_tracepoints_handlers() inside perf_sched__process_tracepoint_sample() whenever a sample arrives with an unattached handler (i.e., evsel->handler == NULL)
- Prevented double-counting wakeups (i.e., ignore sched:sched_wakeup) in pipe mode and non-pipe modes
- Added missing trailing pipe in output_lat_thread's new auto-scaling format string
- Stripped redundant prefix strings from each row's format string to produce a clean, tabular output
- Link to v4: https://lore.kernel.org/lkml/[email protected]/
Changes since v3:
- Registered Missing Callbacks. In perf_tool__init configuration inside cmd_sched(), added the .attr, .tracing_data, and .build_id callbacks. Without these callbacks, pipe mode drops header attributes entirely, preventing tracepoints from being populated in session->evlist
- Introduced an explicit post-processing pipe check. This ensures that pipe mode aborts correctly and does not produce superfluous empty latency tables when no trace samples are available
- Prevented potential NULL pointer dereference. Added a NULL check for thread__get_runtime() in map_switch_event() under memory allocation failures
- Fixed column alignment. Modified format specifiers to align character-for-character with header column widths across all rows
- Adjusted header label padding. Updated header label padding and column width delimiters in perf_sched__lat() to match the exact field format specifiers printed in output_lat_thread()
- Fixed swapper histogram inclusion. Excluded "swapper" (i.e., CPU-specific idle thread) from global_hist buckets
- Preserved task state machine across --time bounds. Moved time-window filtering inside add_sched_in_event() to gate latency statistics recording without breaking wakeup state tracking across time interval boundaries
- Link to v3: https://lore.kernel.org/lkml/[email protected]/
Changes since v2:
- Ensured vertical pipe separators align across all latency table columns
- Excluded "swapper" (idle thread) latency samples from global_hist
- Preserved task state machine transitions across --time boundaries
- Suppressed empty table headers, total lines, and histogram graphs when no matching trace samples exist (e.g., when --time, --CPU, or --pids exclude all samples), outputting "No matching trace samples found." instead
- Linked to v2: https://lore.kernel.org/lkml/[email protected]/
Changes since v1:
- Fixed integer overflow in latency_bucket() (Ian Rogers)
- Linked to v1: https://lore.kernel.org/lkml/[email protected]/
Aaron Tomlin (3):
perf sched: Suppress latency table output when trace samples are
missing
perf sched latency: Auto-scale latency and runtime display units perf sched latency: Add histogram and time interval options
tools/perf/Documentation/perf-sched.txt | 6 + tools/perf/builtin-sched.c | 318 +++++++++++++++++++++--- 2 files changed, 284 insertions(+), 40 deletions(-)
Signature · 1 line
2.55.0
PATCH v5 1/3 perf sched: Suppress latency table output when trace samples are missing
When 'perf sched latency' is executed on a perf.data file that lacks tracepoint samples (i.e., a file recorded without the -R flag or containing only non-tracepoint events), perf_session__has_traces() correctly outputs an error message. However, perf_sched__read_events() subsequently falls through and returns 0 (success).
Consequently, caller functions such as perf_sched__lat() assume event processing succeeded and proceed to render empty latency header tables and total summary statistics.
Fix this behaviour by ensuring perf_sched__read_events() aborts early and returns a suitable error code when perf_session__has_traces() evaluates to false.
For pipe mode streams, event attributes are received dynamically during event processing, meaning session->evlist is not populated prior to perf_session__process_events(). To handle pipe input correctly:
- Register the missing .attr, .tracing_data, .build_id, and .feature callbacks in cmd_sched()
- Promote the handlers array to file-scope (latency_handlers[]) and invoke evlist__set_tracepoints_handlers() dynamically inside perf_sched__process_tracepoint_sample() when evsel->handler is NULL
- Perform the trace check post-processing when handling pipe data
Additionally, validate thread__get_runtime() against NULL in map_switch_event() to prevent potential null-pointer dereferences.
--- tools/perf/builtin-sched.c | 68 +++++++++++++++++++++++++------------- 1 file changed, 45 insertions(+), 23 deletions(-)
tools/perf/builtin-sched.c +45 -23
@@ -1833,7 +1833,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_sample *sampl sched_out:if (sched->map.task_name) { tr =thread__get_runtime (sched->curr_out_thread[this_cpu.cpu]); -if (strcmp (tr->shortname,"" ) ==0 ) +if (tr ==NULL ||strcmp (tr->shortname,"" ) ==0 ) goto out;if (proceed ==1 )
@@ -1938,6 +1938,15 @@ typedef int (*tracepoint_handler)(const struct perf_tool *tool,struct perf_sample *sample, struct machine *machine); +static struct evsel_str_handler latency_handlers[] = { + {"sched:sched_switch" , process_sched_switch_event, }, + {"sched:sched_stat_runtime" , process_sched_runtime_event, }, + {"sched:sched_wakeup" , process_sched_wakeup_event, }, + {"sched:sched_waking" , process_sched_wakeup_event, }, + {"sched:sched_wakeup_new" , process_sched_wakeup_event, }, + {"sched:sched_migrate_task" , process_sched_migrate_task_event, }, +}; + static int perf_sched__process_tracepoint_sample(const struct perf_tool *tool __maybe_unused, union perf_event *event __maybe_unused, struct perf_sample *sample,
@@ -1946,6 +1955,14 @@ static int perf_sched__process_tracepoint_sample(const struct perf_tool *tool __struct evsel *evsel = sample->evsel;int err =0 ; +if (evsel->handler ==NULL && sample->evsel->evlist) { +/* prefer sched_waking if it is captured */ +if (evlist__find_tracepoint_by_name (sample->evsel->evlist,"sched:sched_waking" )) + latency_handlers[2 ].handler = process_sched_wakeup_ignore; + +evlist__set_tracepoints_handlers (sample->evsel->evlist, latency_handlers); + } +if (evsel->handler !=NULL ) {tracepoint_handler f = evsel->handler; err =f (tool, sample, machine);
@@ -1987,21 +2004,13 @@ static int perf_sched__process_comm(const struct perf_tool *tool __maybe_unused,static int perf_sched__read_events (struct perf_sched *sched) { -struct evsel_str_handler handlers[] = { - {"sched:sched_switch" , process_sched_switch_event, }, - {"sched:sched_stat_runtime" , process_sched_runtime_event, }, - {"sched:sched_wakeup" , process_sched_wakeup_event, }, - {"sched:sched_waking" , process_sched_wakeup_event, }, - {"sched:sched_wakeup_new" , process_sched_wakeup_event, }, - {"sched:sched_migrate_task" , process_sched_migrate_task_event, }, - };struct perf_session *session;struct perf_data data = { .path = input_name, .mode =PERF_DATA_MODE_READ , .force = sched->force, }; -int rc =-1 ; +int rc =-1 , err; session =perf_session__new (&data, &sched->tool);if (IS_ERR (session)) {
@@ -2011,25 +2020,34 @@ static int perf_sched__read_events(struct perf_sched *sched)symbol__init (perf_session__env (session)); -/* prefer sched_waking if it is captured */ -if (evlist__find_tracepoint_by_name (session->evlist,"sched:sched_waking" )) - handlers[2 ].handler = process_sched_wakeup_ignore; +if (!perf_data__is_pipe (session->data)) { +/* prefer sched_waking if it is captured */ +if (evlist__find_tracepoint_by_name (session->evlist,"sched:sched_waking" )) + latency_handlers[2 ].handler = process_sched_wakeup_ignore; -if (perf_session__set_tracepoints_handlers (session, handlers)) +if (perf_session__set_tracepoints_handlers (session, latency_handlers)) + goto out_delete; + } + +if (!perf_data__is_pipe (session->data) && + !perf_session__has_traces (session,"record -R" )) goto out_delete; -if (perf_session__has_traces (session,"record -R" )) { -int err =perf_session__process_events (session); -if (err) { -pr_err ("Failed to process events, error %d" , err); - goto out_delete; - } + err =perf_session__process_events (session); +if (err) { +pr_err ("Failed to process events, error %d" , err); + goto out_delete; + } - sched->nr_events = session->evlist->stats.nr_events[0 ]; - sched->nr_lost_events = session->evlist->stats.total_lost; - sched->nr_lost_chunks = session->evlist->stats.nr_events[PERF_RECORD_LOST ]; +if (perf_data__is_pipe (session->data) && + !perf_session__has_traces (session,"record -R" )) { + goto out_delete; } + sched->nr_events = session->evlist->stats.nr_events[0 ]; + sched->nr_lost_events = session->evlist->stats.total_lost; + sched->nr_lost_chunks = session->evlist->stats.nr_events[PERF_RECORD_LOST ]; + rc =0 ; out_delete:perf_session__delete (session);
@@ -5167,6 +5185,10 @@ int cmd_sched(int argc, const char **argv) sched.tool.namespaces = perf_event__process_namespaces; sched.tool.lost = perf_event__process_lost; sched.tool.fork = perf_sched__process_fork_event; + sched.tool.attr = perf_event__process_attr; + sched.tool.tracing_data = perf_event__process_tracing_data; + sched.tool.build_id = perf_event__process_build_id; + sched.tool.feature = perf_event__process_feature; argc =parse_options_subcommand (argc, argv, sched_options, sched_subcommands, sched_usage,PARSE_OPT_STOP_AT_NON_OPTION );
Signature · 1 line
2.55.0
Namhyung Kim
maintainerRe: [PATCH v5 1/3] perf sched: Suppress latency table output when trace samples are missing
Hello,
Quoted 20 lines · Aaron Tomlin
When 'perf sched latency' is executed on a perf.data file that lacks tracepoint samples (i.e., a file recorded without the -R flag or containing only non-tracepoint events),
perf_session__has_traces()correctly outputs an error message. However,perf_sched__read_events()subsequently falls through and returns 0 (success).Consequently, caller functions such as
perf_sched__lat()assume event processing succeeded and proceed to render empty latency header tables and total summary statistics.Fix this behaviour by ensuring
perf_sched__read_events()aborts early and returns a suitable error code whenperf_session__has_traces()evaluates to false.For pipe mode streams, event attributes are received dynamically during event processing, meaning
session->evlistis not populated prior toperf_session__process_events(). To handle pipe input correctly:
- Register the missing .attr, .tracing_data, .build_id, and .feature callbacks incmd_sched()
Quoted 5 lines
- Promote the handlers array to file-scope (latency_handlers[]) and invoke
evlist__set_tracepoints_handlers()dynamically insideperf_sched__process_tracepoint_sample()whenevsel->handleris NULL- Perform the trace check post-processing when handling pipe data
Can you please split the pipe mode changes into a separate commit?
Quoted 3 lines
Additionally, validate
thread__get_runtime()against NULL inmap_switch_event()to prevent potential null-pointer dereferences.
This is small enough to be squashed.
Thanks,
Namhyung
Re: [PATCH v5 1/3] perf sched: Suppress latency table output when trace samples are missing
Quoted 29 lines · Namhyung Kim
Hello,
Quoted 20 lines · Aaron Tomlin
When 'perf sched latency' is executed on a perf.data file that lacks tracepoint samples (i.e., a file recorded without the -R flag or containing only non-tracepoint events),
perf_session__has_traces()correctly outputs an error message. However,perf_sched__read_events()subsequently falls through and returns 0 (success).Consequently, caller functions such as
perf_sched__lat()assume event processing succeeded and proceed to render empty latency header tables and total summary statistics.Fix this behaviour by ensuring
perf_sched__read_events()aborts early and returns a suitable error code whenperf_session__has_traces()evaluates to false.For pipe mode streams, event attributes are received dynamically during event processing, meaning
session->evlistis not populated prior toperf_session__process_events(). To handle pipe input correctly:
- Register the missing .attr, .tracing_data, .build_id, and .feature callbacks incmd_sched()Quoted 5 lines
- Promote the handlers array to file-scope (latency_handlers[]) and invoke
evlist__set_tracepoints_handlers()dynamically insideperf_sched__process_tracepoint_sample()whenevsel->handleris NULL- Perform the trace check post-processing when handling pipe data
Quoted 7 lines
Can you please split the pipe mode changes into a separate commit?
Quoted 3 lines
Additionally, validate
thread__get_runtime()against NULL inmap_switch_event()to prevent potential null-pointer dereferences.This is small enough to be squashed.
Hi Namhyung,
Absolutely, will do.
Kind regards,
Signature · 1 line
Aaron Tomlin
PATCH v5 2/3 perf sched latency: Auto-scale latency and runtime display units
In reply to Aaron TomlinCurrently, 'perf sched latency' displays task runtime and delay values exclusively in milliseconds (ms). This can be hard to read when latencies are very small (in the microsecond or nanosecond range) or unusually large (seconds).
Introduce auto-scaling for latency and runtime display columns. Values are dynamically scaled and output with the most appropriate unit:
nanoseconds (ns), microseconds (us), milliseconds (ms), or seconds (s).
Additionally, rename column headers from "Runtime ms", "Avg delay ms", and "Max delay ms" to "Runtime", "Avg delay", and "Max delay" respectively, adjust spacing to maintain column alignment and stripe redundant prefix strings from each row's format string to produce a clean, tabular output.
--- tools/perf/builtin-sched.c | 42 +++++++++++++++++++++++++++----------- 1 file changed, 30 insertions(+), 12 deletions(-)
tools/perf/builtin-sched.c +30 -12
@@ -246,6 +246,17 @@ struct perf_sched {struct perf_data *data; }; +static int scnprintf_latency_unit (char *buf,size_t size,u64 nsecs) +{ +if (nsecs <1000 ) +return scnprintf (buf, size,"%6" PRIu64" ns" , nsecs); +if (nsecs <NSEC_PER_MSEC ) +return scnprintf (buf, size,"%6.3f us" , (double )nsecs /NSEC_PER_USEC ); +if (nsecs <NSEC_PER_SEC ) +return scnprintf (buf, size,"%6.3f ms" , (double )nsecs /NSEC_PER_MSEC ); +return scnprintf (buf, size,"%6.3f s " , (double )nsecs /NSEC_PER_SEC ); +} +/* per thread run time data */ struct thread_runtime {u64 last_time;/* time of previous sched in/out event */
@@ -1405,6 +1416,8 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_int i;int ret;u64 avg; +char runtime_lat[32 ]; +char avg_lat[32 ], max_lat[32 ];char max_lat_start[32 ], max_lat_end[32 ];if (!work_list->nb_atoms)
@@ -1430,14 +1443,17 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_printf (" " ); avg = work_list->total_lat / work_list->nb_atoms; +scnprintf_latency_unit (runtime_lat,sizeof (runtime_lat), work_list->total_runtime); +scnprintf_latency_unit (avg_lat,sizeof (avg_lat), avg); +scnprintf_latency_unit (max_lat,sizeof (max_lat), work_list->max_lat);timestamp__scnprintf_usec (work_list->max_lat_start, max_lat_start,sizeof (max_lat_start));timestamp__scnprintf_usec (work_list->max_lat_end, max_lat_end,sizeof (max_lat_end)); -printf ("|%11.3f ms |%9" PRIu64" | avg:%8.3f ms | max:%8.3f ms | max start: %12s s | max end: %12s s\n" , - (double )work_list->total_runtime /NSEC_PER_MSEC , - work_list->nb_atoms, (double )avg /NSEC_PER_MSEC , - (double )work_list->max_lat /NSEC_PER_MSEC , - max_lat_start, max_lat_end); +printf (" |%15s |%9" PRIu64" |%16s |%16s |%20s s |%20s s |\n" , + runtime_lat, + work_list->nb_atoms, avg_lat, max_lat, + max_lat_start, max_lat_end); + }static int pid_cmp (struct work_atoms *l,struct work_atoms *r)
@@ -3616,6 +3632,7 @@ static int perf_sched__lat(struct perf_sched *sched) {int rc =-1 ;struct rb_node *next; +char total_runtime_str[32 ];setup_pager ();
@@ -3628,9 +3645,9 @@ static int perf_sched__lat(struct perf_sched *sched)perf_sched__merge_lat (sched);perf_sched__sort_lat (sched); -printf ("\n -------------------------------------------------------------------------------------------------------------------------------------------\n" ); -printf (" Task | Runtime ms | Count | Avg delay ms | Max delay ms | Max delay start | Max delay end |\n" ); -printf (" -------------------------------------------------------------------------------------------------------------------------------------------\n" ); +printf ("\n -----------------------------------------------------------------------------------------------------------------------------------------\n" ); +printf (" Task | Runtime | Count | Avg delay | Max delay | Max delay start | Max delay end |\n" ); +printf (" -----------------------------------------------------------------------------------------------------------------------------------------\n" ); next =rb_first_cached (&sched->sorted_atom_root);
@@ -3642,11 +3659,12 @@ static int perf_sched__lat(struct perf_sched *sched) next =rb_next (next); } -printf (" -----------------------------------------------------------------------------------------------------------------\n" ); -printf (" TOTAL: |%11.3f ms |%9" PRIu64" |\n" , - (double )sched->all_runtime /NSEC_PER_MSEC , sched->all_count); +printf (" -----------------------------------------------------------------------------------------------------------------------------------------\n" ); +scnprintf_latency_unit (total_runtime_str,sizeof (total_runtime_str), sched->all_runtime); +printf (" TOTAL: |%15s |%9" PRIu64" |\n" , + total_runtime_str, sched->all_count); -printf (" ---------------------------------------------------\n" ); +printf (" -----------------------------------------------------\n" );print_bad_events (sched);printf ("\n" );
Signature · 1 line
2.55.0
Namhyung Kim
maintainerRe: [PATCH v5 2/3] perf sched latency: Auto-scale latency and runtime display units
Quoted 9 lines · Aaron Tomlin
Currently, 'perf sched latency' displays task runtime and delay values exclusively in milliseconds (ms). This can be hard to read when latencies are very small (in the microsecond or nanosecond range) or unusually large (seconds).
Introduce auto-scaling for latency and runtime display columns. Values are dynamically scaled and output with the most appropriate unit:
nanoseconds (ns), microseconds (us), milliseconds (ms), or seconds (s).
Quoted 5 lines
Additionally, rename column headers from "Runtime ms", "Avg delay ms", and "Max delay ms" to "Runtime", "Avg delay", and "Max delay" respectively, adjust spacing to maintain column alignment and stripe redundant prefix strings from each row's format string to produce a clean, tabular output.
It'd be nice if you could include example output when you touched user- visible area. Comparing before and after would be great.
Thanks,
Namhyung
Quoted 101 lines
Signed-off-by Aaron Tomlin <[email protected]>--- tools/perf/builtin-sched.c | 42 +++++++++++++++++++++++++++----------- 1 file changed, 30 insertions(+), 12 deletions(-)tools/perf/builtin-sched.c +30
-12@@ -246,6 +246,17 @@ struct perf_sched {struct perf_data *data; }; +static int scnprintf_latency_unit (char *buf,size_t size,u64 nsecs) +{ +if (nsecs <1000 ) +return scnprintf (buf, size,"%6" PRIu64" ns" , nsecs); +if (nsecs <NSEC_PER_MSEC ) +return scnprintf (buf, size,"%6.3f us" , (double )nsecs /NSEC_PER_USEC ); +if (nsecs <NSEC_PER_SEC ) +return scnprintf (buf, size,"%6.3f ms" , (double )nsecs /NSEC_PER_MSEC ); +return scnprintf (buf, size,"%6.3f s " , (double )nsecs /NSEC_PER_SEC ); +} +/* per thread run time data */ struct thread_runtime {u64 last_time;/* time of previous sched in/out event */ @@ -1405,6 +1416,8 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_int i;int ret;u64 avg; +char runtime_lat[32 ]; +char avg_lat[32 ], max_lat[32 ];char max_lat_start[32 ], max_lat_end[32 ];if (!work_list->nb_atoms)@@ -1430,14 +1443,17 @@ static void output_lat_thread(struct perf_sched *sched, struct work_atoms *work_printf (" " ); avg = work_list->total_lat / work_list->nb_atoms; +scnprintf_latency_unit (runtime_lat,sizeof (runtime_lat), work_list->total_runtime); +scnprintf_latency_unit (avg_lat,sizeof (avg_lat), avg); +scnprintf_latency_unit (max_lat,sizeof (max_lat), work_list->max_lat);timestamp__scnprintf_usec (work_list->max_lat_start, max_lat_start,sizeof (max_lat_start));timestamp__scnprintf_usec (work_list->max_lat_end, max_lat_end,sizeof (max_lat_end)); -printf ("|%11.3f ms |%9" PRIu64" | avg:%8.3f ms | max:%8.3f ms | max start: %12s s | max end: %12s s\n" , - (double )work_list->total_runtime /NSEC_PER_MSEC , - work_list->nb_atoms, (double )avg /NSEC_PER_MSEC , - (double )work_list->max_lat /NSEC_PER_MSEC , - max_lat_start, max_lat_end); +printf (" |%15s |%9" PRIu64" |%16s |%16s |%20s s |%20s s |\n" , + runtime_lat, + work_list->nb_atoms, avg_lat, max_lat, + max_lat_start, max_lat_end); + }static int pid_cmp (struct work_atoms *l,struct work_atoms *r)@@ -3616,6 +3632,7 @@ static int perf_sched__lat(struct perf_sched *sched) {int rc =-1 ;struct rb_node *next; +char total_runtime_str[32 ];setup_pager ();@@ -3628,9 +3645,9 @@ static int perf_sched__lat(struct perf_sched *sched)perf_sched__merge_lat (sched);perf_sched__sort_lat (sched); -printf ("\n -------------------------------------------------------------------------------------------------------------------------------------------\n" ); -printf (" Task | Runtime ms | Count | Avg delay ms | Max delay ms | Max delay start | Max delay end |\n" ); -printf (" -------------------------------------------------------------------------------------------------------------------------------------------\n" ); +printf ("\n -----------------------------------------------------------------------------------------------------------------------------------------\n" ); +printf (" Task | Runtime | Count | Avg delay | Max delay | Max delay start | Max delay end |\n" ); +printf (" -----------------------------------------------------------------------------------------------------------------------------------------\n" ); next =rb_first_cached (&sched->sorted_atom_root);@@ -3642,11 +3659,12 @@ static int perf_sched__lat(struct perf_sched *sched) next =rb_next (next); } -printf (" -----------------------------------------------------------------------------------------------------------------\n" ); -printf (" TOTAL: |%11.3f ms |%9" PRIu64" |\n" , - (double )sched->all_runtime /NSEC_PER_MSEC , sched->all_count); +printf (" -----------------------------------------------------------------------------------------------------------------------------------------\n" ); +scnprintf_latency_unit (total_runtime_str,sizeof (total_runtime_str), sched->all_runtime); +printf (" TOTAL: |%15s |%9" PRIu64" |\n" , + total_runtime_str, sched->all_count); -printf (" ---------------------------------------------------\n" ); +printf (" -----------------------------------------------------\n" );print_bad_events (sched);printf ("\n" );Signature · 1 line
2.55.0
Re: [PATCH v5 2/3] perf sched latency: Auto-scale latency and runtime display units
Quoted 10 lines · Namhyung Kim
Quoted 9 lines · Aaron Tomlin
Currently, 'perf sched latency' displays task runtime and delay values exclusively in milliseconds (ms). This can be hard to read when latencies are very small (in the microsecond or nanosecond range) or unusually large (seconds).
Introduce auto-scaling for latency and runtime display columns. Values are dynamically scaled and output with the most appropriate unit:
nanoseconds (ns), microseconds (us), milliseconds (ms), or seconds (s).
Quoted 8 lines
Quoted 5 lines
Additionally, rename column headers from "Runtime ms", "Avg delay ms", and "Max delay ms" to "Runtime", "Avg delay", and "Max delay" respectively, adjust spacing to maintain column alignment and stripe redundant prefix strings from each row's format string to produce a clean, tabular output.
It'd be nice if you could include example output when you touched user- visible area. Comparing before and after would be great.
Hi Namhyung,
Acknowledged—will do.
Kind regards,
Signature · 1 line
Aaron Tomlin
PATCH v5 3/3 perf sched latency: Add histogram and time interval options
In reply to Aaron TomlinWhile 'perf sched latency' reports task runtime and delay statistics (average and maximum delay), it does not provide a visual representation of how task wait times are distributed across latency ranges between snapshots (start and finish of the analysis window).
The --histogram option collects CPU wait latencies (time between when a task becomes runnable and when it gets scheduled onto a CPU) into 22 latency buckets, displaying an ASCII bar chart distribution.
The --hist-mode option configures the bucketing scheme:
- log (default). Logarithmic latency buckets ranging from sub-microsecond (< 1 us) up to >= 1.05 seconds
- linear. Equal-width linear latency buckets
(i.e., 100 us steps up to >= 2.1 ms)
The --time option allows filtering trace event processing to a specific time interval [start,stop].
Example histogram output excerpt:
❯ sudo perf sched latency --histogram --CPU 0
CPU Wait Latency Distribution Histogram (between snapshots) (total samples: 36114)
-------------------------------------------------------------------
Latency Range | Count | Pct | Histogram Graph
-------------------------------------------------------------------
< 1 us | 17 | 0.0% | #
2 - 4 us | 673 | 1.9% | #
4 - 8 us | 6237 | 17.3% | ######
8 - 16 us | 3224 | 8.9% | ###
16 - 32 us | 1388 | 3.8% | #
32 - 64 us | 709 | 2.0% | #
64 - 128 us | 690 | 1.9% | #
128 - 256 us | 789 | 2.2% | #
256 - 512 us | 541 | 1.5% | #
512 - 1024 us | 2256 | 6.2% | ##
1 - 2 ms | 3577 | 9.9% | ###
2 - 4 ms | 13259 | 36.7% | ##############
4 - 8 ms | 2523 | 7.0% | ##
8 - 16 ms | 222 | 0.6% | #
16 - 32 ms | 10 | 0.0% | #
>= 1.05 s | 3 | 0.0% | #
---------------------------------------------------------------------- tools/perf/Documentation/perf-sched.txt | 6 + tools/perf/builtin-sched.c | 208 +++++++++++++++++++++++- 2 files changed, 209 insertions(+), 5 deletions(-)
tools/perf/Documentation/perf-sched.txt +6 -0
@@ -40,6 +40,12 @@ There are several variants of 'perf sched': Tasks with the same command name are merged and the merge count is given within (), However if -p option is used, pid is mentioned. + If -H or --histogram option is passed, a CPU wait latency distribution + histogram is displayed illustrating how long tasks waited for CPU + runtime across latency buckets between snapshots. The --time + option (start,stop) limits analysis to a specific snapshot time interval. + The --hist-mode option (log or linear) configures the latency bucketing scheme. + 'perf sched script' to see a detailed trace of the workload that was recorded (aliased to 'perf script' for now).
tools/perf/builtin-sched.c +203 -5
326 lines not on this page · raw message
Signature · 1 line
2.55.0