network: Remove outdated DNS stress tests
RFC PATCH 1/1 network: Remove outdated DNS stress tests
From: Avinesh Kumar <[email protected]>
These tests start a local named server and run $NS_TIMES (default: 10) dig queries from the remote host, forward and reverse. The check is that the first and last query return NOERROR with one answer record, and that no dig call in between exited non-zero. They are also broken: dns-stress02-rmt.sh passes 'dig -n' for ipv6, an option removed from bind long ago. dig prints "dig: -n removed", sends no query and exits 0.
Remove these old broken tests based on legacy shell API.
Follow-up: 99c0b167d ("network: Remove outdated TCP stress tests")
--- runtest/net_stress.appl | 5 +- testcases/network/stress/README | 6 +- .../network/stress/dns/00_Descriptions.txt | 7 - testcases/network/stress/dns/Makefile | 29 --- .../network/stress/dns/dns-stress-lib.sh | 41 ---- testcases/network/stress/dns/dns-stress.sh | 204 ------------------ .../network/stress/dns/dns-stress01-rmt.sh | 73 ------- .../network/stress/dns/dns-stress02-rmt.sh | 78 ------- 8 files changed, 4 insertions(+), 439 deletions(-) delete mode 100644 testcases/network/stress/dns/00_Descriptions.txt delete mode 100644 testcases/network/stress/dns/Makefile delete mode 100644 testcases/network/stress/dns/dns-stress-lib.sh delete mode 100755 testcases/network/stress/dns/dns-stress.sh delete mode 100755 testcases/network/stress/dns/dns-stress01-rmt.sh delete mode 100755 testcases/network/stress/dns/dns-stress02-rmt.sh
runtest/net_stress.appl +1 -4
@@ -1,13 +1,10 @@ # -# Stress test for major application protocol (ssh, dns, http, ftp) +# Stress test for major application protocol (ssh, http, ftp) # ssh4-stress ssh-stress.sh ssh6-stress ssh-stress.sh -6 -dns4-stress dns-stress.sh -dns6-stress dns-stress.sh -6 - http4-stress http-stress.sh http6-stress http-stress.sh -6
testcases/network/stress/README +3 -3
@@ -61,8 +61,8 @@ Attention for HTTP/FTP stress tests When you run http or ftp stress tests, you have to start http or ftp server before running the tests. -About ssh and dns tests, you don't need to run the ssh or dns server. Each -test runs named or sshd automatically. +About ssh tests, you don't need to run the ssh server. Each test runs sshd +automatically. Those tests requires that the remote host has `curl' command in order to upload/download files to/from the local host.
@@ -159,7 +159,7 @@ Optional environment variables o NS_TIMES (for the repetition test) The number of repetition times for the repetition tests. This value affects IP adress add/del testcase, IP address change testcase - route add/del testcase and dns query tests. + route add/del testcase. o CONNECTION_TOTAL (for creating a large number of connection test) The total number of connection when the testcase requires plural connection.
testcases/network/stress/dns/00_Descriptions.txt deleted +0 -7
@@ -1,7 +0,0 @@ -dns-stress01 - Verify the dns server or the kernel is not down after handling - many name lookup queries - -dns-stress02 - Verify the dns server or the kernel is not down after handling - many reverse lookup queries
testcases/network/stress/dns/Makefile deleted +0 -29
@@ -1,29 +0,0 @@ -# -# network/stress/dns test suite Makefile. -# -# Copyright (C) 2009, Cisco Systems Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -# -# Ngie Cooper, July 2009 -# - -top_srcdir ?= ../../../.. - -include $(top_srcdir)/include/mk/env_pre.mk - -INSTALL_TARGETS := *.sh - -include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/network/stress/dns/dns-stress-lib.sh deleted +0 -41
41 lines not on this page · raw message
testcases/network/stress/dns/dns-stress.sh deleted +0 -204
204 lines not on this page · raw message
testcases/network/stress/dns/dns-stress01-rmt.sh deleted +0 -73
73 lines not on this page · raw message
testcases/network/stress/dns/dns-stress02-rmt.sh deleted +0 -78
78 lines not on this page · raw message
Signature · 5 lines
2.55.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Avinesh,
Quoted 1 line · Avinesh Kumar
network: Remove outdated DNS stress tests
Verdict - Reviewed
---
Note:
The agent can sometimes produce false positives although often its findings are genuine. If you find issues with the review, please comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Avinesh,
Quoted 8 lines
These tests start a local named server and run $NS_TIMES (default: 10) dig queries from the remote host, forward and reverse. The check is that the first and last query return NOERROR with one answer record, and that no dig call in between exited non-zero. They are also broken:
dns-stress02-rmt.shpasses 'dig -n' for ipv6, an option removed from bind long ago. dig prints "dig: -n removed", sends no query and exits 0.
Remove these old broken tests based on legacy shell API.
Thanks, I always wanted to delete them.
Quoted 1 line
Follow-up:
99c0b167d("network: Remove outdated TCP stress tests")
...
runtest/net_stress.appl line 6
Quoted 9 lines
+++ b/runtest/net_stress.appl
runtest/net_stress.appl +1
-1@@ -1,13 +1,10 @@ -# Stress test for major application protocol (ssh, dns, http, ftp) +# Stress test for major application protocol (ssh, http, ftp) ssh4-stress ssh-stress.sh ssh6-stress ssh-stress.sh -6
FYI removal of SSH stress tests ...
runtest/net_stress.appl line 9
Quoted 5 lines
runtest/net_stress.appl +0
-3-dns4-stress dns-stress.sh -dns6-stress dns-stress.sh -6 - http4-stress http-stress.sh http6-stress http-stress.sh -6
... and HTTP stress tests is blocked by
https://github.com/linux-test-project/ltp/issues/1207
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Andrea Cervesato via ltp
Acked-by Andrea CervesatoBurn them with fire!
Thanks,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
[email protected]
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Avinesh,
thanks for your patch, merged!
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp