Skip to contentSkip to conversation

Gitlab CI: sage: Disable test_net_tftpboot_boot on Raspberry Pi 4 for now

PATCH In review Tom Rini 2 participants 3 messages Jul 31 – Aug 7

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 Gitlab CI: sage: Disable test_net_tftpboot_boot on Raspberry Pi 4 for now

With commit 623f6c5b6ab7 ("boot: image-fdt: free old dtb reservations") we now get:
ERROR: freeing fdt memory region failed (addr=3ef667e0 size=36 flags=2): -1
ERROR: freeing fdt memory region failed (addr=3ef663a0 size=400 flags=2): -1 on console when booting, which is non-fatal but leads to the test failing. Disable this test for now.

---
Cc: Randolph Sapp <[email protected]>
Cc: Ilias Apalodimas <[email protected]>
Cc: Peter Robinson <[email protected]>

---
 .gitlab-ci-sage-lab.yml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
.gitlab-ci-sage-lab.yml +6 -1
index 90f97696f86c..9e1c2378c6ef 100644
@@ -144,6 +144,9 @@ Raspberry Pi 4:
     LABGRID_EXPORTER: "sage-exporter-rpi4-1"
     LG_PLACE: "rpi4-1"
     TEST_PY_BD: "rpi_4"
+    # With commit 623f6c5b6ab7 we get "ERROR" messages that are
+    # harmless during OS boot but fail the test.
+    TEST_PY_TEST_SPEC: "not test_net_tftpboot_boot"
     OVERRIDE: "-a UNIT_TEST -a ~CMD_EFIDEBUG -a CMD_BOOTMENU -a CMD_LOG -a ~CMD_BOOTEFI_SELFTEST -a CMD_TFTPPUT -a FIT -a FIT_SIGNATURE -a FIT_BEST_MATCH -a SYS_BOOTM_LEN=0x4000000 -a BOOTSTAGE -a BOOTSTAGE_STASH -a CMD_BOOTSTAGE -a BOOTSTAGE_STASH_ADDR=0x02400000"
 
 Raspberry Pi 4 (rpi_arm64):
@@ -154,7 +157,9 @@ Raspberry Pi 4 (rpi_arm64):
     LG_PLACE: "rpi4-1"
     TEST_PY_BD: "rpi_arm64"
     # DHCP is not being run first, needs to be investigated.
-    TEST_PY_TEST_SPEC: "not test_efi_helloworld_net_http"
+    # With commit 623f6c5b6ab7 we get "ERROR" messages that are
+    # harmless during OS boot but fail the test.
+    TEST_PY_TEST_SPEC: "not test_efi_helloworld_net_http and not test_net_tftpboot_boot"
     OVERRIDE: "-a UNIT_TEST -a ~CMD_EFIDEBUG -a CMD_BOOTMENU -a CMD_LOG -a ~CMD_BOOTEFI_SELFTEST -a FIT -a FIT_SIGNATURE -a FIT_BEST_MATCH -a SYS_BOOTM_LEN=0x4000000 -a BOOTSTAGE -a BOOTSTAGE_STASH -a CMD_BOOTSTAGE -a BOOTSTAGE_STASH_ADDR=0x02400000"
 
 Raspberry Pi 4 (rpi_4_32b):
Signature · 1 line
2.43.0
Acked-by on v1 1/1
#1 lore raw

Hi Tom,

I'll see if I can reprod locally.

Quoted 10 lines · Tom Rini

With commit 623f6c5b6ab7 ("boot: image-fdt: free old dtb reservations") we now get:
ERROR: freeing fdt memory region failed (addr=3ef667e0 size=36 flags=2): -1
ERROR: freeing fdt memory region failed (addr=3ef663a0 size=400 flags=2): -1 on console when booting, which is non-fatal but leads to the test failing. Disable this test for now.

---

for now

Quoted 35 lines
Cc Randolph Sapp <[email protected]>
Cc Ilias Apalodimas <[email protected]>
Cc Peter Robinson <[email protected]>
---
 .gitlab-ci-sage-lab.yml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
.gitlab-ci-sage-lab.yml +6 -2
index 90f97696f86c..9e1c2378c6ef 100644
@@ -144,6 +144,9 @@ Raspberry Pi 4:
     LABGRID_EXPORTER: "sage-exporter-rpi4-1"
     LG_PLACE: "rpi4-1"
     TEST_PY_BD: "rpi_4"
+    # With commit 623f6c5b6ab7 we get "ERROR" messages that are
+    # harmless during OS boot but fail the test.
+    TEST_PY_TEST_SPEC: "not test_net_tftpboot_boot"
     OVERRIDE: "-a UNIT_TEST -a ~CMD_EFIDEBUG -a CMD_BOOTMENU -a CMD_LOG -a ~CMD_BOOTEFI_SELFTEST -a CMD_TFTPPUT -a FIT -a FIT_SIGNATURE -a FIT_BEST_MATCH -a SYS_BOOTM_LEN=0x4000000 -a BOOTSTAGE -a BOOTSTAGE_STASH -a CMD_BOOTSTAGE -a BOOTSTAGE_STASH_ADDR=0x02400000"
 
 Raspberry Pi 4 (rpi_arm64):
@@ -154,7 +157,9 @@ Raspberry Pi 4 (rpi_arm64):
     LG_PLACE: "rpi4-1"
     TEST_PY_BD: "rpi_arm64"
     # DHCP is not being run first, needs to be investigated.
-    TEST_PY_TEST_SPEC: "not test_efi_helloworld_net_http"
+    # With commit 623f6c5b6ab7 we get "ERROR" messages that are
+    # harmless during OS boot but fail the test.
+    TEST_PY_TEST_SPEC: "not test_efi_helloworld_net_http and not test_net_tftpboot_boot"
     OVERRIDE: "-a UNIT_TEST -a ~CMD_EFIDEBUG -a CMD_BOOTMENU -a CMD_LOG -a ~CMD_BOOTEFI_SELFTEST -a FIT -a FIT_SIGNATURE -a FIT_BEST_MATCH -a SYS_BOOTM_LEN=0x4000000 -a BOOTSTAGE -a BOOTSTAGE_STASH -a CMD_BOOTSTAGE -a BOOTSTAGE_STASH_ADDR=0x02400000"
 
 Raspberry Pi 4 (rpi_4_32b):
--

2.43.0

author
#2 lore raw
In reply to Tom Rini
Quoted 8 lines · Tom Rini

With commit 623f6c5b6ab7 ("boot: image-fdt: free old dtb reservations") we now get:
ERROR: freeing fdt memory region failed (addr=3ef667e0 size=36 flags=2): -1
ERROR: freeing fdt memory region failed (addr=3ef663a0 size=400 flags=2): -1 on console when booting, which is non-fatal but leads to the test failing. Disable this test for now.

[...]

Applied to u-boot/main, thanks!

[1/1] Gitlab CI: sage: Disable test_net_tftpboot_boot on Raspberry Pi 4 for now

      commit: 06c866fee0052579dbd27456fac425d002d44a80
Signature · 1 line
Tom