soc/tegra: flowctrl: Release OF node reference on error
PATCH 1/1 soc/tegra: flowctrl: Release OF node reference on error
tegra_flowctrl_init() obtains a reference from of_find_matching_node() and currently releases it only after of_address_to_resource() succeeds.
Release the reference before checking the resource conversion result so the error path is balanced as well.
Fixes 1fd09e5d884a ("soc/tegra: Add initial flowctrl support for Tegra132/210")
Signed-off-by Yuho Choi <[email protected]>
--- drivers/soc/tegra/flowctrl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/soc/tegra/flowctrl.c +4 -2
@@ -195,11 +195,13 @@ static int __init tegra_flowctrl_init(void) np =of_find_matching_node (NULL , tegra_flowctrl_match);if (np) { -if (of_address_to_resource (np,0 , &res) <0 ) { +int err =of_address_to_resource (np,0 , &res); +of_node_put (np); + +if (err <0 ) {pr_err ("failed to get flowctrl register\n" );return -ENXIO ; } -of_node_put (np); }else if (IS_ENABLED (CONFIG_ARM )) {/* * Hardcoded fallback for 32-bit Tegra
Signature · 1 line
2.43.0