Skip to contentSkip to conversation

perf pmu-events: Fix typo in idle-cycles-frontend description

RFC Applied Pu Hu 2 participants 3 messages Aug 2 – Aug 4 perf events

lore
Share & tools
lore

Pu Hu

author
#0 lore raw

RFC 1/1 perf pmu-events: Fix typo in idle-cycles-frontend description

From: Pu Hu <[email protected]>

The brief description of the idle-cycles-frontend legacy hardware event refers to its alias as "stalled-cycles-fronted", but there is no such event. The correct event name is "stalled-cycles-frontend".

This typo is visible in the output of "perf list", for example:

idle-cycles-frontend
[Stalled cycles during issue [This event is an alias of
stalled-cycles-fronted]. Unit: armv8_pmuv3]

Fix the spelling so that the description points to the valid event name.

---
 .../arch/common/common/legacy-hardware.json   |   2 +-
 tools/perf/pmu-events/empty-pmu-events.c      | 362 +++++++++---------
 2 files changed, 182 insertions(+), 182 deletions(-)
tools/perf/pmu-events/arch/common/common/legacy-hardware.json +1 -1
index 71700647f19b..ee9f4247e8ae 100644
@@ -51,7 +51,7 @@
   },
   {
     "EventName": "idle-cycles-frontend",
-    "BriefDescription": "Stalled cycles during issue [This event is an alias of stalled-cycles-fronted].",
+    "BriefDescription": "Stalled cycles during issue [This event is an alias of stalled-cycles-frontend].",
     "LegacyConfigCode": "7"
   },
   {
tools/perf/pmu-events/empty-pmu-events.c +181 -181

631 lines not on this page · raw message

Signature · 1 line
2.43.0
author
#1 lore raw
Quoted 8 lines · Pu Hu

From: Pu Hu <[email protected]>

The brief description of the idle-cycles-frontend legacy hardware event refers to its alias as "stalled-cycles-fronted", but there is no such event. The correct event name is "stalled-cycles-frontend".

This typo is visible in the output of "perf list", for example:

Quoted 7 lines

idle-cycles-frontend
[Stalled cycles during issue [This event is an alias of
stalled-cycles-fronted]. Unit: armv8_pmuv3]

Fix the spelling so that the description points to the valid event name.

Hi maintainers,

Just to add some context, I reproduced this issue on an arm64 platform.

Without this patch, "perf list" reports:

idle-cycles-frontend
[Stalled cycles during issue [This event is an alias of
stalled-cycles-fronted]. Unit: armv8_pmuv3]

But there is no "stalled-cycles-fronted" event. The intended event name is "stalled-cycles-frontend".

After the fix, the description points to the correct event name.

Thanks,
Pu Hu

maintainer Applied
#2 lore raw
In reply to Pu Hu
Quoted 11 lines · Pu Hu

The brief description of the idle-cycles-frontend legacy hardware event refers to its alias as "stalled-cycles-fronted", but there is no such event. The correct event name is "stalled-cycles-frontend".

This typo is visible in the output of "perf list", for example:

idle-cycles-frontend
[Stalled cycles during issue [This event is an alias of
stalled-cycles-fronted]. Unit: armv8_pmuv3]

[...]

Applied to perf-tools-next, thanks!

Best regards,
Namhyung