Skip to contentSkip to conversation

ASoC: fix unmet dependencies on PPC_BESTCOMM and SND_SOC_AC97_BUS

PATCH Superseded Julian Braha 3 participants 6 messages Aug 2 – Aug 16

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: fix unmet dependencies on PPC_BESTCOMM and SND_SOC_AC97_BUS

SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA both select SND_SOC_MPC5200_AC97 without ensuring that its dependency on PPC_BESTCOMM is met. This causes unmet dependencies such as:

WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_BESTCOMM [=n] Selected by [m]:
- SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]

SND_MPC52xx_SOC_EFIKA also selects SND_SOC_STAC9766 without ensuring its dependency on SND_SOC_AC97_BUS is met.

Let's resolve all 3 unmet dependencies by adding the dependencies on PPC_BESTCOMM where needed, and selecting SND_SOC_AC97_BUS as other, similar options in this subsystem do.

These unmet dependency bugs were detected by kconfirm, a static analysis tool for Kconfig.

Fixes a9262c4fd404 ("ASoC: Support for AC97 on Phytec pmc030 base board.")
Fixes 6ffee43ecf8b ("ASoC: Fabric bindings for STAC9766 on the Efika")
---
 sound/soc/fsl/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/soc/fsl/Kconfig +3 -1
index 8ae59c094878..a5d7cf534391 100644
@@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
 
 config SND_MPC52xx_SOC_PCM030
 	tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
-	depends on PPC_MPC5200_SIMPLE
+	depends on PPC_BESTCOMM
 	select SND_SOC_MPC5200_AC97
 	select SND_SOC_WM9712
 	help
@@ -253,6 +253,8 @@ config SND_MPC52xx_SOC_PCM030
 config SND_MPC52xx_SOC_EFIKA
 	tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
 	depends on PPC_EFIKA
+	depends on PPC_BESTCOMM
+	select SND_SOC_AC97_BUS
 	select SND_SOC_MPC5200_AC97
 	select SND_SOC_STAC9766
 	help
Signature · 1 line
2.55.0
#1 lore raw
Quoted 41 lines · Julian Braha

SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA both select SND_SOC_MPC5200_AC97 without ensuring that its dependency on PPC_BESTCOMM is met. This causes unmet dependencies such as:

WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_BESTCOMM [=n] Selected by [m]:
- SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]

SND_MPC52xx_SOC_EFIKA also selects SND_SOC_STAC9766 without ensuring its dependency on SND_SOC_AC97_BUS is met.

Let's resolve all 3 unmet dependencies by adding the dependencies on PPC_BESTCOMM where needed, and selecting SND_SOC_AC97_BUS as other, similar options in this subsystem do.

These unmet dependency bugs were detected by kconfirm, a static analysis tool for Kconfig.

Fixes a9262c4fd404 ("ASoC: Support for AC97 on Phytec pmc030 base board.")
Fixes 6ffee43ecf8b ("ASoC: Fabric bindings for STAC9766 on the Efika")
---
 sound/soc/fsl/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/soc/fsl/Kconfig +1 -1
index 8ae59c094878..a5d7cf534391 100644
@@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
 
 config SND_MPC52xx_SOC_PCM030
        tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
-       depends on PPC_MPC5200_SIMPLE
+       depends on PPC_BESTCOMM
        select SND_SOC_MPC5200_AC97
        select SND_SOC_WM9712
        help

sound/soc/fsl/Kconfig config SND_MPC52xx_SOC_PCM030 · line 256

Quoted 4 lines
sound/soc/fsl/Kconfig +1 -0
@@ -253,6 +253,8 @@ config SND_MPC52xx_SOC_PCM030
 config SND_MPC52xx_SOC_EFIKA
        tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
        depends on PPC_EFIKA
+       depends on PPC_BESTCOMM

does this really depend on PPC_BESTCOMM?

Quoted 7 lines
sound/soc/fsl/Kconfig +1 -1
+       select SND_SOC_AC97_BUS
        select SND_SOC_MPC5200_AC97
        select SND_SOC_STAC9766
        help
--

2.55.0

#2 lore raw

Hi Rosen,

Quoted 34 lines · Rosen Penev
Quoted 33 lines · Julian Braha

SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA both select SND_SOC_MPC5200_AC97 without ensuring that its dependency on PPC_BESTCOMM is met. This causes unmet dependencies such as:

WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_BESTCOMM [=n] Selected by [m]:
- SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]

SND_MPC52xx_SOC_EFIKA also selects SND_SOC_STAC9766 without ensuring its dependency on SND_SOC_AC97_BUS is met.

Let's resolve all 3 unmet dependencies by adding the dependencies on PPC_BESTCOMM where needed, and selecting SND_SOC_AC97_BUS as other, similar options in this subsystem do.

These unmet dependency bugs were detected by kconfirm, a static analysis tool for Kconfig.

Fixes a9262c4fd404 ("ASoC: Support for AC97 on Phytec pmc030 base board.")
Fixes 6ffee43ecf8b ("ASoC: Fabric bindings for STAC9766 on the Efika")
---
 sound/soc/fsl/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/soc/fsl/Kconfig +0 -0
index 8ae59c094878..a5d7cf534391 100644
@@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
 
Quoted 13 lines

sound/soc/fsl/Kconfig config SND_MPC52xx_SOC_PCM030 · line 256

Quoted 12 lines
sound/soc/fsl/Kconfig +2 -1
 config SND_MPC52xx_SOC_PCM030
        tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
-       depends on PPC_MPC5200_SIMPLE
+       depends on PPC_BESTCOMM
        select SND_SOC_MPC5200_AC97
        select SND_SOC_WM9712
        help
@@ -253,6 +253,8 @@ config SND_MPC52xx_SOC_PCM030
 config SND_MPC52xx_SOC_EFIKA
        tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
        depends on PPC_EFIKA
+       depends on PPC_BESTCOMM

does this really depend on PPC_BESTCOMM?

Yes, BestComm is the co-processor found on Freescale MPC5200.

- Julian Braha

#3 lore raw
Quoted 52 lines · Julian Braha

Hi Rosen,

Quoted 34 lines · Rosen Penev
Quoted 33 lines · Julian Braha

SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA both select SND_SOC_MPC5200_AC97 without ensuring that its dependency on PPC_BESTCOMM is met. This causes unmet dependencies such as:

WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_BESTCOMM [=n] Selected by [m]:
- SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]

SND_MPC52xx_SOC_EFIKA also selects SND_SOC_STAC9766 without ensuring its dependency on SND_SOC_AC97_BUS is met.

Let's resolve all 3 unmet dependencies by adding the dependencies on PPC_BESTCOMM where needed, and selecting SND_SOC_AC97_BUS as other, similar options in this subsystem do.

These unmet dependency bugs were detected by kconfirm, a static analysis tool for Kconfig.

Fixes a9262c4fd404 ("ASoC: Support for AC97 on Phytec pmc030 base board.")
Fixes 6ffee43ecf8b ("ASoC: Fabric bindings for STAC9766 on the Efika")
---
 sound/soc/fsl/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/soc/fsl/Kconfig +0 -0
index 8ae59c094878..a5d7cf534391 100644
@@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
 
Quoted 13 lines

sound/soc/fsl/Kconfig config SND_MPC52xx_SOC_PCM030 · line 256

Quoted 12 lines
sound/soc/fsl/Kconfig +2 -1
 config SND_MPC52xx_SOC_PCM030
        tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
-       depends on PPC_MPC5200_SIMPLE
+       depends on PPC_BESTCOMM
        select SND_SOC_MPC5200_AC97
        select SND_SOC_WM9712
        help
@@ -253,6 +253,8 @@ config SND_MPC52xx_SOC_PCM030
 config SND_MPC52xx_SOC_EFIKA
        tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
        depends on PPC_EFIKA
+       depends on PPC_BESTCOMM

does this really depend on PPC_BESTCOMM?

Quoted 1 line

Yes, BestComm is the co-processor found on Freescale MPC5200.

Just took a look at this.

sound/soc/fsl/efika-audio-fabric.c +0 -2
@@ -22,8 +22,6 @@
 #include <sound/initval.h>
 #include <sound/soc.h>
 
-#include "mpc5200_dma.h"
-
 #define DRV_NAME "efika-audio-fabric"
 
 SND_SOC_DAILINK_DEFS(analog,

compiles. That header indeed references bestcom stuff, but I don't see the driver doing so.

Quoted 2 lines

- Julian Braha

#4 lore raw
Quoted 68 lines · Rosen Penev
Quoted 52 lines · Julian Braha

Hi Rosen,

Quoted 34 lines · Rosen Penev
Quoted 33 lines · Julian Braha

SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA both select SND_SOC_MPC5200_AC97 without ensuring that its dependency on PPC_BESTCOMM is met. This causes unmet dependencies such as:

WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_BESTCOMM [=n] Selected by [m]:
- SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]

SND_MPC52xx_SOC_EFIKA also selects SND_SOC_STAC9766 without ensuring its dependency on SND_SOC_AC97_BUS is met.

Let's resolve all 3 unmet dependencies by adding the dependencies on PPC_BESTCOMM where needed, and selecting SND_SOC_AC97_BUS as other, similar options in this subsystem do.

These unmet dependency bugs were detected by kconfirm, a static analysis tool for Kconfig.

Fixes a9262c4fd404 ("ASoC: Support for AC97 on Phytec pmc030 base board.")
Fixes 6ffee43ecf8b ("ASoC: Fabric bindings for STAC9766 on the Efika")
---
 sound/soc/fsl/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/soc/fsl/Kconfig +0 -0
index 8ae59c094878..a5d7cf534391 100644
@@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
 
Quoted 13 lines

sound/soc/fsl/Kconfig config SND_MPC52xx_SOC_PCM030 · line 256

Quoted 12 lines
sound/soc/fsl/Kconfig +2 -1
 config SND_MPC52xx_SOC_PCM030
        tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
-       depends on PPC_MPC5200_SIMPLE
+       depends on PPC_BESTCOMM
        select SND_SOC_MPC5200_AC97
        select SND_SOC_WM9712
        help
@@ -253,6 +253,8 @@ config SND_MPC52xx_SOC_PCM030
 config SND_MPC52xx_SOC_EFIKA
        tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
        depends on PPC_EFIKA
+       depends on PPC_BESTCOMM

does this really depend on PPC_BESTCOMM?

Quoted 1 line

Yes, BestComm is the co-processor found on Freescale MPC5200.

Just took a look at this.

sound/soc/fsl/efika-audio-fabric.c +0 -2
@@ -22,8 +22,6 @@
 #include <sound/initval.h>
 #include <sound/soc.h>
 
-#include "mpc5200_dma.h"
-
 #define DRV_NAME "efika-audio-fabric"
 
 SND_SOC_DAILINK_DEFS(analog,
Quoted 4 lines

compiles. That header indeed references bestcom stuff, but I don't see the driver doing so.

Quoted 2 lines

- Julian Braha

Ahh, nice catch! I'll send a v2 soon.

- Julian Braha

#5 lore raw
In reply to Rosen Penev
Quoted 14 lines · Rosen Penev

On Sat, Aug 15, 2026 at 5:01 PM Julian Braha <[email protected]> wrote:

sound/soc/fsl/efika-audio-fabric.c +0 -2
@@ -22,8 +22,6 @@
 #include <sound/initval.h>
 #include <sound/soc.h>
 
-#include "mpc5200_dma.h"
-
 #define DRV_NAME "efika-audio-fabric"
 
 SND_SOC_DAILINK_DEFS(analog,
Quoted 2 lines

compiles. That header indeed references bestcom stuff, but I don't see the driver doing so.

CONFIG_SND_MPC52xx_DMA is a hidden symbol that gets selected by the drivers that use it (SND_SOC_MPC5200_I2S and SND_SOC_MPC5200_AC97).

SND_MPC52xx_SOC_EFIKA and SND_MPC52xx_SOC_PCM030 in turn select SND_SOC_MPC5200_AC97, but that could probably be turned into 'depends on' since SND_SOC_MPC5200_AC97 is a user visible symbol.

Arnd