Skip to contentSkip to conversation

ASoC: rt766: add RT766/RT767 SDCA driver

PATCH In review [email protected] 3 participants 6 messages Aug 4

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 ASoC: rt766: add RT766/RT767 SDCA driver

From: Shuming Fan <[email protected]>

This patch adds the initial SDCA multi-function codec driver for the RT766 and RT767.

---
 sound/soc/codecs/Kconfig          |   10 +
 sound/soc/codecs/Makefile         |    2 +
 sound/soc/codecs/rt766-sdca-sdw.c |  339 +++++++
 sound/soc/codecs/rt766-sdca-sdw.h |   61 ++
 sound/soc/codecs/rt766-sdca.c     | 1362 +++++++++++++++++++++++++++++
 sound/soc/codecs/rt766-sdca.h     |  138 +++
 6 files changed, 1912 insertions(+)
 create mode 100644 sound/soc/codecs/rt766-sdca-sdw.c
 create mode 100644 sound/soc/codecs/rt766-sdca-sdw.h
 create mode 100644 sound/soc/codecs/rt766-sdca.c
 create mode 100644 sound/soc/codecs/rt766-sdca.h
sound/soc/codecs/Kconfig +10 -0
index 5893edda63f7..6af0247781ad 100644
@@ -238,6 +238,7 @@ config SND_SOC_ALL_CODECS
 	imply SND_SOC_RT715_SDCA_SDW
 	imply SND_SOC_RT721_SDCA_SDW
 	imply SND_SOC_RT722_SDCA_SDW
+	imply SND_SOC_RT766_SDCA_SDW
 	imply SND_SOC_RT1308_SDW
 	imply SND_SOC_RT1316_SDW
 	imply SND_SOC_RT1318
@@ -1984,6 +1985,15 @@ config SND_SOC_RT715_SDCA_SDW
 	select REGMAP_SOUNDWIRE
 	select REGMAP_SOUNDWIRE_MBQ
 
+config SND_SOC_RT766_SDCA_SDW
+	tristate "Realtek RT766 SDCA Codec - SDW"
+	depends on SOUNDWIRE
+	depends on SND_SOC_SDCA
+	select SND_SOC_SDCA_HID
+	select SND_SOC_SDCA_IRQ
+	select REGMAP_SOUNDWIRE
+	select REGMAP_SOUNDWIRE_MBQ
+
 config SND_SOC_RT9120
 	tristate "Richtek RT9120 Stereo Class-D Amplifier"
 	depends on I2C
sound/soc/codecs/Makefile +2 -0
index 2e006f5a8abd..3d122ace75ad 100644
@@ -285,6 +285,7 @@ snd-soc-rt715-y := rt715.o rt715-sdw.o
 snd-soc-rt715-sdca-y := rt715-sdca.o rt715-sdca-sdw.o
 snd-soc-rt721-sdca-y := rt721-sdca.o rt721-sdca-sdw.o
 snd-soc-rt722-sdca-y := rt722-sdca.o rt722-sdca-sdw.o
+snd-soc-rt766-sdca-y := rt766-sdca.o rt766-sdca-sdw.o
 snd-soc-rt9120-y := rt9120.o
 snd-soc-rt9123-y := rt9123.o
 snd-soc-rt9123p-y := rt9123p.o
@@ -727,6 +728,7 @@ obj-$(CONFIG_SND_SOC_RT715)     += snd-soc-rt715.o
 obj-$(CONFIG_SND_SOC_RT715_SDCA_SDW)     += snd-soc-rt715-sdca.o
 obj-$(CONFIG_SND_SOC_RT721_SDCA_SDW)     += snd-soc-rt721-sdca.o
 obj-$(CONFIG_SND_SOC_RT722_SDCA_SDW)     += snd-soc-rt722-sdca.o
+obj-$(CONFIG_SND_SOC_RT766_SDCA_SDW)     += snd-soc-rt766-sdca.o
 obj-$(CONFIG_SND_SOC_RT9120)	+= snd-soc-rt9120.o
 obj-$(CONFIG_SND_SOC_RT9123)	+= snd-soc-rt9123.o
 obj-$(CONFIG_SND_SOC_RT9123P)	+= snd-soc-rt9123p.o
sound/soc/codecs/rt766-sdca-sdw.c new file +339 -0

339 lines not on this page · raw message

sound/soc/codecs/rt766-sdca-sdw.h new file +61 -0

61 lines not on this page · raw message

sound/soc/codecs/rt766-sdca.c new file +1362 -0

1,362 lines not on this page · raw message

sound/soc/codecs/rt766-sdca.h new file +138 -0

138 lines not on this page · raw message

Signature · 1 line
2.54.0
maintainer
#2 lore raw
In reply to [email protected]
Quoted 3 lines · On Tue, Aug 04, 2026 at 06:48:28PM +0800, [email protected] wrote:

From: Shuming Fan <[email protected]>

This patch adds the initial SDCA multi-function codec driver for the RT766 and RT767.

This breaks the build:

/build/stage/linux/sound/soc/codecs/rt766-sdca.c: In function ‘rt766_sdca_irq_ct
l’:
/build/stage/linux/sound/soc/codecs/rt766-sdca.c:240:41: error: implicit declaration of function ‘sdca_irq_cleanup_late’; did you mean ‘sdca_irq_cleanup’? [-Wimplicit-function-declaration]

  240 |                                         sdca_irq_cleanup_late(dev, function, info);
      |                                         ^~~~~~~~~~~~~~~~~~~~~
      |                                         sdca_irq_cleanup
/build/stage/linux/sound/soc/codecs/rt766-sdca.c: In function ‘rt766_sdca_probe’:
/build/stage/linux/sound/soc/codecs/rt766-sdca.c:858:35: error: implicit declaration of function ‘devm_sdca_irq_allocate’; did you mean ‘sdca_irq_allocate’? [-Wimplicit-function-declaration]
  858 |                 rt766->irq_info = devm_sdca_irq_allocate(dev, rt766->regmap, rt766->slave->irq);
      |                                   ^~~~~~~~~~~~~~~~~~~~~~
      |                                   sdca_irq_allocate

/build/stage/linux/sound/soc/codecs/rt766-sdca.c:858:33: error: assignment to ‘struct sdca_interrupt_info *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
858 | rt766->irq_info = devm_sdca_irq_allocate(dev, rt766->regmap, rt766->slave->irq);
| ^

#3 lore raw
Quoted 18 lines · Mark Brown
Quoted 3 lines · On Tue, Aug 04, 2026 at 06:48:28PM +0800, [email protected] wrote:

From: Shuming Fan <[email protected]>

This patch adds the initial SDCA multi-function codec driver for the RT766 and RT767.

This breaks the build:

/build/stage/linux/sound/soc/codecs/rt766-sdca.c: In function ‘rt766_sdca_irq_ct
l’:
/build/stage/linux/sound/soc/codecs/rt766-sdca.c:240:41: error: implicit declaration of function ‘sdca_irq_cleanup_late’; did you mean ‘sdca_irq_cleanup’? [-Wimplicit-function-declaration]

  240 |                                         sdca_irq_cleanup_late(dev, function, info);
      |                                         ^~~~~~~~~~~~~~~~~~~~~
      |                                         sdca_irq_cleanup
/build/stage/linux/sound/soc/codecs/rt766-sdca.c: In function ‘rt766_sdca_probe’:
/build/stage/linux/sound/soc/codecs/rt766-sdca.c:858:35: error: implicit declaration of function ‘devm_sdca_irq_allocate’; did you mean ‘sdca_irq_allocate’? [-Wimplicit-function-declaration]
  858 |                 rt766->irq_info = devm_sdca_irq_allocate(dev, rt766->regmap, rt766->slave->irq);
      |                                   ^~~~~~~~~~~~~~~~~~~~~~
      |                                   sdca_irq_allocate
Quoted 4 lines

/build/stage/linux/sound/soc/codecs/rt766-sdca.c:858:33: error: assignment to ‘struct sdca_interrupt_info *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
858 | rt766->irq_info = devm_sdca_irq_allocate(dev, rt766->regmap, rt766->slave->irq);
| ^

I think this might just be a topic branches thing, those functions were introduced by my recent series which should be in your tree:

https://lore.kernel.org/linux-sound/178517447302.50339.1499803314056469107.b4-ty@b4/

Thanks,
Charles

maintainer
#4 lore raw
Quoted 9 lines · Charles Keepax
Quoted 4 lines · Mark Brown

/build/stage/linux/sound/soc/codecs/rt766-sdca.c:240:41: error: implicit declaration of function ‘sdca_irq_cleanup_late’; did you mean ‘sdca_irq_cleanup’? [-Wimplicit-function-declaration]

  240 |                                         sdca_irq_cleanup_late(dev, function, info);
      |                                         ^~~~~~~~~~~~~~~~~~~~~
      |                                         sdca_irq_cleanup

I think this might just be a topic branches thing, those functions were introduced by my recent series which should be in your tree:

Or it's missing includes?

Quoted 1 line

https://lore.kernel.org/linux-sound/178517447302.50339.1499803314056469107.b4-ty@b4/

Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.

maintainer
#5 lore raw
In reply to [email protected]
Quoted 1 line · On Tue, 04 Aug 2026 18:48:28 +0800, [email protected] wrote:

ASoC: rt766: add RT766/RT767 SDCA driver

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/1] ASoC: rt766: add RT766/RT767 SDCA driver

      https://git.kernel.org/broonie/sound/c/b50ecf5873df

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark