Skip to contentSkip to conversation

parisc/serial: Use generic BASE_BAUD in asm/serial.h

PATCH Superseded Thorsten Blum 2 participants 5 messages Aug 4 PA-RISC architecture

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 parisc/serial: Use generic BASE_BAUD in asm/serial.h

Include asm-generic/serial.h and use the generic BASE_BAUD definition instead of redefining it.

---
 arch/parisc/include/asm/serial.h | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
arch/parisc/include/asm/serial.h +1 -4
index 77e9b67c87ee..d9fd3f78d31f 100644
@@ -2,7 +2,4 @@
  * include/asm-parisc/serial.h
  */
 
-/*
- * This is used for 16550-compatible UARTs
- */
-#define BASE_BAUD ( 1843200 / 16 )
+#include <asm-generic/serial.h>
#1 lore raw

PATCH 2/3 parisc/serial: Add include guard to asm/serial.h

Add an include guard and remove the stale filename comment while at it.

---
 arch/parisc/include/asm/serial.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
arch/parisc/include/asm/serial.h +4 -3
index d9fd3f78d31f..4f0df8e10a4f 100644
@@ -1,5 +1,6 @@
-/*
- * include/asm-parisc/serial.h
- */
+#ifndef _ASM_PARISC_SERIAL_H
+#define _ASM_PARISC_SERIAL_H
 
 #include <asm-generic/serial.h>
+
+#endif /* _ASM_PARISC_SERIAL_H */
#2 lore raw

PATCH 3/3 parisc/serial: Add SPDX license identifier to asm/serial.h

In reply to Thorsten Blum

Add the SPDX license identifier.

---
 arch/parisc/include/asm/serial.h | 1 +
 1 file changed, 1 insertion(+)
arch/parisc/include/asm/serial.h +1 -0
index 4f0df8e10a4f..122430db8cad 100644
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 #ifndef _ASM_PARISC_SERIAL_H
 #define _ASM_PARISC_SERIAL_H
 
maintainer
#3 lore raw
In reply to Thorsten Blum

Hi Thorsten,

Quoted 7 lines · Thorsten Blum

Include asm-generic/serial.h and use the generic BASE_BAUD definition instead of redefining it.

---
  arch/parisc/include/asm/serial.h | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

Instead of sending 3 patches, isn't removing arch/parisc/include/asm/serial.h and adding the patch below the better approach?

Helge

arch/parisc/include/asm/Kbuild +1 -0
index d48d158f7241..4fc315085914 100644
@@ -6,3 +6,4 @@ generic-y += kvm_para.h
 generic-y += mcs_spinlock.h
 generic-y += ring_buffer.h
 generic-y += user.h
+generic-y += serial.h
#4 lore raw
Quoted 6 lines · Helge Deller

Hi Thorsten,

Quoted 3 lines · Thorsten Blum

Include asm-generic/serial.h and use the generic BASE_BAUD definition instead of redefining it.

Quoted 7 lines
Quoted 4 lines
---
  arch/parisc/include/asm/serial.h | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

Instead of sending 3 patches, isn't removing arch/parisc/include/asm/serial.h and adding the patch below the better approach?

It was a single patch at some point, but since serial.h is otherwise empty, your approach seems a lot nicer. I'll send a v2.

Thanks,
Thorsten

Quoted 9 lines
arch/parisc/include/asm/Kbuild +1 -0
index d48d158f7241..4fc315085914 100644
@@ -6,3 +6,4 @@ generic-y += kvm_para.h
 generic-y += mcs_spinlock.h
 generic-y += ring_buffer.h
 generic-y += user.h
+generic-y += serial.h