parisc/serial: Use generic BASE_BAUD in asm/serial.h
PATCH 1/3 parisc/serial: Use generic BASE_BAUD in asm/serial.h
Include asm-generic/serial.h and use the generic BASE_BAUD definition instead of redefining it.
--- arch/parisc/include/asm/serial.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
arch/parisc/include/asm/serial.h +1 -4
@@ -2,7 +2,4 @@* include/asm-parisc/serial.h */ -/* -* This is used for 16550-compatible UARTs -*/ -#define BASE_BAUD ( 1843200 / 16 ) +#include <asm-generic/serial.h>
PATCH 2/3 parisc/serial: Add include guard to asm/serial.h
Add an include guard and remove the stale filename comment while at it.
--- arch/parisc/include/asm/serial.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
arch/parisc/include/asm/serial.h +4 -3
@@ -1,5 +1,6 @@ -/* -* include/asm-parisc/serial.h -*/ +#ifndef _ASM_PARISC_SERIAL_H +#define _ASM_PARISC_SERIAL_H#include <asm-generic/serial.h> + +#endif /* _ASM_PARISC_SERIAL_H */
PATCH 3/3 parisc/serial: Add SPDX license identifier to asm/serial.h
In reply to Thorsten BlumAdd the SPDX license identifier.
--- arch/parisc/include/asm/serial.h | 1 + 1 file changed, 1 insertion(+)
arch/parisc/include/asm/serial.h +1 -0
@@ -1,3 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ #ifndef _ASM_PARISC_SERIAL_H#define _ASM_PARISC_SERIAL_H
Helge Deller
maintainerHi Thorsten,
Quoted 7 lines · Thorsten Blum
Include
asm-generic/serial.hand use the genericBASE_BAUDdefinition instead of redefining it.Signed-off-by Thorsten Blum <[email protected]>--- arch/parisc/include/asm/serial.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
Instead of sending 3 patches, isn't removing arch/parisc/include/asm/serial.h and adding the patch below the better approach?
Helge
arch/parisc/include/asm/Kbuild +1 -0
@@ -6,3 +6,4 @@ generic-y += kvm_para.h generic-y += mcs_spinlock.h generic-y += ring_buffer.h generic-y += user.h +generic-y += serial.h
Quoted 6 lines · Helge Deller
Hi Thorsten,
Quoted 3 lines · Thorsten Blum
Include
asm-generic/serial.hand use the genericBASE_BAUDdefinition instead of redefining it.
Quoted 7 lines
Quoted 4 lines
Signed-off-by Thorsten Blum <[email protected]>--- arch/parisc/include/asm/serial.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)Instead of sending 3 patches, isn't removing
arch/parisc/include/asm/serial.hand adding the patch below the better approach?
It was a single patch at some point, but since serial.h is otherwise empty, your approach seems a lot nicer. I'll send a v2.
Thanks,
Thorsten
Quoted 9 lines
arch/parisc/include/asm/Kbuild +1
-0@@ -6,3 +6,4 @@ generic-y += kvm_para.h generic-y += mcs_spinlock.h generic-y += ring_buffer.h generic-y += user.h +generic-y += serial.h