Skip to contentSkip to conversation

riscv: dts: spacemit: add cpu scaling for 3 boards

PATCH Applied Andre Heider 2 participants 8 messages Aug 4 – Sep 19

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover riscv: dts: spacemit: add cpu scaling for 3 boards

This series adds cpu scaling for 3 boards, each authored and tested by a community member on their device:

- k1-musepi-pro
fixed include order
v1: https://lore.kernel.org/all/[email protected]/

- orangepi-rv2
unchanged, included here because it's still unmerged, probably just
fell through the cracks
v2: https://lore.kernel.org/spacemit/[email protected]/

- k1-orangepi-r2s
new patch from Vincent, cc'ed
origin: https://github.com/dhewg/openwrt/pull/3

Andre Heider (1):
riscv: dts: spacemit: k1-musepi-pro: add cpu scaling

Jonatan Hazell (1):
riscv: dts: spacemit: orangepi-r2s: Add cpu scaling for K1 SoC

Vincent Legoll (1):
riscv: dts: spacemit: orangepi-rv2: Add cpu scaling for K1 SoC

 .../riscv/boot/dts/spacemit/k1-musepi-pro.dts | 35 ++++++++++++++++++-
 .../boot/dts/spacemit/k1-orangepi-r2s.dts     | 35 ++++++++++++++++++-
 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 35 ++++++++++++++++++-
 3 files changed, 102 insertions(+), 3 deletions(-)
Signature · 1 line
2.53.0
#1 lore raw

PATCH 1/3 riscv: dts: spacemit: k1-musepi-pro: add cpu scaling

Enable CPU DVFS by including the OPP table and wiring the CPU nodes to the CPU regulator supply.

---
 .../riscv/boot/dts/spacemit/k1-musepi-pro.dts | 35 ++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)
arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts +34 -1
index 246f8f2ab62b..23f32a8a3d45 100644
@@ -8,6 +8,7 @@
 /dts-v1/;
 
 #include "k1.dtsi"
+#include "k1-opp.dtsi"
 #include "k1-pinctrl.dtsi"
 
 / {
@@ -99,6 +100,38 @@ &combo_phy {
 	status = "okay";
 };
 
+&cpu_0 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_1 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_2 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_3 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_4 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_5 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_6 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_7 {
+	cpu-supply = <&buck1_0v9>;
+};
+
 &eth0 {
 	phy-handle = <&rgmii0>;
 	phy-mode = "rgmii-id";
@@ -178,7 +211,7 @@ pmic@41 {
 		dldoin2-supply = <&buck5>;
 
 		regulators {
-			buck1 {
+			buck1_0v9: buck1 {
 				regulator-min-microvolt = <500000>;
 				regulator-max-microvolt = <1050000>;
 				regulator-ramp-delay = <5000>;
Signature · 1 line
2.53.0
#2 lore raw

PATCH 2/3 riscv: dts: spacemit: orangepi-rv2: Add cpu scaling for K1 SoC

In reply to Andre Heider

From: Vincent Legoll <[email protected]>

Enable CPU DVFS on OrangePi RV2

---
 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 35 ++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)
arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +34 -1
index b907a1396b21..dc6836ff7f1c 100644
@@ -7,6 +7,7 @@
 /dts-v1/;
 
 #include "k1.dtsi"
+#include "k1-opp.dtsi"
 #include "k1-pinctrl.dtsi"
 
 / {
@@ -80,6 +81,38 @@ &combo_phy {
 	status = "okay";
 };
 
+&cpu_0 {
+       cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_1 {
+       cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_2 {
+       cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_3 {
+       cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_4 {
+       cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_5 {
+       cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_6 {
+       cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_7 {
+       cpu-supply = <&buck1_0v9>;
+};
+
 &emmc {
 	bus-width = <8>;
 	mmc-hs400-1_8v;
@@ -162,7 +195,7 @@ pmic@41 {
 		dldoin2-supply = <&buck5>;
 
 		regulators {
-			buck1 {
+			buck1_0v9: buck1 {
 				regulator-min-microvolt = <500000>;
 				regulator-max-microvolt = <1050000>;
 				regulator-ramp-delay = <5000>;
Signature · 1 line
2.53.0
#3 lore raw

PATCH 3/3 riscv: dts: spacemit: orangepi-r2s: Add cpu scaling for K1 SoC

In reply to Andre Heider

From: Jonatan Hazell <[email protected]>

Enable CPU DVFS on OrangePi R2S by including the shared K1 OPP tables and wiring the CPU cores to the P1 PMIC's buck1 rail.

This mirrors the existing cpu-scaling support for the Banana Pi BPI-F3 and OrangePi RV2. Tested on the R2S hardware.

---
 .../boot/dts/spacemit/k1-orangepi-r2s.dts     | 35 ++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)
arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts +34 -1
index 2d1ba34cb00e..6ebd4334410e 100644
@@ -6,6 +6,7 @@
 /dts-v1/;
 
 #include "k1.dtsi"
+#include "k1-opp.dtsi"
 #include "k1-pinctrl.dtsi"
 
 / {
@@ -50,6 +51,38 @@ vcc5v0_usb: regulator-vcc5v0-usb {
 	};
 };
 
+&cpu_0 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_1 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_2 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_3 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_4 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_5 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_6 {
+	cpu-supply = <&buck1_0v9>;
+};
+
+&cpu_7 {
+	cpu-supply = <&buck1_0v9>;
+};
+
 &combo_phy {
 	status = "okay";
 };
@@ -132,7 +165,7 @@ pmic@41 {
 		dldoin2-supply = <&buck5>;
 
 		regulators {
-			buck1 {
+			buck1_0v9: buck1 {
 				regulator-min-microvolt = <500000>;
 				regulator-max-microvolt = <1050000>;
 				regulator-ramp-delay = <5000>;
Signature · 1 line
2.53.0
#4 lore raw
In reply to Andre Heider

Hi,

friendly ping, anything left for me to do here?

Thanks,
Andre

Quoted 30 lines · Andre Heider

This series adds cpu scaling for 3 boards, each authored and tested by a community member on their device:

- k1-musepi-pro
fixed include order
v1: https://lore.kernel.org/all/[email protected]/

- orangepi-rv2
unchanged, included here because it's still unmerged, probably just
fell through the cracks
v2: https://lore.kernel.org/spacemit/[email protected]/

- k1-orangepi-r2s
new patch from Vincent, cc'ed
origin: https://github.com/dhewg/openwrt/pull/3

Andre Heider (1):
riscv: dts: spacemit: k1-musepi-pro: add cpu scaling

Jonatan Hazell (1):
riscv: dts: spacemit: orangepi-r2s: Add cpu scaling for K1 SoC

Vincent Legoll (1):
riscv: dts: spacemit: orangepi-rv2: Add cpu scaling for K1 SoC

  .../riscv/boot/dts/spacemit/k1-musepi-pro.dts | 35 ++++++++++++++++++-
  .../boot/dts/spacemit/k1-orangepi-r2s.dts     | 35 ++++++++++++++++++-
  .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 35 ++++++++++++++++++-
  3 files changed, 102 insertions(+), 3 deletions(-)
maintainer
#5 lore raw

Hi Andre,

Quoted 4 lines · Andre Heider

Hi,

friendly ping, anything left for me to do here?

Not really, I will handle them shortly, there is one minor issue, will fix it while applying (no need sending new)..

WARNING: please, no spaces at the start of a line #33: FILE: arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts:87:
+ cpu-supply = <&buck1_0v9>;$

Thanks for the ping (and sorry for the delay)..

Signature · 1 line
Yixun Lan (dlan)
maintainer Applied
#7 lore raw
In reply to Andre Heider
Quoted 8 lines · Andre Heider

This series adds cpu scaling for 3 boards, each authored and tested by a community member on their device:

- k1-musepi-pro
fixed include order
v1: https://lore.kernel.org/all/[email protected]/

[...]

Applied, thanks!

[1/3] riscv: dts: spacemit: k1-musepi-pro: add cpu scaling

      https://git.kernel.org/pub/scm/linux/kernel/git/spacemit/linux.git/commit/?id=2961d968d0cf1f8f696e822b900943d6c1072a66
[2/3] riscv: dts: spacemit: orangepi-rv2: Add cpu scaling for K1 SoC
      https://git.kernel.org/pub/scm/linux/kernel/git/spacemit/linux.git/commit/?id=e56e2800e994d251486a3988209e07a711eb95b7
[3/3] riscv: dts: spacemit: orangepi-r2s: Add cpu scaling for K1 SoC
      https://git.kernel.org/pub/scm/linux/kernel/git/spacemit/linux.git/commit/?id=4947ee60bf48caddf5caefc08dbbc84d09fbbc6b

Best regards,

Signature · 1 line
Yixun Lan <[email protected]>
#6 lore raw
In reply to Yixun Lan
Quoted 11 lines · Yixun Lan

Hi Andre,

Quoted 4 lines · Andre Heider

Hi,

friendly ping, anything left for me to do here?

Not really, I will handle them shortly, there is one minor issue, will fix it while applying (no need sending new)..

Quoted 6 lines

WARNING: please, no spaces at the start of a line #33: FILE: arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts:87:
+ cpu-supply = <&buck1_0v9>;$

Thanks for the ping (and sorry for the delay)..

Thanks for the fixup, dunno why I didn't catch that!