staging: rtl8723bs: convert swing index variables from u8 to int
PATCH v2 1/1 staging: rtl8723bs: convert swing index variables from u8 to int
In ODM_TxPwrTrackSetPwr_8723B(), Final_OFDM_Swing_Index and Final_CCK_Swing_Index are declared as u8. Using u8 for variables involved in arithmetic calculations and lower-bound comparisons (<= 0) is unusual and triggers static analysis warnings.
Convert both variables from u8 to int to clean up the variable types, aligning with the TODO item to "convert any remaining unusual variable types".
--- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +2 -2
@@ -160,8 +160,8 @@ void ODM_TxPwrTrackSetPwr_8723B(u8 PwrTrackingLimit_OFDM =34 ;/* 0dB */ u8 PwrTrackingLimit_CCK =28 ;/* 2dB */ u8 TxRate =0xFF ; -u8 Final_OFDM_Swing_Index =0 ; -u8 Final_CCK_Swing_Index =0 ; +int Final_OFDM_Swing_Index =0 ; +int Final_CCK_Swing_Index =0 ; {u16 rate = *(pDM_Odm->pForcedDataRate);
Signature · 1 line
2.43.0
Greg Kroah-Hartman
maintainerQuoted 4 lines · Mohit Mishra
In
ODM_TxPwrTrackSetPwr_8723B(),Final_OFDM_Swing_IndexandFinal_CCK_Swing_Indexare declared as u8. Using u8 for variables involved in arithmetic calculations and lower-bound comparisons (<= 0) is unusual and triggers static analysis warnings.
What warnings?
Quoted 3 lines
Convert both variables from u8 to int to clean up the variable types, aligning with the TODO item to "convert any remaining unusual variable types".
u8 is NOT an unusual variable type at all.
thanks,
greg k-h
Quoted 6 lines · On Tue, 1 Sep 2026 11:43:11 +0200 Greg Kroah-Hartman…
Quoted 4 lines · Mohit Mishra
In
ODM_TxPwrTrackSetPwr_8723B(),Final_OFDM_Swing_IndexandFinal_CCK_Swing_Indexare declared as u8. Using u8 for variables involved in arithmetic calculations and lower-bound comparisons (<= 0) is unusual and triggers static analysis warnings.
Quoted 7 lines
What warnings?
Quoted 3 lines
Convert both variables from u8 to int to clean up the variable types, aligning with the TODO item to "convert any remaining unusual variable types".
u8 is NOT an unusual variable type at all.
Indeed, but doing arithmetic on u6 and u16 is likely to be less efficient because the compiler has to mask the results (on pretty much all architectures except x86 and m68k).
But that isn't the reason given.
David
Quoted 5 lines
thanks,
greg k-h