Skip to contentSkip to conversation

fs: remove stale inode_insert5() kernel-doc parameter

PATCH Applied Yichong Chen 3 participants 3 messages Aug 5 – Aug 12 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: remove stale inode_insert5() kernel-doc parameter

inode_insert5() no longer has an isnew argument, but its kernel-doc still documents one. This triggers a W=1 kernel-doc warning.

Remove the stale parameter description.

---
 fs/inode.c | 1 -
 1 file changed, 1 deletion(-)
fs/inode.c +0 -1
index a31aa7cb47f6..ed7c8df1bfca 100644
@@ -1282,7 +1282,6 @@ EXPORT_SYMBOL(unlock_two_nondirectories);
  * @test:	callback used for comparisons between inodes
  * @set:	callback used to initialize a new struct inode
  * @data:	opaque data pointer to pass to @test and @set
- * @isnew:	pointer to a bool which will indicate whether I_NEW is set
  *
  * Search for the inode specified by @hashval and @data in the inode cache,
  * and if present return it with an increased reference count. This is a
Signature · 1 line
2.51.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Yichong Chen

inode_insert5() no longer has an isnew argument, but its kernel-doc still documents one. This triggers a W=1 kernel-doc warning.

Remove the stale parameter description.

Looks good. Feel free to add:

Honza

Quoted 19 lines
---
 fs/inode.c | 1 -
 1 file changed, 1 deletion(-)
fs/inode.c +0 -1
index a31aa7cb47f6..ed7c8df1bfca 100644
@@ -1282,7 +1282,6 @@ EXPORT_SYMBOL(unlock_two_nondirectories);
  * @test:	callback used for comparisons between inodes
  * @set:	callback used to initialize a new struct inode
  * @data:	opaque data pointer to pass to @test and @set
- * @isnew:	pointer to a bool which will indicate whether I_NEW is set
  *
  * Search for the inode specified by @hashval and @data in the inode cache,
  * and if present return it with an increased reference count. This is a
Signature · 1 line
2.51.0
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
maintainer Applied
#2 lore raw
In reply to Yichong Chen
Quoted 1 line · Yichong Chen

fs: remove stale inode_insert5() kernel-doc parameter

Applied to the vfs-7.3.misc branch of the vfs/vfs.git tree. Patches in the vfs-7.3.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-7.3.misc

[1/1] fs: remove stale inode_insert5() kernel-doc parameter

      https://git.kernel.org/vfs/vfs/c/28c7347ac297