Skip to contentSkip to conversation

platform/x86: asus-wmi: add tablet-mode switch quirk for ASUS ProArt PX13

PATCH In review Tinoy Thomas 2 participants 2 messages Aug 5 – Sep 15

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: asus-wmi: add tablet-mode switch quirk for ASUS ProArt PX13

The ProArt PX13 (HN7306WV) is a 360-degree convertible. It exposes no dedicated SW_TABLET_MODE input switch, but the firmware implements the ASUS WMI lid-flip query (DSTS dev_id 0x00060062): it returns 0x10000 with the lid open and 0x10001 when the screen is folded back, and the 0xfa (NOTIFY_LID_FLIP) WMI event fires on every fold/unfold transition.

Add a DMI quirk selecting the lid-flip dev-id so the driver registers SW_TABLET_MODE on the "Asus WMI hotkeys" input device and reports the hinge state, matching the existing UX360 behavior.

---
 drivers/platform/x86/asus-nb-wmi.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
drivers/platform/x86/asus-nb-wmi.c +13 -0
@@ -137,6 +137,10 @@
 	.tablet_switch_mode = asus_wmi_lid_flip_devid,
 };
 
+static struct quirk_entry quirk_asus_proart_px13 = {
+	.tablet_switch_mode = asus_wmi_lid_flip_devid,
+};
+
 static struct quirk_entry quirk_asus_tablet_mode = {
 	.wmi_backlight_set_devstate = true,
 	.tablet_switch_mode = asus_wmi_lid_flip_rog_devid,
@@ -562,6 +566,15 @@
 		},
 		.driver_data = &quirk_asus_z13,
 	},
+	{
+		.callback = dmi_matched,
+		.ident = "ASUS ProArt PX13",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "HN7306WV"),
+		},
+		.driver_data = &quirk_asus_proart_px13,
+	},
 	{},
 };
 
maintainer
#1 lore raw
Quoted 11 lines · Tinoy Thomas

The ProArt PX13 (HN7306WV) is a 360-degree convertible. It exposes no dedicated SW_TABLET_MODE input switch, but the firmware implements the ASUS WMI lid-flip query (DSTS dev_id 0x00060062): it returns 0x10000 with the lid open and 0x10001 when the screen is folded back, and the 0xfa (NOTIFY_LID_FLIP) WMI event fires on every fold/unfold transition.

Add a DMI quirk selecting the lid-flip dev-id so the driver registers SW_TABLET_MODE on the "Asus WMI hotkeys" input device and reports the hinge state, matching the existing UX360 behavior.

[...]

Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also fixes are mostly routed through for-next unless the fix is for a commit introduced in the most recent cycle or is clearly a regression fix.

The list of commits applied:
[1/1] platform/x86: asus-wmi: add tablet-mode switch quirk for ASUS ProArt PX13

      commit: aa5e0d0fa3cce4e5e54e51b68676ce659a6fd156

--
i.