Skip to contentSkip to conversation

ARM: dts: BCM53573: add phy-mode and fixed-link

PATCH Applied Rosen Penev 2 participants 2 messages Aug 5 – Sep 3

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: BCM53573: add phy-mode and fixed-link

These are needed for CPU ethernet links for switches.

Fixes dtbs_check warnings:

switch@1e (brcm,bcm53125): ports:port@5: 'phy-mode' is a required property switch@1e (brcm,bcm53125): ports:port@8: 'phy-mode' is a required property switch@1e (brcm,bcm53125): ports:port@8: 'oneOf' conditional failed, one must be fixed:

'fixed-link' is a required property
'phy-handle' is a required property
'managed' is a required property
from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml

---
 arch/arm/boot/dts/broadcom/bcm53573.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/broadcom/bcm53573.dtsi +7 -0
index 2c43be98090b..1dd2e984b1e9 100644
@@ -226,6 +226,7 @@ port@4 {
 
 						port@5 {
 							reg = <5>;
+							phy-mode = "internal";
 							ethernet = <&gmac1>;
 
 							fixed-link {
@@ -236,7 +237,13 @@ fixed-link {
 
 						port@8 {
 							reg = <8>;
+							phy-mode = "internal";
 							ethernet = <&gmac0>;
+
+							fixed-link {
+								speed = <1000>;
+								full-duplex;
+							};
 						};
 					};
 				};
Signature · 1 line
2.55.0
maintainer Applied
#1 lore raw

From: Florian Fainelli <[email protected]>

Quoted 8 lines · Rosen Penev

These are needed for CPU ethernet links for switches.

Fixes dtbs_check warnings:

switch@1e (brcm,bcm53125): ports:port@5: 'phy-mode' is a required property switch@1e (brcm,bcm53125): ports:port@8: 'phy-mode' is a required property switch@1e (brcm,bcm53125): ports:port@8: 'oneOf' conditional failed, one must be fixed:

Quoted 7 lines

'fixed-link' is a required property
'phy-handle' is a required property
'managed' is a required property
from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml

---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! --
Florian