ALSA: dummy: Check card index validity at probe
PATCH 1/1 ALSA: dummy: Check card index validity at probe
snd_dummy_probe() blindly trusts that the given devptr->id value is within the proper card index range. It's OK for the devices the driver itself creates at the module probe time, but if the device is bound manually via sysfs interface, this could be -1 as "none", and this leads to OOB access for index[] and other parameters.
Add a sanity check for the card index and warn/correct it if it's a value out of the range.
--- sound/drivers/dummy.c | 6 ++++++ 1 file changed, 6 insertions(+)
sound/drivers/dummy.c +6 -0
@@ -1042,6 +1042,12 @@ static int snd_dummy_probe(struct platform_device *devptr)int idx, err;int dev = devptr->id; +if (dev <0 || dev >=SNDRV_CARDS ) { +dev_warn (&devptr->dev, +"Invalid card index %d, using default 0\n" , dev); + dev =0 ; + } + err =snd_devm_card_new (&devptr->dev, index[dev], id[dev],THIS_MODULE ,sizeof (struct snd_dummy ), &card);if (err <0 )
Signature · 1 line
2.55.0